From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45562: [PATCH] Fix "comparison always the same" warnings found by lgtm Date: Wed, 21 Jul 2021 13:30:10 +0200 Message-ID: <87im13lxa5.fsf@gnus.org> References: <83zh1ugj30.fsf@gnu.org> <87o8i87gu3.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28789"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45562@debbugs.gnu.org, Stefan Kangas To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 21 13:31:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6ARj-0007LX-AE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 13:31:27 +0200 Original-Received: from localhost ([::1]:38308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6ARi-0008Ut-BF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jul 2021 07:31:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6ARK-0008TL-DS for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 07:31:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m6ARK-0004Cs-5S for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 07:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m6ARK-0006Nw-3e for bug-gnu-emacs@gnu.org; Wed, 21 Jul 2021 07:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jul 2021 11:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45562-submit@debbugs.gnu.org id=B45562.162686702222181 (code B ref 45562); Wed, 21 Jul 2021 11:31:02 +0000 Original-Received: (at 45562) by debbugs.gnu.org; 21 Jul 2021 11:30:22 +0000 Original-Received: from localhost ([127.0.0.1]:36268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6AQg-0005lL-6u for submit@debbugs.gnu.org; Wed, 21 Jul 2021 07:30:22 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m6AQe-0005dh-4n for 45562@debbugs.gnu.org; Wed, 21 Jul 2021 07:30:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8O7AyMRDU0MoA6T02Bb7FEHQLeXuV48BRbQ9n7wct7s=; b=M1Q5DU6DTJogvl7tWEJh1mwWd8 lXN81soIElNDDQXrDUec33gYnvYrhMoFbAPLkCFJLtwVmeKY2b3FQMB4yKyorPGmne5Nmd7EvHxX/ ZC7AhHpgJ4vkSQqjOkuALr7nr8kFEXjtEwK1EeEW+B6UNL4BaYxu9JAeNbwUBMhsjTHI=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6AQU-0005wy-Sp; Wed, 21 Jul 2021 13:30:13 +0200 X-Now-Playing: Orchestral Manoeuvres in the Dark's _Souvenir (1): The Singles 1979-1987_: "La Femme Accident" In-Reply-To: <87o8i87gu3.fsf@igel.home> (Andreas Schwab's message of "Fri, 01 Jan 2021 17:38:28 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210418 Archived-At: Andreas Schwab writes: >>>> --- a/src/fns.c >>>> +++ b/src/fns.c >>>> @@ -3847,8 +3847,6 @@ base64_decode_1 (const char *from, char *to, ptrdiff_t length, >>>> if (c == '=') >>>> continue; >>>> >>>> - if (v1 < 0) >>>> - return -1; > > Looking at commit 5abaea334cf, that likely needs to test v1 == 0 instead. Seems like so to me, too. So I've now made that change on the trunk -- so the lgtm checks found a real bug there. As for the others, skimming this thread there didn't seem to be any consensus that the proposed changes makes the code any better (or clearer), so applying those doesn't seem to be a net win, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no