From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 501e2096d6: Fix some issues with a recent change Date: Mon, 27 Dec 2021 14:19:20 +0800 Message-ID: <87ilva1sev.fsf@yahoo.com> References: <164051393145.21885.8315099612759503047@vcs2.savannah.gnu.org> <20211226101851.B61E5C04DCC@vcs2.savannah.gnu.org> <83bl13nsav.fsf@gnu.org> <87fsqe3ly7.fsf@yahoo.com> <874k6u3alb.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22911"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 27 07:21:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1jO7-0005m6-FK for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Dec 2021 07:21:39 +0100 Original-Received: from localhost ([::1]:48808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1jO5-0003Ob-51 for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Dec 2021 01:21:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1jMA-0002b7-Mw for emacs-devel@gnu.org; Mon, 27 Dec 2021 01:19:39 -0500 Original-Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:38977) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1jM6-0000o6-BJ for emacs-devel@gnu.org; Mon, 27 Dec 2021 01:19:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640585972; bh=5wI10sFIePBQzG2pxNM0WV/eCX60eX4wXf+KUHgj/iI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=LPDCTWexaWe6zJCPaKxK/3atgnJfDawk25U0Pgjh9wGKwR/pxED2pCSaw66NQS0FPhU6pN9vhZb969CT0dUXL3Xpk/8gyzsiIjJC5tgVkQ4GPsNaatlt419UZE2steR9HJ/4N30u3k6C+O1mkd+TxrhtEQwIvg8aX5Y6vgsYSHjCEuBVBFD2Fu8bnKK1OrHQgoCgkod1wsHahq08gSdhp7cVx1ifENRij5Oimi9kNGSlnlmlBdObaTsbZMuCpwyoJ/ebZY7goCLO5w0+ALCz32NBiiJmg/ef5naWbY2VI3WcEobrCHs6ziKfuacakGPeXHBW9GqGpPtFbmndjggkVw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640585972; bh=/isq4sUN0xz8BbdIj07bsk/9jg6tONLJVug6zFcIoLy=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=F3JwQPoLmW1c44LUtiIpmdxgiwIC45rolv82h8uGXDAk2xLcdJ5DUttzY8SzdBCQoT8nSwroI1akJhwao/rp8cLgfLY6WmEREmaKWy/aTZscYM5ARzF5RHjvrLeWnCMlwKiIlG4yyEU6FWfD+9JHwTAoNXNRxEyOyXmNE5kW76Js6msdfzXbnuzRXNUVrBtF661GZlSyVuC+Ei6WrjKjFpEY3LyjXxWfQNheOAsiRuOsH6hNRxmN7e2w8fvb8SNiYDkya/ok0HfYEzdV5zaS20z3sd5ZTmx8cGuW9CZa82o4IV5qXNedSxyh3NwFoH9mTj7mkrpQ3e4rfi/NZH8Atg== X-YMail-OSG: 53FtD_IVM1m.rg.1NkTaMT0xMRjWA1qbagFlAFS5rawDS3hxRi2xmQ7IMrpBnWY SNXiwITgX6_WROD6KGq_AujDolS2RnFBEciZRD.z0o8X3lI9MUP9HI6qdBIb9L_wSUuC_zxUk0PE kM9RVakj3dEw81Nim5Tel__cDLNG6S8oYLcfwcl8zPzTbynpUUOfA6nzPYXxqTINhdibteczdrgO 1y_T8i.DoUqdD_kt5bbp59gdHp0V6Ruu5763fw_SUXryITJGTnMcyMtw0XAU1tssHuE9pAS.ta1G ErMQLt3tk7Gpb21.djd7t2vxSZ.hHYo2oYtTRRHU1ODUnY9TGK_kW1AcGcNlZleE8ZJYHPs8TvIi aSNMqHXOTSg_zrAuVTuzMoHy7qgs73C74zY0MSN5zPa7yCpUxp7ALMrPSEr.dUndNWyMFT2NAMsD pTJAg4eLMcuJ5EzRioRSWBgPmcdYlbHFCtx8LNXrOLAuP5xxtOjx15w01UXKzokBYMS7AIYuFGKL P9eFqffeySGgVL6rAXakUaxaKaH0JJ_eB1aKT6zXWz99Fck.O7RuPTL57rtXGxatbo73WrAtXnEk 50JUtNT9d.MMc7OJKriRl95AWlM5Y8O0VlHtrGpSqXRTalD1IPZpCGWzerhSjuL3eQANOf.VHrjd IXm12lkq3DfmXnXOmo58iiUghyUfmY.QQ1zzA7_PMpXFBGU2i4B3azFO0_zml3yTaCtsGGHSrOiq gCj14sNKbyZhB8GaZAl9by4uwwx9CKYDMdVCDqNxg7gnY_4iDb_hXNY73Ui3qbU5s7Hthk9QN27H Q3xLDHqW.gnTzJH4JQPorPRIKyNaHIno7EktAVYFxX X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Mon, 27 Dec 2021 06:19:32 +0000 Original-Received: by kubenode516.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID b583107bd95391bbec4a6bc8858c5f50; Mon, 27 Dec 2021 06:19:25 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Mon, 27 Dec 2021 01:14:46 -0500") X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.82; envelope-from=luangruo@yahoo.com; helo=sonic306-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283400 Archived-At: Stefan Monnier writes: > Maybe we can't agree on it being "secondary" but all those changes are > related to pinch or to code that is itself related to that. > So including those words would give some hint as to what it is you've > changed, whereas the first line you've used gave no indication > whatsoever about which part of the codebase was modified. Okay, so how about "Fix some issues with the recently introduced pinch support?"