From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/rainbow-delimiters a32b39bdfe: Add license file with GPLv3 Date: Sun, 02 Jan 2022 11:52:39 +0000 Message-ID: <87ilv2s6bc.fsf@posteo.net> References: <164107430330.17202.17260845381664886032@vcs2.savannah.gnu.org> <20220101215824.BB13CC0DEC3@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18169"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 02 12:53:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n3zQj-0004Wy-12 for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jan 2022 12:53:41 +0100 Original-Received: from localhost ([::1]:56100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n3zQg-0007li-QS for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jan 2022 06:53:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3zPo-00072H-Ht for emacs-devel@gnu.org; Sun, 02 Jan 2022 06:52:44 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:56525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3zPm-0001Hr-Rq for emacs-devel@gnu.org; Sun, 02 Jan 2022 06:52:44 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 6EDB3240029 for ; Sun, 2 Jan 2022 12:52:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1641124361; bh=Ndktxa5/GQJahAwctyjxAM0EzGZsTAJeX348/WAQL6A=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=geKsdLHTqJ35HyXaih748JD2aqKWEGGkqiykUInysaOuap49ItXnKkLnK0w8GjK9R sn1p1A9sckFkjD05Em43I2+FmhR4UTBluk//UPxl8sJhln5sHHy0TsQ+zSlGl55J+7 kb2hUcQ1MjncB7jM6Zrs+x+GLMqpgB4jtC540xm2VRgpBa6t5N9qx2fPJGQdbt/HWs t1oHaIPIuy7Szw8N3I4Dc+G+PzNYV+DE0auN+R0tMth8psEZLsXwaLn2OhDRfen8/4 RF0jTSnrkBPF6fmzqb4ruwLIkuv/xkewtW9NZhSoflF6Fr7B12i9o7ZyWbeAXK0KJm YTQ/2AMxL007g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JRcgr1tKpz9rxM; Sun, 2 Jan 2022 12:52:39 +0100 (CET) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: (Stefan Kangas's message of "Sat, 1 Jan 2022 19:02:30 -0500") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283890 Archived-At: Stefan Kangas writes: > Stefan Kangas writes: > >> How about adding the files "LICENSE", "LICENSE.md" and "COPYING" to a >> global ignore list instead? (Those three being the variations I have >> seen so far.) > > IOW, how about something like this (untested)? I think there are some > other files that we could always exclude as well, like ".dir-locals.el", > ".github", "*-tests.el", and ".travis.yml". Not sure about .dir-locals.el (the developers might be using the special kind of indentation set via .dir-locals.el), but next to these I'd also suggest removing "Cask" and "Makefile". And while we are at it, is there a reason not to add a MELPA-like keyword to manually specify what files are part of a package? Whenever a single repository is used to maintain multiple packages (like Magit or Embark) there is always a long list of :ignored-files that have to be duplicated for every package. Perhaps a more general version of .elpaignore could be used to declare packages externally. > diff --git a/elpa-admin.el b/elpa-admin.el > index b4ad318ef..37b3112dd 100644 > --- a/elpa-admin.el > +++ b/elpa-admin.el > @@ -562,6 +562,10 @@ auxillary files unless TARBALL-ONLY is non-nil ." > "######## Build of package %s FAILED!!") > tarball))))) > > +(defvar elpaa--make-tarball-global-ignore > + '("COPYING" "LICENSE" "LICENSE.md") > + "List of files that will not be included in the tarball.") > + > (defun elpaa--make-one-tarball-1 ( tarball dir pkg-spec metadata > &optional revision-function tarball-only) > (elpaa--with-temp-files > @@ -572,7 +576,8 @@ auxillary files unless TARBALL-ONLY is non-nil ." > (make-directory destdir))) > (vers (nth 1 metadata)) > (elpaignore (expand-file-name ".elpaignore" dir)) > - (ignores (elpaa--spec-get pkg-spec :ignored-files)) > + (ignores (append (elpaa--spec-get pkg-spec :ignored-files) > + elpaa--make-tarball-global-ignore)) > (renames (elpaa--spec-get pkg-spec :renames)) > (ldir (elpaa--spec-get pkg-spec :lisp-dir)) > (re (concat "\\`" (regexp-quote pkgname) > > -- Philip Kaludercic