From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Date: Mon, 24 Jan 2022 10:46:51 +0100 Message-ID: <87ilu94gac.fsf@gnus.org> References: <868u41rv84.fsf@yandex.ru> <83fuy8p8oq.fsf@gnu.org> <568FA9D0.2040609@yandex.ru> <83egdsp88n.fsf@gnu.org> <568FABFC.3000205@yandex.ru> <87tufr74of.fsf@gnus.org> <87lf0yjwpw.fsf@gnus.org> <87r1aodus0.fsf@gnus.org> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@yandex.ru> <87ilvy4m94.fsf@gnus.org> <87czklnqvs.fsf@gnus.org> <3045ca8b-f5d6-c85e-d170-3fe158fec64e@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32369"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 22324@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 24 10:48:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBvxX-0008Fw-At for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jan 2022 10:48:23 +0100 Original-Received: from localhost ([::1]:49750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBvxW-00060q-11 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jan 2022 04:48:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBvxD-00060H-LR for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2022 04:48:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBvxC-0001uE-4M for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2022 04:48:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nBvxC-0002Nw-3n for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2022 04:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jan 2022 09:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22324 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 22324-submit@debbugs.gnu.org id=B22324.16430176237043 (code B ref 22324); Mon, 24 Jan 2022 09:48:02 +0000 Original-Received: (at 22324) by debbugs.gnu.org; 24 Jan 2022 09:47:03 +0000 Original-Received: from localhost ([127.0.0.1]:42127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBvwE-0001pF-Rs for submit@debbugs.gnu.org; Mon, 24 Jan 2022 04:47:03 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:48572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBvwC-0001j1-Lz for 22324@debbugs.gnu.org; Mon, 24 Jan 2022 04:47:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0izFQiI2MbgWZAuoF2OfSjIvkk7Bx5TQr/BTfNF+W/I=; b=BVlNa0pDQ+dNURovLDZD388JKF nOCL8REVb/pDPStXADP/xNLVtoJN9/Hia/om4p4AjrbFD7CqVDX8ENcQi+msc1Al4jRksgpLr2dX5 tQpJTABNau/nSHeB7/VYw3cQz/Qr7+c5K7c503AWk5N+UTK4R2kQZaGLlpa25k3iz7Og=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBvw4-0006Ug-8Z; Mon, 24 Jan 2022 10:46:54 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUDBQwfGCEtLTFs bHCrrLDR0dXw8PJ9fYFgWmGPkJS9vcFFOEN+f4NNTVH///8PU95gAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+YBGAkIHpkDiBsAAAGcSURBVDjLrZJNS8NAEIZn41GEJD1JKdR4qUgOtRWtKFj6oRFvNZV6 bgb0rHfRXEQEKanQYg8iLejR/gm9qfUQkf4Xt5umH7vrzXchsPtk5t2dGYCRNNDTZRzosIgIk1Lc AFSKjj0FIOExUlq1n6cB6N06BY/uQR54kTvEnUtrUwAwX8ZcKtUXgVLE3P2LKgL9DHOND96A/hjd wFL+nQd0RV08zp9zYE4FNZbGqscD0EyIFPAkLQBwkzP0hRneA0ii5UqBppv05ZgSUhGtW6DgVfRQ WEtqosfiIACzfEV0I+hhlj83/TpKADH8NZYJH7i7Gv5bh4Ft3qF3GkzDrQA8lAHN6DWlAHT/D0BM NnFOmTOnId9tu4xHQgNpRfbatm21wr15HU5FzCtgpXExuo42KJrGQAedfGs6zbjq1fgwgBWZfZRB Y9FphZnooJEgjAHcV4cgDADyxcAu25GJdgXAqY1dQy1Rc9tKjvZqGBcp2E83C+oEGCqaaayAVHrf iMtJLLP+KTtXek1ry5CAWf/K+tElgCwbfbkJgf/WL9tlhd4YWsDQAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIyLTAxLTI0VDA5OjA4OjMwKzAwOjAw7+6+lQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0w MS0yNFQwOTowODozMCswMDowMJ6zBikAAAAASUVORK5CYII= X-Now-Playing: This Mortal Coil's _Filigree & Shadow_: "Red Rain" In-Reply-To: <3045ca8b-f5d6-c85e-d170-3fe158fec64e@yandex.ru> (Dmitry Gutov's message of "Mon, 24 Jan 2022 04:03:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225003 Archived-At: Dmitry Gutov writes: > So the fix I had in mind looks like: > > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index d58c23af8f..0aee55f33c 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -1043,7 +1043,7 @@ completion--styles > (let* ((cat (completion-metadata-get metadata 'category)) > (over (completion--category-override cat 'styles))) > (if over > - (delete-dups (append (cdr over) (copy-sequence completion-styles))) > + (cdr over) > completion-styles))) Oh, I see. Hm... that would change the behaviour for those that depend on this working the old way. Perhaps it'd make more sense to add a new variable to allow real overrides? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no