bug#44014: 28.0.50; Incorrect compilter warning that function is called with 2 arguments

bug#44014: 28.0.50; Incorrect compilter warning that function is called with 2 arguments

[Jean Louis]

I am getting this in my opinion incorrect compiler warning. I cannot
find myself what is wrong. It can be my own error.

Compiling file /home/data1/protected/public_html/gnu.support/files/tmp/2020-10-15/rcd-mailing.el at Thu Oct 15 16:21:07 2020
Entering directory ‘/home/data1/protected/public_html/gnu.support/files/tmp/2020-10-15/’

In rcd-send-mailings:
rcd-mailing.el:396:16: Warning: rcd-mailing-message called with 2 arguments,
    but accepts only 1 Disable showing Disable logging

The file that gives me warning is here:
https://gnu.support/files/tmp/2020-10-15/rcd-mailing.el

This warning is given under emacs -Q as well, from git version from yesterday.


In GNU Emacs 28.0.50 (build 18, x86_64-pc-linux-gnu, GTK+ Version 3.22.12, cairo version 1.14.8)
 of 2020-10-14 built on protected.rcdrun.com
Repository revision: 423439b38067c4a428310edab24fba7da082027c
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11907000
System Description: Hyperbola GNU/Linux-libre

Configured using:
 'configure --prefix=/package/text/emacs-2020-10-14 --with-modules'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2

Important settings:
  value of $LC_ALL: de_DE.UTF-8
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: @im=exwm-xim
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort hashcash mail-extr emacsbug message rmc puny dired
dired-loaddefs rfc822 mml easymenu mml-sec epa derived epg epg-config
gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache json map text-property-search
time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils tooltip eldoc electric uniquify ediff-hook
vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode elisp-mode lisp-mode prog-mode register page
tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core term/tty-colors frame
minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite charscript charprop case-table epa-hook jka-cmpr-hook help
simple abbrev obarray cl-preloaded nadvice button loaddefs faces
cus-face macroexp files window text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit
x multi-tty make-network-process emacs)

Memory information:
((conses 16 53456 6898)
 (symbols 48 7214 1)
 (strings 32 18999 1771)
 (string-bytes 1 620559)
 (vectors 16 11710)
 (vector-slots 8 164949 9188)
 (floats 8 25 44)
 (intervals 56 212 0)
 (buffers 992 12))

-- 
Thanks,
Jean Louis

bug#44014: 28.0.50; Incorrect compilter warning that function is called with 2 arguments

[Lars Ingebrigtsen]

Jean Louis <bugs@gnu.support> writes:

> I am getting this in my opinion incorrect compiler warning. I cannot
> find myself what is wrong. It can be my own error.
>
> Compiling file /home/data1/protected/public_html/gnu.support/files/tmp/2020-10-15/rcd-mailing.el at Thu Oct 15 16:21:07 2020
> Entering directory ‘/home/data1/protected/public_html/gnu.support/files/tmp/2020-10-15/’
>
> In rcd-send-mailings:
> rcd-mailing.el:396:16: Warning: rcd-mailing-message called with 2 arguments,
>     but accepts only 1 Disable showing Disable logging
>
> The file that gives me warning is here:
> https://gnu.support/files/tmp/2020-10-15/rcd-mailing.el

Two arguments here:

    (dolist (option options-ids)
      (rcd-mailing-message "Processing mailing list by option ID: %s" option)


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44014: 28.0.50; Incorrect compilter warning that function is called with 2 arguments

[Jean Louis]

* Lars Ingebrigtsen <larsi@gnus.org> [2020-10-15 16:32]:
> Jean Louis <bugs@gnu.support> writes:
> 
> > I am getting this in my opinion incorrect compiler warning. I cannot
> > find myself what is wrong. It can be my own error.
> >
> > Compiling file /home/data1/protected/public_html/gnu.support/files/tmp/2020-10-15/rcd-mailing.el at Thu Oct 15 16:21:07 2020
> > Entering directory ‘/home/data1/protected/public_html/gnu.support/files/tmp/2020-10-15/’
> >
> > In rcd-send-mailings:
> > rcd-mailing.el:396:16: Warning: rcd-mailing-message called with 2 arguments,
> >     but accepts only 1 Disable showing Disable logging
> >
> > The file that gives me warning is here:
> > https://gnu.support/files/tmp/2020-10-15/rcd-mailing.el
> 
> Two arguments here:
> 
>     (dolist (option options-ids)
>       (rcd-mailing-message "Processing mailing list by option ID: %s" option)

Thanks. Compiler warning shows different line number, is that normal?

bug#44014: 28.0.50; Incorrect compilter warning that function is called with 2 arguments

[Lars Ingebrigtsen]

Jean Louis <bugs@gnu.support> writes:

> Thanks. Compiler warning shows different line number, is that normal?

Here's a minimal case to reproduce the bug:

(defun bar (a)
  a)

(defun foo ()
  (bar 1)
  (bar 1 2)
  (bar 1))

It'll say that the error is on the final call to bar, not the preceding
line.  If I remove the first call to bar, then it puts the error on the
correct line.

Anybody know what could be causing this bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44014: 28.0.50; Incorrect compilter warning that function is called with 2 arguments

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 15 Oct 2020 18:34:10 +0200
> Cc: 44014@debbugs.gnu.org
> 
> Jean Louis <bugs@gnu.support> writes:
> 
> > Thanks. Compiler warning shows different line number, is that normal?
> 
> Here's a minimal case to reproduce the bug:
> 
> (defun bar (a)
>   a)
> 
> (defun foo ()
>   (bar 1)
>   (bar 1 2)
>   (bar 1))
> 
> It'll say that the error is on the final call to bar, not the preceding
> line.  If I remove the first call to bar, then it puts the error on the
> correct line.
> 
> Anybody know what could be causing this bug?

The byte compiler doesn't really track source lines, only sexps.  It's
a known issue.  There was a long discussion a year or so ago, and Alan
Mackenzie proposed a concept of a solution, but it turned out to slow
down compilation, so I don't think people were very enthusiastic.

bug#44014: 28.0.50; Incorrect compilter warning that function is called with 2 arguments

[Jean Louis]

* Eli Zaretskii <eliz@gnu.org> [2020-10-15 19:53]:
> > From: Lars Ingebrigtsen <larsi@gnus.org>
> > Date: Thu, 15 Oct 2020 18:34:10 +0200
> > Cc: 44014@debbugs.gnu.org
> > 
> > Jean Louis <bugs@gnu.support> writes:
> > 
> > > Thanks. Compiler warning shows different line number, is that normal?
> > 
> > Here's a minimal case to reproduce the bug:
> > 
> > (defun bar (a)
> >   a)
> > 
> > (defun foo ()
> >   (bar 1)
> >   (bar 1 2)
> >   (bar 1))
> > 
> > It'll say that the error is on the final call to bar, not the preceding
> > line.  If I remove the first call to bar, then it puts the error on the
> > correct line.
> > 
> > Anybody know what could be causing this bug?
> 
> The byte compiler doesn't really track source lines, only sexps.  It's
> a known issue.  There was a long discussion a year or so ago, and Alan
> Mackenzie proposed a concept of a solution, but it turned out to slow
> down compilation, so I don't think people were very enthusiastic.

Maybe the warning could tell about where exactly is located the
beginning char or line of sexp.

In that particular case of mine, it brought me to wrong line, and
indicated wrong line.

If it is not tracking lines but sexps, it could, in case of multiple
lines, tell where is beginning and where is the end, and bring user to
beginning of the sexp instead into seemingly random middle.

bug#44014: Byte-compile warnings on the wrong line

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Here's a minimal case to reproduce the bug:
>
> (defun bar (a)
>   a)
>
> (defun foo ()
>   (bar 1)
>   (bar 1 2)
>   (bar 1))
>
> It'll say that the error is on the final call to bar, not the preceding
> line.  If I remove the first call to bar, then it puts the error on the
> correct line.

This has now apparently been fixed by Alan's accurate errors change, so
I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44014: Acknowledgement (28.0.50; Incorrect compiler warning that function is called with 2 arguments)

[Jean Louis]

The real error is on line 360, but the compiler warning is showing
error on line 397.

It is still incorrect.