From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v" Date: Tue, 15 Mar 2022 12:39:00 +0100 Message-ID: <87ilsfwiln.fsf@gnus.org> References: <164727172121.17436.14797611985358127835@vcs2.savannah.gnu.org> <20220314152841.8DC85C06305@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13873"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Sam Steingold To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 15 12:52:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nU5ij-0003Nb-JW for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Mar 2022 12:52:09 +0100 Original-Received: from localhost ([::1]:44794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nU5ii-0005pZ-4G for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Mar 2022 07:52:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU5WC-00013m-KH for emacs-devel@gnu.org; Tue, 15 Mar 2022 07:39:13 -0400 Original-Received: from [2a01:4f9:2b:f0f::2] (port=42874 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nU5W9-000390-MU; Tue, 15 Mar 2022 07:39:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ouyu2BgtX/REuht/uExKZaCvmi3tOmGks3TXgr9Bp48=; b=HRiyEp0hIIfebZjGYD8xsFnPzw revdShHqs49bhA31+fFB5qO6zlUYBTIxD30uu4ajzWwgaG8KYXZbCkDleNACEnk9jw12gGJvT+tFH TOX4sp3vPNJEcIOAv/syigtUGG1dfBGq0YN/QnZOhdqzShxzIxFeA3mRhGJ6Oy+MZT6w=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nU5W1-0002En-T1; Tue, 15 Mar 2022 12:39:04 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEUtEAgMCAMyLCVc HA+dKhXQNBrlOhyXk4lZWVH1QyH///8/dARjAAAAAWJLR0QKaND0VgAAAAd0SU1FB+YDDwskObGy vvYAAAGRSURBVDjLjZKxbtswEIZ5kWx0vAOd7JGHdiRBJkA3GTwR8BbApPaiVl7BHdss0VggQJ+3 lBIkkkwDOVGCqE+8/+4nhUhBQMMYA8UYV4IuxKeAZJcHmxjrfCq2LgvQFnlgG+b3sqegLuNB6gww Nugyt0JYp01Oo2CnNZVNgAUo2QmQbfd4WFYVHcC6Y/uoZwA5pDaawJZ3ixVcEzrLztQLr5wmjEMc FpbsCLDrmLufcwBpgjFYbh7m4lCkp2dmvxAnle7rLnYdLLcW02het2smPhoorVl4JVBNHcXTr1P/ fPqTFJBmoKq2v7fmllAZqTCVli6BQypumnvWtF799ent7uiOYb/SgrR/uWmZxPouHPH+3ybwj+9t m0AMjd+z9r5tvd+vQnw5hrBPoNBSSQNSGVEnfVWABMBpucV4dL72T33/3N9O+xgb+1I9VdW3Cman hDITBATKgfS1hAzAwYNdBow/m0tglmsKrvUFsLkIzlPJce/kufhGqbdDMgeoqUj+njc4uFGovCVn IT6Kos+t+A/9H3V61JWcPAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wMy0xNVQxMTozNjo1Nysw MDowMCVHIdEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDMtMTVUMTE6MzY6NTcrMDA6MDBUGplt AAAAAElFTkSuQmCC X-Now-Playing: Joe Jackson's _Body and Soul_: "Go for It" In-Reply-To: <20220314152841.8DC85C06305@vcs2.savannah.gnu.org> (Sam Steingold's message of "Mon, 14 Mar 2022 11:28:41 -0400 (EDT)") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287179 Archived-At: Sam Steingold writes: > branch: master > commit f52dcfd03ad542704d9a43faab0c33be09ab442e > Author: Sam Steingold > Commit: Sam Steingold > > New command `gnus-summary-browse-all-urls' bound to "v" > > * lisp/gnus-sum.el (gnus-collect-urls-from-article): New function, > extracted from `gnus-summary-browse-url'. > (gnus-summary-browse-url): Use it; also use `browse-url-button-open-url' > to handle the prefix argument. > (gnus-summary-browse-all-urls): New command. > (gnus-summary-mode-map): Bind `gnus-summary-browse-all-urls' to "v". I've reverted this patch -- I did not agree that this command should be added, so you should not have pushed it, Sam. To reiterate -- I don't think this command sounds generally useful, and furthermore, if it is, it should not be bound to such a convenient key like `v', and moreover, the funky calling conventions of `browse-url-button-open-url' should be avoided. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no