From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Cc: Sam Steingold <sds@gnu.org>
Subject: Re: master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v"
Date: Tue, 15 Mar 2022 12:39:00 +0100 [thread overview]
Message-ID: <87ilsfwiln.fsf@gnus.org> (raw)
In-Reply-To: <20220314152841.8DC85C06305@vcs2.savannah.gnu.org> (Sam Steingold's message of "Mon, 14 Mar 2022 11:28:41 -0400 (EDT)")
Sam Steingold <sds@gnu.org> writes:
> branch: master
> commit f52dcfd03ad542704d9a43faab0c33be09ab442e
> Author: Sam Steingold <sds@gnu.org>
> Commit: Sam Steingold <sds@gnu.org>
>
> New command `gnus-summary-browse-all-urls' bound to "v"
>
> * lisp/gnus-sum.el (gnus-collect-urls-from-article): New function,
> extracted from `gnus-summary-browse-url'.
> (gnus-summary-browse-url): Use it; also use `browse-url-button-open-url'
> to handle the prefix argument.
> (gnus-summary-browse-all-urls): New command.
> (gnus-summary-mode-map): Bind `gnus-summary-browse-all-urls' to "v".
I've reverted this patch -- I did not agree that this command should be
added, so you should not have pushed it, Sam.
To reiterate -- I don't think this command sounds generally useful, and
furthermore, if it is, it should not be bound to such a convenient key
like `v', and moreover, the funky calling conventions of
`browse-url-button-open-url' should be avoided.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next parent reply other threads:[~2022-03-15 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164727172121.17436.14797611985358127835@vcs2.savannah.gnu.org>
[not found] ` <20220314152841.8DC85C06305@vcs2.savannah.gnu.org>
2022-03-15 11:39 ` Lars Ingebrigtsen [this message]
2022-03-15 15:26 ` master f52dcfd03a: New command `gnus-summary-browse-all-urls' bound to "v" Sam Steingold
2022-03-15 15:30 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilsfwiln.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.