From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 15ac51e0fd: Merge branch 'feature/completions-customs' Date: Tue, 22 Mar 2022 14:35:19 +0100 Message-ID: <87ils6m7oo.fsf@gnus.org> References: <164793742180.2038.4306130819331318764@vcs2.savannah.gnu.org> <20220322082342.60DC3C051F4@vcs2.savannah.gnu.org> <87mthijpyc.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17351"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Juri Linkov , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 22 14:36:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWegR-0004Ep-H7 for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Mar 2022 14:36:23 +0100 Original-Received: from localhost ([::1]:59102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWegQ-0003Go-Fe for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Mar 2022 09:36:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWefX-0001zc-Em for emacs-devel@gnu.org; Tue, 22 Mar 2022 09:35:29 -0400 Original-Received: from [2a01:4f9:2b:f0f::2] (port=52150 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWefV-0005JG-Ov for emacs-devel@gnu.org; Tue, 22 Mar 2022 09:35:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=plmvHD9YTevWFCix8uJIgbgY3Pxk65ahMO6g0RHCLnY=; b=FSCH35+sFGOchHDGkbiUxs9hsQ 72NUBtPLBzT3W5auRhJ08qiR/TCymvfdRm7uqmGFTjXfHeMG51q5sOl/BBPsYtb/LeceGbLKkgkYq FjOrRrnFkzCYH4UIonr7Mq8vq5QaJHdGTZN1CWn4DU6jeMWh6cqi5GddywJe5wpygccw=; Original-Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWefQ-0006AZ-Lq; Tue, 22 Mar 2022 14:35:22 +0100 In-Reply-To: <87mthijpyc.fsf@yahoo.com> (Po Lu's message of "Tue, 22 Mar 2022 17:28:59 +0800") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287352 Archived-At: Po Lu writes: > IHMO this should be off by default. It wastes a line of space in the > completions buffer for no real gain, and it's distracting. It used to be: ---- Click on a completion to select it. In this buffer, type RET to select the completion near point. Possible completions are: ---- And now it's: ---- Click on a completion to select it. In this buffer, type RET to select the completion near point. 134 possible completions: ---- So it doesn't waste any space, and it provides more information. I'd rather do something about the first three lines, though. Either remove them completely (it's pretty self-evident that that's what you do in that buffer, and especially now that you get mouse/point highlights, indicating that things are "buttons"). Perhaps it might make sense to remove all four lines, and put the number of completions in the mode line instead. > Also, I don't know which part of this change causes the following > behavior, but if I say M-x and then press TAB twice, the item at the > start of the window displaying the completions buffer becomes > highlighted, even though it isn't selected. That should also be off by > default, since it's an unnecessary visual distraction. Yes, that's somewhat confusing. Would it be possible to not activate the point highlight before the user has selected the completions window (one way or another)? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no