From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jai Flack Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: gnus-search-mu Date: Sun, 27 Mar 2022 14:12:30 +1000 Message-ID: <87ils0yqxd.fsf@disroot.org> References: <87czib77uz.fsf@disroot.org> <878rszidk9.fsf@ericabrahamsen.net> <87sfr6eunp.fsf@disroot.org> <8735j5tzus.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16829"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 27 06:48:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYKpa-0004EM-RD for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Mar 2022 06:48:46 +0200 Original-Received: from localhost ([::1]:37926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYKpZ-00035w-DR for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Mar 2022 00:48:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYKGh-0007qq-Lb for emacs-devel@gnu.org; Sun, 27 Mar 2022 00:12:43 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:50772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYKGf-0001PI-7I for emacs-devel@gnu.org; Sun, 27 Mar 2022 00:12:43 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 7E357401D1; Sun, 27 Mar 2022 06:12:38 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1g6JZ4YZ6QJV; Sun, 27 Mar 2022 06:12:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1648354354; bh=lc+eObd0b1lQnR7fmIwCVpSB5H9vDeAr983OPOQuTEU=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=h660fUKbINsVuwkRgT8jYwkoky3dnu4q4hJc7dzXrJ4ttMWYLcYYkuTWpEX1JPr/1 ES/NNVphX3u9jtvVdEgsRsk4ZsOxizpaKgvLj25A48aaCHU241KAj4CrQdFMjbUWGA oS+RNK6qrmJopLq3uhSkD6PCB83UbeaFrYeEN9avWXFTksk0p7wRCBhXB5JtxA+/+D sPj+1Kwqv0gUuVYbh1WH8TrHbFOhShnu5g0Y8Nc3Wa83gwnhFjLDc5Z9J3VK3k2tZW So0DVzzbDF0QqdOdFeoTuiu8rsBLEJWRCjO2tVYLZZj7cR76BL8uYLHMgV9qwCDCtG Xl3gl3qwTJlzQ== In-Reply-To: <8735j5tzus.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Fri, 25 Mar 2022 15:46:19 -0700") Received-SPF: pass client-ip=178.21.23.139; envelope-from=jflack@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 27 Mar 2022 00:47:00 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287494 Archived-At: Eric Abrahamsen writes: > Jai Flack writes: > >> Eric Abrahamsen writes: >>> Hi! Thanks very much for working on this. Wouldn't it make more sense to >>> include this in Emacs proper? Gnus-search is new enough that it doesn't >>> seem useful to let users of prior Emacs versions to install >>> gnus-search-mu from the repos... What do you think? >> >> I'm happy for it to be included in Emacs proper; though possibly as both >> a la modus-themes as it's missed the release window for Emacs 28 (if I >> understand the release cycle correctly). >> >> Shall I convert this to a patch for gnus-search.el? > > Sure! Thanks. > > Please note that engine custom options like -remove-prefix and > -config-directory have been moved away from `getenv' to something like: > > (expand-file-name "foo" "~") > > and it would be nice to stick to that convention. Sure. > Otherwise, please make sure that the first line of docstrings are a > complete sentence, and there's no need for a blank line between the > first sentence and whatever comes after. Right. > Out of curiosity, what is `ansi-color-filter-apply' doing there? I think I had trouble with mu giving ANSI escape codes to Emacs, it might no longer be a problem or maybe there is a better solution. -- Thanks, Jai