From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jai Flack Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: gnus-search-mu Date: Mon, 28 Mar 2022 09:43:02 +1000 Message-ID: <87ilrz9d2x.fsf@disroot.org> References: <87czib77uz.fsf@disroot.org> <878rszidk9.fsf@ericabrahamsen.net> <87sfr6eunp.fsf@disroot.org> <8735j5tzus.fsf@ericabrahamsen.net> <87ils0yqxd.fsf@disroot.org> <87ilrzuoof.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18806"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 28 04:22:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYf17-0004gY-0p for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Mar 2022 04:22:01 +0200 Original-Received: from localhost ([::1]:43864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYf15-0007HJ-Si for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Mar 2022 22:21:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYcXV-0004Jz-I9 for emacs-devel@gnu.org; Sun, 27 Mar 2022 19:43:17 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:50910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYcXS-0004mG-L4 for emacs-devel@gnu.org; Sun, 27 Mar 2022 19:43:17 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 5E1EB401C9; Mon, 28 Mar 2022 01:43:12 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1c0g0GPo-CHD; Mon, 28 Mar 2022 01:43:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1648424587; bh=zIN5/s4qy6e1dUp40XmpPiAVM95OdOO7da8nPJNVjMs=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=RndBDv+2bqvmTqu3mW2g/vcg+B4ctmOisQePhT8SNsS3NvnLBsta2Ah9oyj4BBlKC ox/iWu6homJbrOvHKGcnoc5aCNU/heHm0hYbwDercYbKTXC8KeBnveyIQsuKekwOwV +uIrjYztxlrYWu4WCR3Tih/5Cbku0pCIV4d89ISCdoEak6Dja/9dN19pm/mZyY7gCD GK3/J0MnPKGTdgkmZ8s3DXkIHgh8pCJYRIVUSW5cfc63gTFT39Swrs1q+fT3dZBb7z TwRXsmm1kyB6uP4meS1xml9ODuZURfjx9cLoZJ9W6I1GcotiOCltF2hMOiSQUFpdaM eqJ/x2P3ll43g== In-Reply-To: <87ilrzuoof.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 27 Mar 2022 13:26:56 -0700") Received-SPF: pass client-ip=178.21.23.139; envelope-from=jflack@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 27 Mar 2022 22:20:54 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287515 Archived-At: Eric Abrahamsen writes: > Jai Flack writes: > >> Eric Abrahamsen writes: >> >>> Jai Flack writes: >>> >>>> Eric Abrahamsen writes: >>>>> Hi! Thanks very much for working on this. Wouldn't it make more sense to >>>>> include this in Emacs proper? Gnus-search is new enough that it doesn't >>>>> seem useful to let users of prior Emacs versions to install >>>>> gnus-search-mu from the repos... What do you think? >>>> >>>> I'm happy for it to be included in Emacs proper; though possibly as both >>>> a la modus-themes as it's missed the release window for Emacs 28 (if I >>>> understand the release cycle correctly). >>>> >>>> Shall I convert this to a patch for gnus-search.el? >>> >>> Sure! Thanks. >>> >>> Otherwise, please make sure that the first line of docstrings are a >>> complete sentence, and there's no need for a blank line between the >>> first sentence and whatever comes after. >> >> Right. Were there any docstrings in particular you noticed that didn't make up a complete sentence? I've updated them to be (roughly) the same as the notmuch and namazu backends but the first lines already matched. >>> Out of curiosity, what is `ansi-color-filter-apply' doing there? >> >> I think I had trouble with mu giving ANSI escape codes to Emacs, it >> might no longer be a problem or maybe there is a better solution. > > Okay, sounds good! ansi-color is built in so there's no harm in that. I've changed this to use the --nocolor option for mu. > I'm assuming you have done copyright assignment. Do you have push > permissions for ELPA and/or Emacs proper? Done copyright assignment. Don't have any push permissions. For the ELPA package is there a good way to signal to users that the built-in version should be used on a recent-enough Emacs version? -- Thanks, Jai