From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GAm4HMNqTmJeTgAAgWs5BA (envelope-from ) for ; Thu, 07 Apr 2022 06:38:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2INdGcNqTmKEDwEAauVa8A (envelope-from ) for ; Thu, 07 Apr 2022 06:38:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 14F38F640 for ; Thu, 7 Apr 2022 06:38:27 +0200 (CEST) Received: from localhost ([::1]:42900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncJUq-00017M-IS for larch@yhetil.org; Thu, 07 Apr 2022 00:11:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncJTx-00017D-4w for emacs-orgmode@gnu.org; Thu, 07 Apr 2022 00:10:53 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:41659) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncJTv-0006xg-Kw; Thu, 07 Apr 2022 00:10:52 -0400 Received: by mail-pl1-x62a.google.com with SMTP id s11so3790994pla.8; Wed, 06 Apr 2022 21:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=Cshoe6+1xN/jBwiI+gEToDlsjb6looiaHwQDoWBM/qQ=; b=H4TCVn2zdHvOTlwceong/O3eqoAdMuOS2qd5IqFdzHo7cht+Zjr6cUR2o8ZkVxGD+b /R+WooqYmp2rkPrFxa9Ke4gB1O9GoYc+nj3K7+su+z4e72ckuL4+jwwQtMi0uz9O+ywt NiOLblgKgfHJBPVE+uaGzThizSeDvUAKaudKhz3Ybi32vSox1i4FF4HOStdmbADLi0jQ p1qszTW+WkfwOoMWnCHfoZs2t+xwvqDjdL/+mZgcqNaKlV/oblpcwoEzYXYqAjs6byt5 Z/vMNTpyfxWEpAzu4yomwpygSEii69PYJzMSVMkxDaaz5Rqp/W7PrOg8jOM2g81k5KhC r9Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=Cshoe6+1xN/jBwiI+gEToDlsjb6looiaHwQDoWBM/qQ=; b=y+517KnRmzZvRg2ySOj2FQ8uvo6inwOqQ51RahMwUyarxPf5hAfjJcwToT1986DQL7 4pKRRKMSMydPsE3CvtTt85gEOBUQEYsEQpEWCRyuANeyld4ZBP7hLMDAcPQmKvNa9yRF kXMUfXNPKyCwN+n95qHQ2TgO9Ya/LcxPA1bxiXczXold+Cu8OYPO1lOLW4MqV+cDRMIW QuRGz1TBoGJX+410dXvd4Lw0XkiLLUH74S/B0kMz8GZfUNdLtSytij1zkoK/P3ikeFIR 2crXdt9ANbm8Z4dX48Q2vLhqRe3006/LX92xvcTaW8qeo0ASS8G6vZdAb8jAa4NFkMmK I9xQ== X-Gm-Message-State: AOAM531lRz80ULSlvs9qiKmjuo7pwtLcwuU4N+uD8jvI0/qGwXAC74xh u+oec7vW1zxVeSvHv2x8kw6Vy1nJAJvobg== X-Google-Smtp-Source: ABdhPJzokroffEeSe7z7fruT2EAVyDLJEK8OlsgR75GYej3vLk/h7kr5E5j4ViFXrA7iUKquDH60FA== X-Received: by 2002:a17:902:bb84:b0:156:a412:24bc with SMTP id m4-20020a170902bb8400b00156a41224bcmr11671633pls.72.1649304649208; Wed, 06 Apr 2022 21:10:49 -0700 (PDT) Received: from localhost ([208.115.232.2]) by smtp.gmail.com with ESMTPSA id o11-20020a17090aac0b00b001cab1712455sm6785059pjq.40.2022.04.06.21.10.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Apr 2022 21:10:48 -0700 (PDT) From: Ihor Radchenko To: Bastien Guerry Subject: Re: Drop defadvice from Org In-Reply-To: <87y20pmjo9.fsf@gnu.org> References: <87a6drnsv6.fsf@gnu.org> <87a6dq46kd.fsf@gnu.org> <87y20pmjo9.fsf@gnu.org> Date: Thu, 07 Apr 2022 12:11:14 +0800 Message-ID: <87ilrl7ct9.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=yantar92@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Stefan Monnier Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649306307; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Cshoe6+1xN/jBwiI+gEToDlsjb6looiaHwQDoWBM/qQ=; b=gWwwXnVWJsNnGrqTpiZx3qJXMh84Cln8k52RmmAX83OAG24g0B0uoF6Jeak1y6zFmE67ad dfw437rhHEWgp5Wyhat0gPo9HNjOevA47EZ8CD/J4qsgkpzMwrcxNdAGfnBxJwOJnK01iC IAIwjgGjyPDkS6S42+Fmf/UAB5fuPvl+AXvZ1/pN3Oy/7h8pjGdOs4akr1e8eaEzBi1IKM NUXLQBT7KFRDSzHtitaDZUC5pQ3ZJHNrnYtmZtgUGI9AvinyStTCbe2pKtCObybdAMcyRd LGls7YzZGMvOVyNck3yPHVHHTyuD05FsnWKkOSRlxU+hl7EmAGMXtVgDNMJjaA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649306307; a=rsa-sha256; cv=none; b=Esz9m33LKRipiYX33swGA9Jh0SMqwxZLt3tcpvW1xi/yfJNiQD9TYbTBfdnEP2IIvQ/oAV RZjJ0tHci7/F1xiEcoUGCPyj9r5YVSq4fzAM+g4u7oBjkqltMxWZgAx4QSzwXXsTrl3wPR sV7lF0DIT6ePruZM2Z+levZCjFEHuKuhNOEaE+mPBo/ghi2FpdWeHfx7EguW9nlr1xXj8/ iszjZFKM5DFbl0ZJZ7uky/swVBxmYEoBJVzouGeDVi8EJyz8KkisNdh4VNLGKGWZEChz4L drK8ROI9yYU49yBCuSN3GhkB39cyTiaaE4ighuBwkASULQmW81S4baI8e8L6bQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=H4TCVn2z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=H4TCVn2z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 14F38F640 X-Spam-Score: 6.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: RcNMKE5I96aW Bastien Guerry writes: > Stefan Monnier writes: > >> The patch below gets rid of the old `defadvice`, replacing it with >> `advice-add`. > > Applied in the main branch as 6d73cd34a, thanks a lot! The change in (eval ...) call inside org-diary-sexp-entry broke sexp timestamps. See orgmode.org/list/875ynnojvf.fsf@localhost I think that calendar-related evals should be reverted to use dynamic scope. AFAIU, diary staff is relying on dynamic scope and cannot be used with lexical. Best, Ihor