From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Adding with-gensyms and once-only to subr-x Date: Mon, 11 Apr 2022 16:15:09 -0700 Message-ID: <87ilrftdoi.fsf@melete.silentflame.com> References: <87sfqja2eu.fsf@melete.silentflame.com> <87o817tlk2.fsf@melete.silentflame.com> <87lewbte4c.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39432"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 12 01:16:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ne3H5-000A2g-4H for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 01:16:49 +0200 Original-Received: from localhost ([::1]:49864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ne3H3-0005dh-Rv for ged-emacs-devel@m.gmane-mx.org; Mon, 11 Apr 2022 19:16:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ne3Fl-0004Tt-7B for emacs-devel@gnu.org; Mon, 11 Apr 2022 19:15:25 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51027) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ne3Fa-0006fi-CT for emacs-devel@gnu.org; Mon, 11 Apr 2022 19:15:15 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 86BF65C0271; Mon, 11 Apr 2022 19:15:10 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 11 Apr 2022 19:15:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1649718910; x=1649805310; bh=JJ 8nZS2bAxnTLAVCXXsR/2Db9YM4SjCNNtk+ehfQHe4=; b=Plvyf4ULGLHs0NSDx3 OQzDji7tSLqsEofbk/7f6ziFUGjey8JaRfdqONWTyPOKWfZxnNKOa2FRTo63rJ9f 9BC0Owt1fu237iCtGsuIAMdiXt4fbbVlr5DQqFbGV03Z5fuO72OPCPE7VS92aUy8 KLd7yW+ejqexgK8QEAKvy7sL+BG/r3mHKMdV2fWmYbqAB6Il/RHjnJziEHuh8TWU Dbf4zx+hJffvzwAhIvwLP0Syx/l4uF4/iFEH2vA01ayZe2FebSwOYPsf7u2S6CxY TK5E1BGdQWcqZ6haWYkRqxlb6+zdYrZxKvIV8ffOkaMUhpkMi2ZmtjUPGx3cqCF1 gY8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1649718910; x= 1649805310; bh=JJ8nZS2bAxnTLAVCXXsR/2Db9YM4SjCNNtk+ehfQHe4=; b=J G0PAeoqg/Ibyr4jNBjoSajziqyVknM+WlSrDub4BBxqkmLB4dsIVa5/Aycapyr9s 0JPw8fXzG7fE9X941BwnkdiQ4cxDOu7ljW2ZLmNX87HnnVdeM1Kt021+iNMxuz0Y L6dzniWoa1vNpDd5C6iKC/kZ991XaWQMK9VdwUP2DlEBxyipelZDWlzbmYf/XYZr tfgWfyrCgMC37Bo7OKlSPVAUhlG31CAtI+rJyuJejMqyShIbfrXVUyQJ5+N8YVM+ J+/4WgfA8/zAIDbFyy7oL88YxFIkKqaCNNfRTnyfrwmWL1Btr0dquVS0hH/K/FHL tO+w0jfKTBIoImoMnxq0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekjedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhgffffkgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepleeggefgvdeijedvhfdugfegtefgkeekueeileejjeehudeg geefteeghfeuffeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Apr 2022 19:15:10 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 5229A7E3DB1; Mon, 11 Apr 2022 16:15:09 -0700 (MST) In-Reply-To: <87lewbte4c.fsf@melete.silentflame.com> Received-SPF: pass client-ip=66.111.4.29; envelope-from=spwhitton@spwhitton.name; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288254 Archived-At: Hello, On Mon 11 Apr 2022 at 04:05PM -07, Sean Whitton wrote: > Hello, > > On Mon 11 Apr 2022 at 05:11PM -04, Stefan Monnier wrote: > >>> Are you okay with 'with-gensyms' in subr-x? Another option is to call >>> it macroexp-with-gensyms and add a cl-with-gensyms alias, or add >>> cl-with-gensyms alone (the name is similarly standard). But as the >>> macro is much simpler and more commonly used, it would be nice to have >>> the shorter name. >> >> `cl-with-gensyms` is fine with me. > > Sorry, so you mean adding cl-with-gensyms to cl-macs.el rather than > adding with-gensyms to subr-x as in my original patch? On second thoughts, cl-with-gensyms is probably easier to remember than with-gensyms, given that we are going with cl-once-only. I'll push that shortly. Thanks again. -- Sean Whitton