From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache Date: Thu, 05 May 2022 08:28:39 -0700 Message-ID: <87ilqkngm0.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11734"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 55275@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 05 17:37:02 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmdXJ-0002pt-KC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 17:37:01 +0200 Original-Received: from localhost ([::1]:58024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmdXI-0002W4-AR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 11:37:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmdPa-0004uN-Db for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 11:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmdPa-0001UC-4Z for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 11:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nmdPZ-0005oJ-TE for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 11:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 May 2022 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55275 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165176453222316 (code B ref -1); Thu, 05 May 2022 15:29:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 May 2022 15:28:52 +0000 Original-Received: from localhost ([127.0.0.1]:46213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmdPP-0005ns-NC for submit@debbugs.gnu.org; Thu, 05 May 2022 11:28:51 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmdPO-0005nl-Ds for submit@debbugs.gnu.org; Thu, 05 May 2022 11:28:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmdPN-0004nu-S6 for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 11:28:49 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:55702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmdPM-0001Qv-Ar for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 11:28:49 -0400 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5A84EFAAF6 for ; Thu, 5 May 2022 15:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1651764520; bh=PEyl8eHqZCFJ3FJbnyy//VZWQyHTf+AWmH4u/8XR6lY=; h=From:To:Subject:Date:From; b=c5TuonDOYgXuh6FmNPenAutX8XyLSg67F3aoN8f6pARk+XtYrU5VAhmop7bcOD2xN M4tZEyLfKKxdxIiYq0nX3OP/eqpyG8VInwOpGVvc9Hk+rOM+F1PxTpfSwY2JqJ8MGM iM4CffyTzmaDseGeKvE0DkaCxvCumo1XEXgaiUnI= Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231443 Archived-At: In ./lisp/gnus/nnvirtual.el, the `nnvirtual-retrieve-headers' deffoo let-binds `gnus-use-cache' to t when it uses `gnus-retrieve-headers' on its various constituent groups. For users not using the cache, this will result in an error. I can put an additional check in gnus-cache.el when we call `gnus-cache-retrieve-headers', but it would be nice to know why this necessary in the first place. The code comment on `nnvirtual-retrieve-headers' says: ;; FIX FIX FIX we want to check the cache! ;; This is probably evil if people have set ;; gnus-use-cache to nil themselves, but I ;; have no way of finding the true value of it. All the above is true, except I don't understand why we want to check the cache. This code is ancient and I'm only medium-hopeful Lars remembers the reasoning here, but on the face of it I don't know why we need to force a check of the cache. It seems like we could simply remove that, and the cache will still be checked iff the user has set `gnus-use-cache' to t.