all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 12840@debbugs.gnu.org
Subject: bug#12840: 24.2.50; ediff: mode-line of control buffer - improvement request
Date: Tue, 14 Jun 2022 16:45:02 +0200	[thread overview]
Message-ID: <87ilp31ez5.fsf@web.de> (raw)
In-Reply-To: <87leu0sme0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 13 Jun 2022 15:50:31 +0200")

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I've now done these changes in Emacs 29 -- removed the "Quick Help"
> thing with the plain setting, and made the informative parts bold
> (using your suggested function).

Thanks.

I would rather like to avoid to decide based on the value of
`ediff-window-setup-function' since users may wish to implement their
own setup functions.

Maybe a better approach of deciding would be to make it depend on
whether the Quick Help is currently displayed?  Seems there is a
variable we could use:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-WIP-Tune-when-to-show-Quick-Help-in-Ediff.patch --]
[-- Type: text/x-diff, Size: 1045 bytes --]

From fb2ff90ea8011eb7ebe1961869a74374a266c1d6 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Tue, 14 Jun 2022 15:09:31 +0200
Subject: [PATCH] WIP: Tune when to show "Quick Help" in Ediff

---
 lisp/vc/ediff-wind.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/vc/ediff-wind.el b/lisp/vc/ediff-wind.el
index 4549b910b1..6db3667545 100644
--- a/lisp/vc/ediff-wind.el
+++ b/lisp/vc/ediff-wind.el
@@ -1136,9 +1136,7 @@ ediff-refresh-mode-lines
 	  (if (ediff-narrow-control-frame-p)
 	      (list "   " mode-line-buffer-identification)
 	    (list "-- " mode-line-buffer-identification
-                  (and (not (eq ediff-window-setup-function
-                                'ediff-setup-windows-plain))
-                       "        Quick Help"))))
+                  (list 'ediff-use-long-help-message "        Quick Help"))))
     ;; control buffer id
     (setq mode-line-buffer-identification
 	  (if (ediff-narrow-control-frame-p)
--
2.30.2


[-- Attachment #3: Type: text/plain, Size: 11 bytes --]



Michael.

  reply	other threads:[~2022-06-14 14:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-08 17:29 bug#12840: 24.2.50; ediff: mode-line of control buffer - improvement request Michael Heerdegen
2022-05-10 12:08 ` Lars Ingebrigtsen
2022-05-11  0:02   ` Michael Heerdegen
2022-05-11 11:51     ` Lars Ingebrigtsen
2022-06-13 13:50       ` Lars Ingebrigtsen
2022-06-14 14:45         ` Michael Heerdegen [this message]
2022-06-15 12:09           ` Lars Ingebrigtsen
2022-06-19 12:30             ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilp31ez5.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=12840@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.