bug#12840: 24.2.50; ediff: mode-line of control buffer - improvement request

[Michael Heerdegen <michael_heerdegen@web.de>]

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I've now done these changes in Emacs 29 -- removed the "Quick Help"
> thing with the plain setting, and made the informative parts bold
> (using your suggested function).

Thanks.

I would rather like to avoid to decide based on the value of
`ediff-window-setup-function' since users may wish to implement their
own setup functions.

Maybe a better approach of deciding would be to make it depend on
whether the Quick Help is currently displayed?  Seems there is a
variable we could use:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-WIP-Tune-when-to-show-Quick-Help-in-Ediff.patch --]
[-- Type: text/x-diff, Size: 1045 bytes --]

From fb2ff90ea8011eb7ebe1961869a74374a266c1d6 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Tue, 14 Jun 2022 15:09:31 +0200
Subject: [PATCH] WIP: Tune when to show "Quick Help" in Ediff

---
 lisp/vc/ediff-wind.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/vc/ediff-wind.el b/lisp/vc/ediff-wind.el
index 4549b910b1..6db3667545 100644
--- a/lisp/vc/ediff-wind.el
+++ b/lisp/vc/ediff-wind.el
@@ -1136,9 +1136,7 @@ ediff-refresh-mode-lines
 	  (if (ediff-narrow-control-frame-p)
 	      (list "   " mode-line-buffer-identification)
 	    (list "-- " mode-line-buffer-identification
-                  (and (not (eq ediff-window-setup-function
-                                'ediff-setup-windows-plain))
-                       "        Quick Help"))))
+                  (list 'ediff-use-long-help-message "        Quick Help"))))
     ;; control buffer id
     (setq mode-line-buffer-identification
 	  (if (ediff-narrow-control-frame-p)
--
2.30.2


[-- Attachment #3: Type: text/plain, Size: 11 bytes --]



Michael.