From: Robert Pluim <rpluim@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org, Ihor Radchenko <yantar92@gmail.com>
Subject: Re: master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance
Date: Thu, 16 Jun 2022 15:33:06 +0200 [thread overview]
Message-ID: <87ilp0ybql.fsf@gmail.com> (raw)
In-Reply-To: <87zgicdbfd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 16 Jun 2022 14:45:26 +0200")
>>>>> On Thu, 16 Jun 2022 14:45:26 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:
Lars> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> AFAICT this just replaces `mapconcat` with a `with-temp-buffer + dolist
>> + insert`, so if this makes a significant performance difference, it
>> points to a performance problem in our `mapconcat`, right?
Lars> It looks like it shouldn't be that difficult to improve the performance
Lars> radically in the common case of FUNCTION being #'identity. If there's
Lars> no SEPARATOR we can just pass the arguments more or less directly on to
Lars> Fconcat, and if there is a SEPARATOR, we just have to adjust the arg
Lars> list.
I did some profiling of concat and similar about a year ago. One of
the things that got me some improvement was adjusting the type checks
so that the most common case came first. Of course thatʼs highly
dependent on which benchmarks you choose :-)
Robert
--
next prev parent reply other threads:[~2022-06-16 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <165536698076.5328.17316430648307086249@vcs2.savannah.gnu.org>
[not found] ` <20220616080945.7DD14C01685@vcs2.savannah.gnu.org>
2022-06-16 12:19 ` master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance Stefan Monnier
2022-06-16 12:45 ` Lars Ingebrigtsen
2022-06-16 13:33 ` Robert Pluim [this message]
2022-06-16 12:49 ` Ihor Radchenko
2022-06-16 17:43 ` Stefan Monnier
2022-06-17 11:35 ` Ihor Radchenko
2022-06-16 12:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilp0ybql.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.