bug#56628: 28.1; dired + tramp/archive gives ibuffer fits

[Michael Albinus <michael.albinus@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

Hi,

> Peter Mao <peter.mao@gmail.com> writes:
>
>> Ibuffer throws an error when an archive file (I've tried zip and tar.gz)
>> is inserted into a Dired buffer (with `dired-maybe-insert-subdir').
>> Recipe for bug and relevant *Messages* below.
>>
>> Actions starting from `emacs -Q`:
>> 1. open directory in Dired with an archive file (C-x d)
>> 2. insert zip contents into Dired buffer with 'i'
>> 3. open Ibuffer (M-x ibuffer)
>
> This leads to the following error:
>
> Debugger entered--Lisp error: (user-error "Method ‘archive’ is not known.")
>   signal(user-error ("Method ‘archive’ is not known."))
>   tramp-error((tramp-file-name "archive" nil nil "file%3A%2F%2F%2Fhome%2Flarsi%2FDownloads%2F4672362..." nil "" nil) user-error "Method `%s' is not known." "archive")
>   apply(tramp-error (tramp-file-name "archive" nil nil "file%3A%2F%2F%2Fhome%2Flarsi%2FDownloads%2F4672362..." nil "" nil) user-error "Method `%s' is not known." "archive")
>   tramp-user-error((tramp-file-name "archive" nil nil "file%3A%2F%2F%2Fhome%2Flarsi%2FDownloads%2F4672362..." nil "" nil) "Method `%s' is not known." "archive")
>   tramp-dissect-file-name("/archive:file%3A%2F%2F%2Fhome%2Flarsi%2FDownloads%...")
>   tramp-file-name-handler(expand-file-name "" "/archive:file%3A%2F%2F%2Fhome%2Flarsi%2FDownloads%...")
>   file-name-case-insensitive-p("")
>   abbreviate-file-name("")
>   ibuffer--abbreviate-file-name("")
>
> The problem seems to stem from tramp throwing an error when calling
> `abbreviate-file-name' in the *tramp/archive...* buffer.  Perhaps
> Michael knows why; added to the CCs.

The default directory of the *tramp/archive...* buffer cannot be
accessed outside the Tramp machinery. The fix is simple, patch appended.

Would it be OK to push this to the emacs-28 branch?

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 939 bytes --]

diff --git a/lisp/net/tramp-archive.el b/lisp/net/tramp-archive.el
index 4b649edaab..33348ca21e 100644
--- a/lisp/net/tramp-archive.el
+++ b/lisp/net/tramp-archive.el
@@ -339,6 +339,13 @@ tramp-archive-file-name-handler
 	        (tramp-archive-run-real-handler
                  #'file-directory-p (list archive)))
             (tramp-archive-run-real-handler operation args)
+	  ;; The default directory of the Tramp connection buffer
+	  ;; cannot be accessed.  (Bug#56628)
+	  ;; FIXME: It is superfluous to set it every single loop.
+	  ;; But there is no place to set it when creating the buffer.
+	  (with-current-buffer
+	      (tramp-get-buffer (tramp-archive-dissect-file-name filename))
+	    (setq default-directory (file-name-as-directory archive)))
           ;; Now run the handler.
           (let ((tramp-methods (cons `(,tramp-archive-method) tramp-methods))
 	        (tramp-gvfs-methods tramp-archive-all-gvfs-methods)