From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#56679: 28.1; [PATCH] whitespace-style cannot be configured for diff-mode via hook Date: Mon, 25 Jul 2022 04:38:18 +0200 Message-ID: <87ilnlapd1.fsf@web.de> References: <835yjmho8k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1953"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: YE , 56679@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 25 04:39:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFo0B-0000OG-Tv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jul 2022 04:39:23 +0200 Original-Received: from localhost ([::1]:34222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFo0A-0002pX-FW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jul 2022 22:39:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFnzs-0002pK-TY for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 22:39:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59230) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFnzp-0003pR-UH for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 22:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFnzp-0001oY-O8 for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2022 22:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jul 2022 02:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56679 X-GNU-PR-Package: emacs Original-Received: via spool by 56679-submit@debbugs.gnu.org id=B56679.16587167136937 (code B ref 56679); Mon, 25 Jul 2022 02:39:01 +0000 Original-Received: (at 56679) by debbugs.gnu.org; 25 Jul 2022 02:38:33 +0000 Original-Received: from localhost ([127.0.0.1]:48979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFnzN-0001np-4V for submit@debbugs.gnu.org; Sun, 24 Jul 2022 22:38:33 -0400 Original-Received: from mout.web.de ([212.227.15.4]:48429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFnzK-0001na-4K for 56679@debbugs.gnu.org; Sun, 24 Jul 2022 22:38:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1658716701; bh=qKtBmYn6PBOaTsRHAjg10VTjPtMvF59I6mlq6SpisjY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=OwU/nGATBaaNC/A8ZNtVwiRgS8WeKjiHp9iJJ75fstvGjJdbMCtj5PPAL70dqamoo GdnPvCv2zYQFMl4WjSww4Cn0aDuUyllRS2tm3mLQBa0Qc1Vu1dZ/GkzoBr0BRk6dB9 1uEJdYHxPnmcESUvYzb2aFQejZewoocjO1fTAJus= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MJnrh-1nwMOC2oAb-00KEVK; Mon, 25 Jul 2022 04:38:21 +0200 In-Reply-To: <835yjmho8k.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 24 Jul 2022 12:08:27 +0300") X-Provags-ID: V03:K1:gvumRiRoL9eU5AZuY1iylCWjFzaT4AW9mvHO7rlfMfXIq4499m2 n9riO4ncprvQ2Tbh5rgl57wjXZJTPjXXvyoIx6FPvmp2yE8/50NOc6K4zhpWdl7nN9EIhAm LYh3ZurBVeQG/s7umB+N0JvsyGL3J+2tzGD4vQkXWF59MOoggkg5cLNb5WXnEjYEAl60GTS a6CA70S/hFkqaSb426Rog== X-UI-Out-Filterresults: notjunk:1;V03:K0:am0KCbaNDa8=:q5YyN2XqLCIsKP11u7nWgR G8bsIdn3NI+veAurCEKj+dTOtGcPwIrNd45neEMznn0+s1XZ+u9hx8pb3s+qsaqNVefG0mXSX 4AamAozY4a4WV3zMS29FJHICsl6cjHxE6qzLK9lCEaYp0T3JVkPsraCTSD9o8u3Y2R5xb2Hig UGbTtczD6lP+vf5Fjo/oyjbu9izTwiEZUeQ9RJRYnj0b4lvk419OnoLboOOLwgjH+RhRPsxee EQCbzpIDz0+1b/Ul2fqC/kBAeeKsSTEEHBZhnNIJ21YUSSxuPrXBeVn6P7PeQPLDBNBTtr4d0 i0dzXmmapaADdEgHHjaK2KDorhaJG2vWC2M0R+lu5eOmfajzfigqtwBz5XpRdMriFMAv0c5qH 3O5A2P1dZ91D3vuqLHyRpoUr4DkhBC6ejK/mwiPmGpojROWE7IC/jrLB929NAWG0b4W+uVztA UrqbAxBrCMabk4MaaAEjqA3S4kWvJZbyZa7SnXO3NHWGGBoFp+cVafIO23i5pX8SFWUTM8pfZ pux+51xrFLCMuHoCBIRe8msLbkhp5YNG+RC4cU9xigEVDdfZrULF/zAUin6i8IcNXJErdqESf /P7/lWMhhpD2k14DCruJPtIiv+Ykqnesez+c+qI3EzC10/OiBKpA7ep3epD5Wl5nUz+JvPCuU zEltWXwsJmtog4Wvar2HSWyPa/R4/Dp1OuZ/pr95jWFP2RXnMr00vs5QwcFqdTp0OCUkaqSQA wrr+x1sOWMVoQj7YfmVBgh5M3E6KgjwkYEnsT5Hp3nDx4iYlgjeJEHeIWNomSx7UkWaDY1Sp X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237873 Archived-At: Eli Zaretskii writes: > Can we delay loading whitespace.el until the user actually wants to > turn on whitespace-mode, or until he/she customizes this option? > AFAIU, whitespace-mode is not turned on unconditionally by diff-mode, > so this 'require' is not needed for users who don't turn that minor > mode in Diff buffers. Principally correct - but how do we do this correctly for the (get 'whitespace-style 'custom-type) :type definition? > > +(defcustom diff-whitespace-style '(face trailing) > > + "Specify `whitespace-style' variable for the current Diff mode buffer." > > AFAIU, this style will be applied to all Diff mode buffers, not just > the "current" one. Right? Yes, that, and also the language of the News entry, is a bit misleading. > > +** Diff mode > > + > > +--- > > +*** New user option 'diff-whitespace-style'. > > +This option determines buffer-local 'whitespace-style' value. > > Should we tell that if someone was using whitespace-style directly for > this purpose, they should use this new option instead? AFAIU this never worked, this is what this patch is about (unless those someones knew some trick maybe). Michael.