From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild Date: Mon, 22 Aug 2022 16:35:30 +0200 Message-ID: <87ilmk4a8d.fsf@gnus.org> References: <87y28ot2u8.fsf@gnus.org> <24A8FD47-339C-4E1D-9F32-BFE97C60C0B6@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9339"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Adam Porter , 50214@debbugs.gnu.org To: Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 22 17:56:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ9nI-0002HJ-Qg for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 17:56:52 +0200 Original-Received: from localhost ([::1]:33102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQ9nH-0005LA-MG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 11:56:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ9Gw-0007I6-0b for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 11:23:26 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQ9Gv-00074X-MO for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 11:23:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQ8X4-0000N3-1K for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 10:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Aug 2022 14:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50214 X-GNU-PR-Package: emacs Original-Received: via spool by 50214-submit@debbugs.gnu.org id=B50214.16611789441386 (code B ref 50214); Mon, 22 Aug 2022 14:36:02 +0000 Original-Received: (at 50214) by debbugs.gnu.org; 22 Aug 2022 14:35:44 +0000 Original-Received: from localhost ([127.0.0.1]:41427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8Wm-0000MI-Hq for submit@debbugs.gnu.org; Mon, 22 Aug 2022 10:35:44 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8Wk-0000M3-RV for 50214@debbugs.gnu.org; Mon, 22 Aug 2022 10:35:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=U8bm9hV612jhufmHG28G+yiuqZHhI5MqEai1Jxrwd4Y=; b=dHROoWaAxIYY2nfqibPQ9Evhj2 8piuJg8bLymzO0wU5QHK2z5MSLGrI2go83IYDj+knhr/rvezQ0Z/0d17h2lpHDIiB5VJrvn75S1IP JEaZAqORL+wqSgMlpcMS5f+iRjV44TUYOW9KWuKASEIjxclowpy9Bg/4GgXQfkBCMPSM=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ8Wb-0006Mk-3P; Mon, 22 Aug 2022 16:35:35 +0200 In-Reply-To: <24A8FD47-339C-4E1D-9F32-BFE97C60C0B6@gmail.com> (Philipp's message of "Sat, 4 Sep 2021 19:37:18 +0200") X-Now-Playing: Jorja Smith's _Blue Note Re:imagined (1)_: "Rose Rouge" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240436 Archived-At: Philipp writes: >> Unfortunately, I know of no other way to implement what ts.el does >> without modifying the accessors, which requires accessing the internal >> struct details after it is defined. > > I haven't checked the code in detail, but AIUI ts.el tries to initialize structure members lazily? Why not just use a wrapper function for that? > > (defun ts-hour (ts) > (or (ts--hour ts) > (setf (ts--hour ts) (string-to-number (format-time-string "%H" (ts-unix ts))))) > > Here ts--hour is the actual accessor, which is private and shouldn't be used outside of ts.el. Adam, does this suggestion work for you?