From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57367: [PATCH] Speed up em-smart Date: Tue, 06 Sep 2022 12:00:26 +0200 Message-ID: <87ilm0x1ol.fsf@gnus.org> References: <87r10q6byc.fsf@gnus.org> <9257e0e5-232e-7e20-f4d1-385066c4337e@gmail.com> <87bkrtxzfj.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7238"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57367@debbugs.gnu.org To: Morgan Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 06 12:12:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVVZe-0001jP-Tz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 12:12:54 +0200 Original-Received: from localhost ([::1]:46852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVVZd-00061g-Pl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 06:12:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVVOA-0000BQ-Tr for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 06:01:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVVOA-0002AB-Hy for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 06:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVVOA-0008Ek-2t for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 06:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2022 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57367 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 57367-submit@debbugs.gnu.org id=B57367.166245844431629 (code B ref 57367); Tue, 06 Sep 2022 10:01:02 +0000 Original-Received: (at 57367) by debbugs.gnu.org; 6 Sep 2022 10:00:44 +0000 Original-Received: from localhost ([127.0.0.1]:49615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVVNp-0008E1-3h for submit@debbugs.gnu.org; Tue, 06 Sep 2022 06:00:44 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVVNm-0008Dk-G6 for 57367@debbugs.gnu.org; Tue, 06 Sep 2022 06:00:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZzjdDeYnXl1e0Vo7aFAe3kiYcdPKNvrR609FijX+EB4=; b=UADhJpdOTD/myicEmTAVI0ekYt 6qpGc6yEVyCw9s3dRqszptiDj2AruHUC8Ee0SMj2fZ0JSoc7VlhuFlhAwuZDlFV0lYdHSwzXRa/AU 1KmOo1FQ6WVjbOUiMBKTXhIpmXlnOwj8eri+ofkluF59BKy4yWXpuOZ7b7gzWcIhN59s=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVVNc-0003Hr-Dw; Tue, 06 Sep 2022 12:00:31 +0200 In-Reply-To: (Morgan Smith's message of "Mon, 05 Sep 2022 22:28:37 -0400") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUYFRlAUFpleITG xMZzk6f///+VT/LaAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YJBgk4HV/6hD8AAAGaSURBVDjLbZQB tqsgDEQH6wIS6gKE5wK+1gUUZf9reiEggv9xeo42tzMZohQAGBg+7QLsgLSM+Wnrq4ARmbT1nQD3 +gvgBsPDCeGdwasFXyl8pwzefSaYr9f62Na3ZD0roPfTaZwPVXS7owQowDzCbupN6WK6TCksJg7p 0s0j7VvA+l+L3aWf2n/PbW/LLKVlXHFuXVjnk9U2buCzz0QKXh95Snw33+c87DUBto6tyjbviZjZ x/W1w7ON8bhYWWFYscS8hLFRI3kFTOAKMvV+8ez9KSA5xVjwKZ+U4cMM72yq+tgttkhFtr4j4sTQ O0FdL2ZCuQ251/VFkpU4EsjUbGRlLtUi1DuXBLiaHlNjRA3gasQqKFa7axKpAM8GIQODR4ODSZ1M 7lEbSCKjTqzA/dwCZIGCdfrUzlQEApbjHka4BDbg0AZ7fhpVsDCOebpAFYAjIdxG0jkLzCTHw+gD zVEJedMcXTPdZFQENszXSEpUymd18mVWZxZcdQohg7MIUP4mBvut091lSKUOYj39+q6d+1EFkiA5 /QImW6/IAe1kJQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0wNlQwOTo1NjoyOSswMDowMIN/ zwgAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMDZUMDk6NTY6MjkrMDA6MDDyIne0AAAAAElF TkSuQmCC X-Now-Playing: Peter Gabriel's _Peter Gabriel 1_: "Here Comes the Flood" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241628 Archived-At: (Please keep the debbugs address in the CCs -- otherwise it won't reach the bug tracker.) Morgan Smith writes: > So the hook is local to the buffer but it runs this bit of code: > > (set-window-start (selected-window) (line-beginning-position) t) > > So I want to set all windows that refer to the hook buffer to start at a > certain location. Ideally I want to do this even if the window doesn't > currently exist as I want it to be properly scrolled when I get back to > it. Hm, right. > I guess that explains why the original author simply walked through > all windows and also attached the hook to > `window-configuration-change-hook'. I guess I could restore the > original solution but it doesn't seem particularly elegant. > > Let me know if you have a better idea, otherwise I'll simply send > another patch that puts some of the old stuff back in. I think you probably have to wait until the window actually exists to effect scrolling in it (you may have the same buffer in several windows, or in none), really, so I think walking the windows is the only practical solution here. But there may be other tricks here -- perhaps somebody else has some ideas.