From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line Date: Sat, 17 Sep 2022 10:23:01 +0200 Message-ID: <87illme7fe.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19279"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Protesilaos Stavrou To: 57876@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 17 10:24:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZT7Z-0004qr-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 10:24:17 +0200 Original-Received: from localhost ([::1]:39236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZT7Y-0006Eg-1P for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Sep 2022 04:24:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZT7K-0006DH-TR for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 04:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46075) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZT7K-0004Es-Ba for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 04:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZT7J-00010s-Oh; Sat, 17 Sep 2022 04:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: public@protesilaos.com, bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 08:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57876 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Protesilaos Stavrou Original-Received: via spool by submit@debbugs.gnu.org id=B.16634029893827 (code B ref -1); Sat, 17 Sep 2022 08:24:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Sep 2022 08:23:09 +0000 Original-Received: from localhost ([127.0.0.1]:45151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZT6T-0000zf-8I for submit@debbugs.gnu.org; Sat, 17 Sep 2022 04:23:09 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:56038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZT6Q-0000zW-Tn for submit@debbugs.gnu.org; Sat, 17 Sep 2022 04:23:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZT6Q-0005XR-PP for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 04:23:06 -0400 Original-Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:42538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZT6P-0004Am-7p for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 04:23:06 -0400 Original-Received: by mail-ej1-x62e.google.com with SMTP id sb3so24487911ejb.9 for ; Sat, 17 Sep 2022 01:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date; bh=MmV477K8YceYzex9482ao9p8KW/qXxWwuUTAkoaS3ZM=; b=qNh2IZuoRcVHSyeCr+I17pUXYj7wtOaJ866F+2h1wHMwSK0e7AYuZSM6Y+Kwn6ZfwJ NG81u2nQhGo8uJKzQ9eIPPW1OY4VPUMONMpMn3iw2CPPhpScF6gNuGdeAnw6Y8fGR66C LVqw8es5v9mto5KhAVYjtngGpkwCOH4TOUwd1aiY98mxSzZD/O2bihBtWs++RN8jL8TS eK5MlGuSIA8fXW0r/K0W0K44g8dNc+dR/hQrOmbYc0Z/FgIAC+vThZWEoIjDa3LskOtg 6emfi9R+JoQkjxAtAPCsPxLi8W0wERBXSo+lYFN8T/Guh8k9n271wVMfEP0uDc1v8NAp dlfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=MmV477K8YceYzex9482ao9p8KW/qXxWwuUTAkoaS3ZM=; b=d8ZO0yVRh69umKIqFd5klScmGtSXk4Mwahiprf9NAuRksDN8sUO4Q76hdnIrRNKtHY 927owMA1oaEYE1d1Tm2VyPlTWdvHts1H4lRTLX8CbQ00HT7ikUWRMS6Db/vkAVKvfzZp d6Uizb7RMaywc3e0z4R6pUObiyLDatIqMSlVlgTjFNWuKYAU7Ga/+TMMg7OocvdYw/pz kEC1i79sqn+RERSWX7GggDTUJsQDHq7NQlHx/Q5KjB9I2bRz8QvMIDwxLL35mOeeO9eu HnOz74Ow50aA7AaPlDJKWv5qt7MliYg6ZxVx1V6BjnJ7moyOfI1HKrD8w1gPEcBiH3d5 3vIA== X-Gm-Message-State: ACrzQf1M/y1HT2AtzGbeqXuLkDW5WnAwJ9+QkpETLMm69pDzxh1mK+Mw t9HRk7gnvCkDCkTGcNaRzNbEHNSMTA0= X-Google-Smtp-Source: AMsMyM6K+oNmPRZLADGxJgy3yFXpnDLvo5DBvwMzlcG9ECrEEtGH/x6PNJQe9sKgGhuTvNcyrvOmqA== X-Received: by 2002:a17:907:7d9e:b0:771:db66:7b7c with SMTP id oz30-20020a1709077d9e00b00771db667b7cmr6005108ejc.393.1663402983271; Sat, 17 Sep 2022 01:23:03 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id t11-20020a056402020b00b00452e7ae2214sm5871519edv.42.2022.09.17.01.23.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 01:23:02 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242850 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tags: patch Currently, if point is say at the prompt of a comint buffer, pulse-momentary-highlight-one-line doesn't show do anything =E2=80=93 or, m= ore precisely, it pulses the zero-length region from prompt end to EOB. Prot: I think you want to apply a similar change in pulsar.el. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-pulse-momentary-highlight-one-line-Act-on-visual-lin.patch >From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sat, 17 Sep 2022 10:17:34 +0200 Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line * lisp/cedet/pulse.el (pulse-momentary-highlight-one-line): Act on entire visual line, ignoring fields etc. --- lisp/cedet/pulse.el | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el index 9941f2a0cb..0564cf6d04 100644 --- a/lisp/cedet/pulse.el +++ b/lisp/cedet/pulse.el @@ -202,12 +202,8 @@ pulse-momentary-highlight-one-line Optional argument FACE specifies the face to do the highlighting." (save-excursion (goto-char (or point (point))) - (let ((start (line-beginning-position)) - (end (save-excursion - (end-of-line) - (when (not (eobp)) - (forward-char 1)) - (point)))) + (let ((start (progn (vertical-motion 0) (point))) + (end (progn (vertical-motion 1) (point)))) (pulse-momentary-highlight-region start end face)))) ;;;###autoload -- 2.37.3 --=-=-=--