all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Augusto Stoffel <arstoffel@gmail.com>
To: 57876@debbugs.gnu.org
Cc: Protesilaos Stavrou <public@protesilaos.com>
Subject: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line
Date: Sat, 17 Sep 2022 10:23:01 +0200	[thread overview]
Message-ID: <87illme7fe.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

Tags: patch

Currently, if point is say at the prompt of a comint buffer,
pulse-momentary-highlight-one-line doesn't show do anything – or, more
precisely, it pulses the zero-length region from prompt end to EOB.

Prot: I think you want to apply a similar change in pulsar.el.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-pulse-momentary-highlight-one-line-Act-on-visual-lin.patch --]
[-- Type: text/patch, Size: 1157 bytes --]

From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <arstoffel@gmail.com>
Date: Sat, 17 Sep 2022 10:17:34 +0200
Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line

* lisp/cedet/pulse.el (pulse-momentary-highlight-one-line):  Act on
entire visual line, ignoring fields etc.
---
 lisp/cedet/pulse.el | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
index 9941f2a0cb..0564cf6d04 100644
--- a/lisp/cedet/pulse.el
+++ b/lisp/cedet/pulse.el
@@ -202,12 +202,8 @@ pulse-momentary-highlight-one-line
 Optional argument FACE specifies the face to do the highlighting."
   (save-excursion
     (goto-char (or point (point)))
-    (let ((start (line-beginning-position))
-          (end (save-excursion
-                 (end-of-line)
-                 (when (not (eobp))
-                   (forward-char 1))
-                 (point))))
+    (let ((start (progn (vertical-motion 0) (point)))
+          (end (progn (vertical-motion 1) (point))))
       (pulse-momentary-highlight-region start end face))))
 
 ;;;###autoload
-- 
2.37.3


             reply	other threads:[~2022-09-17  8:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17  8:23 Augusto Stoffel [this message]
2022-09-17  9:38 ` bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line Eli Zaretskii
2022-09-17 10:56   ` Augusto Stoffel
2022-09-17 11:20     ` Eli Zaretskii
2022-09-17 11:31       ` Augusto Stoffel
2022-09-17 11:49         ` Eli Zaretskii
2022-09-18  7:23 ` Protesilaos Stavrou
2022-09-18 11:02 ` Lars Ingebrigtsen
2022-09-18 12:40   ` Eli Zaretskii
2022-09-18 12:45     ` Lars Ingebrigtsen
2022-09-18 12:55       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87illme7fe.fsf@gmail.com \
    --to=arstoffel@gmail.com \
    --cc=57876@debbugs.gnu.org \
    --cc=public@protesilaos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.