From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: src/Makefile unhelpful Date: Sun, 18 Sep 2022 12:37:57 +0200 Message-ID: <87illl55oa.fsf@gnus.org> References: <83bkrrj48w.fsf@gnu.org> <81B26ACA-E8C3-4FAC-9BB5-A6B40C3B4A55@gentoo.org> <83fsgya2yx.fsf@gnu.org> <875yhui674.fsf@gnus.org> <8735cy5dg9.fsf@yahoo.com> <83bkrj45lr.fsf@gnu.org> <87zgf12036.fsf@gnus.org> <2b58b8f5425fc083d4ad@heytings.org> <877d251540.fsf@gnus.org> <0b5f34d9bc43b17dd0df@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12855"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 18 12:39:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZrha-0003Do-Ke for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Sep 2022 12:39:06 +0200 Original-Received: from localhost ([::1]:58702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZrhZ-0000cq-JN for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Sep 2022 06:39:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZrgb-0008M0-7R for emacs-devel@gnu.org; Sun, 18 Sep 2022 06:38:05 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:55412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZrgZ-0005Sq-QN; Sun, 18 Sep 2022 06:38:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+r5dqjD6Mg1NufxW7lKzPVuvQrmk8aYMdjjthOnsLQQ=; b=X5cF24NtMEE+zlKHGlERdnNHxY KbXEGXbPifqCyoYgEkSxpAwrWWrOfliiYVEXG0YrqA4rNdVcsz46qAVYLtnyKY7PJ/c7kzQ3ILtAL RdHHFz1j7/OF1g8YtH/GUjtq6LlHU8kdZnTY+tk7jD2Fa+jK+ewx06pk0WDRZOItfnlU=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZrgU-0006lL-6X; Sun, 18 Sep 2022 12:38:00 +0200 In-Reply-To: <0b5f34d9bc43b17dd0df@heytings.org> (Gregory Heytings's message of "Sat, 17 Sep 2022 10:46:24 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUpJykfHB1+gIG0 ydGuubtOTVL///+yPxuZAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+YJEgoJFD1GRbgAAAGpSURBVDjL bZNhkoMgDIVJd/kPzngBZC8gnAA4AGvN/a+yIQTFzjotVr6+9wJEpf67YIvK8q/6nL/Bh8C+ozJP AiwAAtbM84ZdLVvZKcIqbKMAq4YIdOV5C5mBHTEaVX9eQwemW8HBd3peBgAzAZiAWCGK9Cvs3ZNC KWfFUd0mCtJoZeAgBcVDvQF5aTA/BEiL7gYcUJXmm3M1xwm0RXAByWMIfUvMtPX6VZLPYdpELd+z 7KUBGKD2YXU+MaATgOalRaaTc11hJyu6XgRymIFcL+dcaIBLMmPbK5zkxOASYK0EFIGNwVVt21oa HGc3q94ZCmlS6Z/DcXa3MsD2DR8NSEY7QF4aCRQ+gORgO44jXVZXk+BBmjM5H2n+AZBBaU6lZ1xr qXg6zxGiGCuvuDkfwhU+Wp5A8SXnu1y4GotOr82H1K2gH5fG185ORcAoTNeDQMxU2N273FuoYzPi E+T/g7FiJiDuo0WlWZYOSpQMIwf8+9651lsxXoWcAlc7XrUB1uyoVPrkW2Fbf63ZM7iqsrJjS/Qc 8QSEFlpfblYfAL5T39tPYLcb/AENp3EfHoqI2QAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0x OFQxMDowOToyMCswMDowMCsFq2IAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMThUMTA6MDk6 MjArMDA6MDBaWBPeAAAAAElFTkSuQmCC X-Now-Playing: Stephan Mathieu's _Radiance (12): Pacific_: "Pacific" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295571 Archived-At: Gregory Heytings writes: > Complete patch attached, comments welcome. Looks good to me (adjusting for comments from others), so feel free to push when you're satisfied with the patch. But one bikeshedding opportunity: > +# ADVICE-ON-FAILURE-BEGIN > +# You might consider to: > +# - run "make bootstrap", which might fix the problem > +# - run "git clean -fdx" and run "make" again, which might fix > +# the problem if it was not fixed by "make bootstrap" > +# !BEWARE! "git clean -fdx" restores the local repository in its > +# !BEWARE! pristine state, it deletes all local changes and all > +# !BEWARE! untracked files I wonder whether this could be a two part thing? That is, have just "make" say the bit about "make bootstrap" and "V=1", and say the bit about "git clean" if "make bootstrap" fails? (Because we don't really want to recommend to people that they say "git clean" unless they really have to.) But if that's too much work, then it's fine as it is.