From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 101f3cf5b9: Add support for user edits to VC command arguments Date: Thu, 22 Sep 2022 09:06:48 -0700 Message-ID: <87illfo0kn.fsf@melete.silentflame.com> References: <166378878197.3568.7077863090259744101@vcs2.savannah.gnu.org> <20220921193303.1B687C11D81@vcs2.savannah.gnu.org> <87v8pfbw1g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23305"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 22 19:49:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obQKC-0005jy-Uh for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Sep 2022 19:49:27 +0200 Original-Received: from localhost ([::1]:44618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obQKB-0006HV-8A for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Sep 2022 13:49:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obOj3-0006T3-44 for emacs-devel@gnu.org; Thu, 22 Sep 2022 12:07:06 -0400 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:44023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obOj0-0007Tq-BP for emacs-devel@gnu.org; Thu, 22 Sep 2022 12:06:56 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E7FC9320089C; Thu, 22 Sep 2022 12:06:50 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 22 Sep 2022 12:06:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1663862810; x= 1663949210; bh=tfGHkl9L9FKYk81YuA0NXjezJoVq/xqV+Pk1SxVk/34=; b=S KsOfgLUsjvUkJLUcgYb+mKJck+PN9sMdF3kOuvb+lwvkMsfsSDNvmEZJ6Cy1za0f kW9tWHGvUsAkb940+oYpydI1CsCQJagg0k1/HhU9hEdLkR6khz6tZAhL6ydyLjXX 2lgRSNeNqI+w9GFozvuTZU45PX0TilD2jMCcelU9EufUgJcIAex2PbmW5byFazW+ Xp2UQWfdV7vN3XLkzd/47+ua6F0FlHZbv7pA4i5BT0dcjah3f7EOiEL94E/v0UsM JwZyuKUuKkBsDjhLJE/JAHElrp++qm6ZPScTCLt7P4xq3ZXS/Fd6EJAN+96+YoM4 lMhU9G7hG4Km0BRCnTZww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663862810; x= 1663949210; bh=tfGHkl9L9FKYk81YuA0NXjezJoVq/xqV+Pk1SxVk/34=; b=o hRPqRCdnVvaZ1tLQA8CCHEbQMlBsbhNFHizrdlMajhhZ3+oTZJsWcwrNLxt+kGq8 NKyjuSfR53wbXyw4gMNy77Hj4nSpZi8xNJtstUm2a0fjNJ8QFAX44m0S3ijSZNyY /CyVJPK6A9qetqTOx+ezRze0pXWGdAYLAoH9B5ARPCpAeZQmue/CvSkIQsaqAWrx 2mVd1AcdweXmihmvYkuqYoIheDfpXK8pFR27EXt6yebYDifM6dSNFP3fHdSxn6HP IVpXifaBZqb/20p8xFwvkMnYgJ3NRrXFRAmRG8OVPIDYjlBABQuf2mYWPAts6KxA cAv/+U5hVLAXbfgwae1ww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhdttddtreejnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnhepffefhfejudeguddtudekjeekueevvedvieeghfegleet uefhkeegkefhleejvddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 12:06:49 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id B36657EF47C; Thu, 22 Sep 2022 09:06:48 -0700 (MST) In-Reply-To: <87v8pfbw1g.fsf@gmail.com> (Robert Pluim's message of "Thu, 22 Sep 2022 11:25:31 +0200") Received-SPF: pass client-ip=64.147.123.21; envelope-from=spwhitton@spwhitton.name; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295994 Archived-At: Hello, On Thu 22 Sep 2022 at 11:25AM +02, Robert Pluim wrote: >>>>>> On Wed, 21 Sep 2022 15:33:02 -0400 (EDT), Sean Whitton said: > > > Sean> +(defvar vc-want-edit-command-p nil > Sean> + "If non-nil, let user edit the VC shell command before runni= ng it.") > Sean> + > Sean> ;; Common command execution logic > > Is the intent that someone would setq this to t? If so it should be a > defcustom. If that=CA=BCs not the intent, but it=CA=BCs just being used t= o track > the prefix args to the various changed commands, then I think it > shouldn=CA=BCt appear in the docstring. It's the latter, it's not meant to be setq. What exactly do you think shouldn't appear in the docstring? --=20 Sean Whitton