From: Andreas Schwab <schwab@linux-m68k.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-28 e5a49f44ff: * src/emacs.c (load_pdump): Fix use of xpalloc.
Date: Tue, 04 Oct 2022 18:34:12 +0200 [thread overview]
Message-ID: <87ilkz4kfv.fsf@igel.home> (raw)
In-Reply-To: <CADwFkmkfvRex3awT5OMGU2gfw-2cCZhsVyVNLiZFEoGSozGOLw@mail.gmail.com> (Stefan Kangas's message of "Tue, 4 Oct 2022 15:25:59 +0200")
On Okt 04 2022, Stefan Kangas wrote:
> This change leads to the below on macOS 10.13, using Apple LLVM
> version 10.0.0 (clang-1000.10.44.4):
>
> emacs.c:899:7: warning: variable 'bufsize' is used uninitialized
> whenever 'if' condition is true [-Wsometimes-uninitialized]
> if (!(emacs_executable && *emacs_executable))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> emacs.c:964:7: note: uninitialized use occurs here
> if (bufsize < needed)
> ^~~~~~~
> emacs.c:899:3: note: remove the 'if' if its condition is always false
> if (!(emacs_executable && *emacs_executable))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> emacs.c:928:3: note: variable 'bufsize' is declared here
> ptrdiff_t bufsize = exenamelen + strlen (suffix) + 1;
> ^
> 1 warning generated.
This was broken even before, since dump_file wasn't heap-allocated
before this point if the jump to hardcoded happend.
Should be fixed now.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-10-04 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166470688469.7534.2087297540131700063@vcs2.savannah.gnu.org>
[not found] ` <20221002103444.EE880C1AB4B@vcs2.savannah.gnu.org>
2022-10-04 13:25 ` emacs-28 e5a49f44ff: * src/emacs.c (load_pdump): Fix use of xpalloc Stefan Kangas
2022-10-04 16:34 ` Andreas Schwab [this message]
2022-10-04 18:58 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilkz4kfv.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.