From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: "Significant Garbage Collection Improvement For Emacs" - sweep_conses performance improved by 50%? Date: Sun, 30 Oct 2022 08:53:12 +0800 Message-ID: <87ilk2jfnr.fsf@yahoo.com> References: <871qqr425n.fsf@yahoo.com> <42ba5e8a-8a26-4afd-ab59-efbb967e8a24@app.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9516"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: "Tyler Dodge" , "Stefan Kangas" , "Emacs developers" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 30 02:53:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oowaM-0002EL-9c for ged-emacs-devel@m.gmane-mx.org; Sun, 30 Oct 2022 02:53:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oowZu-0002Cx-6N; Sat, 29 Oct 2022 20:53:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oowZs-0002Ca-Ht for emacs-devel@gnu.org; Sat, 29 Oct 2022 20:53:28 -0400 Original-Received: from sonic310-25.consmr.mail.ne1.yahoo.com ([66.163.186.206]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oowZr-0005Ei-2m for emacs-devel@gnu.org; Sat, 29 Oct 2022 20:53:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667091204; bh=0umgRahkv7g/rH21BMn1CkeaIh5wZ9V4Koigp3Sh4ik=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=TGGLWvmSC1gAZCoLRR1CbSG4HoKZ+2WS7oAVyT+YjnG2TpQB9+fSvcJZNPQNZsW6hSlUHTzB1c/nCccaYuFQqs7JdscGZTJNFWanSYZgHOCF2oxsR27iAGMeBbGQ9y8uT5KdizN2zMYr5ltAOv11pWa2JWSB0DwslZN2GikJgCXVmZfeGeEMXuweBwctn8aOfPVUKpgSD2X4hkoVTBf5AZd7k2NKD9bRfdV7ia8+VGjBptwZHki77B1xxbcurmfxhKNua/sDiDkM10RXZ6Dbk3TnOEG0alTQsei8e+E4V7aUDhKRbWqG+MoMaX3Rov1EjSafYarlcRTAeeR28CrzjA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1667091204; bh=vlGVfYoJy4V/8nfdKVLyZpOVab6GrKBZSBGeMHHmJeG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=BpzNok3rz0yCk7gC17bjakbg4QxAYjftNi1o0ZqaAioa1H5LfRRB7t3/iWKx5j5JVVr3yGsnnUIxPFibLBXUhRtXJ284AxgjqLl0rh5yD7fq0Ve1hU5r5XDxJdUcqAjN0N6Qix5V5sIQV090OnOlMFOK6u1+zYnH0hq4pcmFEZJC0tNL3AqyVBagQpgBMciFkc9tRZJiDkg0kJXbsWcaN51xMn1x00vagB5mmc7GXnWF9NH/9rzW4FsjdtDW1rgDsOtAZHABHtREpLjtwbgaQtWEwVrSL4E3E5pidbYHDzgoxQqk6b1t1LrwSMMAsKTtWfYTMgnChEfX0I2pZwbhgQ== X-YMail-OSG: yljXaj4VM1kZW1QaFCS6lPE9F.4.9ggdWcLaTFLGoBg8ueAaiD_i5suQZA_egwT zsPs..I2_heM9EZwutnsX2HF9DNOw3gGRTcnee3nVmxeSTgVIg2k7Fn8RctgUx1u5eVNvuPDIiGL X0spe9zpMwaEhQ0niyKzYhJTHPmEvw7UxwhUb6Hp6FlmwiHB11GDYmVR4qVm6DfOkh0keTSkGMeH yNP.oNaNNGfHhK.yzYUC2LzZ97sOZDrBtIwdXbe_0qnJ2Y7QyRUoGIxASx_euLlj4rfhXImuwmPK MKkIEnL1hACa9h9qazyT.RbPYy_.nYE_7BKcX4CXr8z8lrEoqhRzrEyQoRlY7GsB6m604ngtCXT7 XXC.Jp1fcAWkCwoAkwuJnvKJJhxtQ9zbNkbcMDSj6FZPbkUcz.UL9B7MIhAglDMRYPtYrfW26R1l 6NsWafleLio95C3LmD6ikcQ0jh2hg7jPx1HJeCiPPQ3qVD.PtsuNLSu8CrHpNpbzLRvfE6IBLmWD .IjRX9tQpaUnLlOzfz5oepd.X_gkQWq7SylkFjPw0KsGSupQzGG7TsYNGTPF.n3lpvAScxulPfw9 Iz429zhtzpk93o7ocvLZyDW._8U_9ddOxIDkm7MynfoE9tRNYvJI8VsI1DjtgOkpW2yDobJdrSGp hlJV2iR0Cvr1RoxnwlvE9z4RI4pyvNv6QXo1XVpTv8lHvKeDk6mwXVmSU9ZSxKXfxfvZLiZFwsfT ACOECn11uo8GI6FnjeNZ85oUFLCFvg2HiLbQmnCSSOS02FhHGYSImZUNRuKn.Xg2W5N6xayJijr0 WNSxEPT4ONs7bCBFwtzjZM4fAZzf7xJbbFxrVmByBn X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sun, 30 Oct 2022 00:53:24 +0000 Original-Received: by hermes--production-sg3-74fb94585-bq88c (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 45bcfc4424c085c49f9954b20a2ea22c; Sun, 30 Oct 2022 00:53:19 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Sat, 29 Oct 2022 10:32:39 -0400") X-Mailer: WebService/1.1.20783 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.206; envelope-from=luangruo@yahoo.com; helo=sonic310-25.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298786 Archived-At: Stefan Monnier writes: > Basically you're replacing 1kB blocks with 32kB blocks, which indeed > seems very reasonable. Back when I introduced those blocks (and their > associated bitmaps) I chose 1kB because I wanted something small enough > that it couldn't be worse than what we had before, not because it was > the best choice. It may be worth nothing that I chose a cons and float block size of 4 times the page size while working with the incremental GC, which ends up 16k on most systems. However, there are also two pairs of markbits in each block. I haven't seen anything bad happen from that choice yet. But there, BLOCK_ALIGN is gone in the first place, and it relies on valloc returning suitably aligned memory.