From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#58799: Make winner key sequences repeatable in repeat-mode Date: Sun, 30 Oct 2022 07:39:21 +0100 Message-ID: <87ilk1olwm.fsf@cassou.me> References: <87y1t2zl1s.fsf@cassou.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18479"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 58799@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 07:40:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1op1zT-0004d4-8c for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 07:40:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op1zK-00013r-Ov; Sun, 30 Oct 2022 02:40:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op1zG-00013P-FP for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1op1zG-0003qS-7K for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1op1zG-00082e-2a for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 02:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 06:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58799-submit@debbugs.gnu.org id=B58799.166711196530863 (code B ref 58799); Sun, 30 Oct 2022 06:40:02 +0000 Original-Received: (at 58799) by debbugs.gnu.org; 30 Oct 2022 06:39:25 +0000 Original-Received: from localhost ([127.0.0.1]:37181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1yf-00081j-6g for submit@debbugs.gnu.org; Sun, 30 Oct 2022 02:39:25 -0400 Original-Received: from mail.choca.pics ([80.67.172.235]:33158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1yd-00081b-I7 for 58799@debbugs.gnu.org; Sun, 30 Oct 2022 02:39:23 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id D6140181942B3; Sun, 30 Oct 2022 07:39:22 +0100 (CET) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id l7nel9atiK8m; Sun, 30 Oct 2022 07:39:22 +0100 (CET) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 4EAEA181942BF; Sun, 30 Oct 2022 07:39:22 +0100 (CET) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id en7Nj_m7Pyw8; Sun, 30 Oct 2022 07:39:22 +0100 (CET) Original-Received: from localhost (153.226.95.79.rev.sfr.net [79.95.226.153]) by mail.choca.pics (Postfix) with ESMTPSA id E2A30181942B3; Sun, 30 Oct 2022 07:39:21 +0100 (CET) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246589 Archived-At: --=-=-= Content-Type: text/plain Hi Stefan, Stefan Kangas writes: > Damien Cassou writes: >> * lisp/winner.el (winner-repeat-map): New variable. >> (winner-undo): Put 'repeat-map' property with 'winner-repeat-map'. >> (winner-redo): Put 'repeat-map' property with 'winner-repeat-map'. > > There is no need to repeat the same text twice, so you can delete the > first occurrence. Indeed, fixed. >> +(defvar-keymap winner-repeat-map >> + :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." >> + [left] #'winner-undo >> + [right] #'winner-redo) > > It should be "" and "" here, I think. Fixed. Thank you very much for your reviews. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-winner-key-sequences-repeatable-in-repeat-mode.patch >From f23ee8ce89bf6e60d97d738f61e4663fd1e2b3dc Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Wed, 26 Oct 2022 16:53:23 +0200 Subject: [PATCH] Make winner key sequences repeatable in repeat-mode * lisp/winner.el (winner-repeat-map): New variable. (winner-undo): (winner-redo): Put 'repeat-map' property with 'winner-repeat-map'. --- lisp/winner.el | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lisp/winner.el b/lisp/winner.el index 174b698e7b..d2040c7e5d 100644 --- a/lisp/winner.el +++ b/lisp/winner.el @@ -328,6 +328,14 @@ winner-mode-map map) "Keymap for Winner mode.") +(defvar-keymap winner-repeat-map + :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." + "" #'winner-undo + "" #'winner-redo) + +(put #'winner-undo 'repeat-map 'winner-repeat-map) +(put #'winner-redo 'repeat-map 'winner-repeat-map) + ;;;###autoload (define-minor-mode winner-mode -- 2.36.2 --=-=-=--