From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.bugs Subject: bug#29108: 25.3; ERC SASL support Date: Tue, 29 Nov 2022 00:19:22 -0500 Message-ID: <87iliyz6at.fsf__13729.9767973431$1669699236$gmane$org@gnu.org> References: <87h8ud92zl.fsf@gmail.com> <874jx4h6sk.fsf@neverwas.me> <875yhifujk.fsf_-_@neverwas.me> <87edw4swdk.fsf@neverwas.me> <878rljxfxs.fsf@neverwas.me> <87k04m4th8.fsf@neverwas.me> <87o7thlepf.fsf@neverwas.me> <87o7taoohd.fsf@neverwas.me> <87a64unifk.fsf@neverwas.me> <87y1sdk1fg.fsf@neverwas.me> <875yfflzps.fsf@neverwas.me> <878rk9576b.fsf@neverwas.me> <87leo8z79j.fsf@neverwas.me> <87tu2vroeh.fsf@neverwas.me> <87wn7pog1l.fsf@neverwas.me> <87y1s4mjj6.fsf@neverwas.me> <87r0xvks03.fsf@neverwas.me> <87r0xtnk24.fsf@gnu.org> <87wn7jgkne.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34180"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 29108@debbugs.gnu.org, emacs-erc@gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 29 06:20:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozt2Z-0008Eu-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Nov 2022 06:20:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozt2O-0006yW-IU; Tue, 29 Nov 2022 00:20:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozt2J-0006xz-Ue for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 00:20:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozt2I-0004EA-Rv for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 00:20:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozt2I-0003Uc-5J for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 00:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2022 05:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29108 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29108-submit@debbugs.gnu.org id=B29108.166969917413415 (code B ref 29108); Tue, 29 Nov 2022 05:20:02 +0000 Original-Received: (at 29108) by debbugs.gnu.org; 29 Nov 2022 05:19:34 +0000 Original-Received: from localhost ([127.0.0.1]:53135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozt1p-0003UJ-Tf for submit@debbugs.gnu.org; Tue, 29 Nov 2022 00:19:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozt1m-0003UD-Tw for 29108@debbugs.gnu.org; Tue, 29 Nov 2022 00:19:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozt1h-0004AN-2x; Tue, 29 Nov 2022 00:19:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Q2eqBH0lcrHGlVedYn59APmnxU5o/Dai4Ezjz++IziM=; b=li+VVeUzmQocbjCDx/Aa s7ULtEp37S9rNouWHAkj89q5mpp3qhxTifuCTVSJa76PHiS5dU6G5Ew27CFVgbF0RZkjHUJEMMWMC ZcuN0M32lXYjVGp1fmt0hHoDycGgyp4mu5V2QmOMjgljHbMc71/ZM6HOXpdajBQzQiq0EtJ35c80d m3TjBdiPU0Jxd0iZsFnk9Og8vY8SSJ3385ON34TvCzOZhPFrtJ/kz47yEeaZ/G8u1GJgHlpDKBBfo xXjQ3z6qlUeattg5M0UJVjvzx1a8TDbrf1ma9oEIyu6kIfB3OEQ6xymC5rYaeq4lZl88Vl0TTTOP2 ykLBfjLQo6qrnw==; Original-Received: from [142.189.234.118] (helo=langa) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozt1g-0007zE-Ak; Tue, 29 Nov 2022 00:19:24 -0500 In-Reply-To: <87wn7jgkne.fsf@neverwas.me> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249365 Archived-At: Hey! J.P. writes: [...] > > Thanks for bailing me out. (This was fast becoming the "Swingers > answering machine" of bug threads.) Ahaha no problem ;-) >> All but one of them were committed without any additional changes; and >> that one was 0006-Add-non-IRCv3-SASL-module-to-ERC.patch, where I just >> added the missing entries for doc/misc/erc.texi and etc/ERC-NEWS to >> the commit message. > > Oof. Thanks. I also forgot the bug number on > > 0007-Accept-functions-in-place-of-passwords-in-ERC.patch > > despite being kindly warned of that eventuality. Ah, no worries; I missed that as well. [...] > > Right. Too cryptic. I've adjusted things in the second patch but am > happy to redo/revise, as always. (The first patch contains a bug fix.) > [...] > > Good call. I've attempted something like that in a separate "examples" > section (2nd patch). I'm hesitant about the last, "multi-network" > example, though. It sort of implies we're committing to supporting > let-binding as a means of specifying per-network local-module options, > going forward, which maybe also puts us on the hook for (eventually) > providing a mechanism to make options bookkeeping easier for would-be > local-module authors. OTOH, neither of those is as yet a realistic > problem. > > Speaking of maintenance burdens, I think `erc-sasl-password' is too > overloaded and unwieldy, particularly WRT the "non-nil symbol" form. And > falling back on `:id' is redundant because `erc-auth-source-search' > already does that. So, as penance for my ugly API design, I've attached > a (third) patch that tries to corral some of the crazy by adding an > optional auth-source query function to house the more nuanced > functionality (for those actually wanting it) while sparing everyone > else the needless complexity. (That's the idea, anyway.) Thanks! Yeah, I don't really see supporting let-binds as too big of a potential future burden. Worst case scenario, if/when local modules are fully implemented and we and/or module authors find supporting let-binding impractical, or there are clear advantages in not having them, we could drop them in a major version bump (ERC 6.0 anyone?) along with any other potential breaking change we might want to make. Also your simplification sounds good. I pushed the v2 of all three patches from your other reply to emacs-29. Thanks again! >> Many thanks for all of your work on implementing and landing SASL >> support for ERC, a feature that many ERC users (myself included) >> have wished for and looked forward to seeing in ERC for years! >> >> -amin > > My pleasure! (Although I should've been quicker to admit that my older > POC efforts weren't suitable for prime time without serious reworking.) > Cheers! -a