From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#59888: [PATCH] Add 'grep-heading-mode' Date: Thu, 08 Dec 2022 10:06:58 +0100 Message-ID: <87ilime025.fsf@gmail.com> References: <87v8mndrla.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12719"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59888@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 10:08:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3Ct9-00034c-RC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 10:08:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3Ct0-0004Oy-Qi; Thu, 08 Dec 2022 04:08:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Cst-0004Og-07 for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3Css-0005Lv-N5 for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3Css-00065c-CY for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 09:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59888 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59888-submit@debbugs.gnu.org id=B59888.167049043123398 (code B ref 59888); Thu, 08 Dec 2022 09:08:02 +0000 Original-Received: (at 59888) by debbugs.gnu.org; 8 Dec 2022 09:07:11 +0000 Original-Received: from localhost ([127.0.0.1]:55431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Cs2-00065K-U0 for submit@debbugs.gnu.org; Thu, 08 Dec 2022 04:07:11 -0500 Original-Received: from mail-ej1-f46.google.com ([209.85.218.46]:33360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Cry-00064x-C3 for 59888@debbugs.gnu.org; Thu, 08 Dec 2022 04:07:09 -0500 Original-Received: by mail-ej1-f46.google.com with SMTP id n20so2431413ejh.0 for <59888@debbugs.gnu.org>; Thu, 08 Dec 2022 01:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EcQ7ynBm0/ol/v+JTbagyfLTLSZfegQp/SKfGcG78BY=; b=Jgm4sHNO3o+94I0P0tDqoWOCAaExet3911B9LaKvE2brh2NZ9l7JU6V03MzbBpchUi qVmzzy2/dtazMjCgrrhOglTNtsWckXNLAPhjd/s6H1xNzyNRbgJGS2p7kCyOduAcxXjn 7rB5CEjngwreLTMEOnbeHnkX/SaDBzrn/lY3ZSoPjijeGr95NuewdFYqWM84aBnFF3rn XfUMkaA95TCKQk91Hc5Ru5WgVIegpfJoHX0YgJ7m5A+QUMBwByBGHBvU+UVUDNFD1AZQ hDW07iEx9wzFwXriaWYqJIfwLziu2MkkKjfoA8ONb3CzWt8Fu5c0qNlxUVu6aJm1y9vN NyFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EcQ7ynBm0/ol/v+JTbagyfLTLSZfegQp/SKfGcG78BY=; b=dOqEQtyaCLQCYTgA7mpL0T8fzqfWM5hQ8XL4AC1Og9KlQ7Ef+Hujz/TRIn7trq5gqu oug9SYeGwz/RLgCBSsUbeGrJVRXDusvI9MKHwi/pwq1kStxEUeq+wYiYn83qGHl0g5Gq ru6OFwZnkMfETD2X3Fzp0Mj9ksEZ7iXolAk9wVd9NfYye9DsDxylqNW1AuHjdNtOKaeS gRlwsC/xYb0HO4cETYbOWXxXEExydlIi3PJHUNArtObfzldj3MgwVDhLpT4KEtkoM09m bqC7x1hUlpLhwhLpY5ifQFssYRtPx01TEhzj1YzprTybhpV7nzHRqDpv33nQ+YkuBpB/ Xvrw== X-Gm-Message-State: ANoB5plgp/8oiEwHbnM6/PKNeQRcO/vK9tuaAT7HhLIutj5oS7f300RA dU0w+4DquypXUIbg3ui2OU6OGKDQ8G5CuA== X-Google-Smtp-Source: AA0mqf6enP9puISx/xx3ykaknyO46zpcyiaUhmGKBUk8Dy2SuD0q2v43crwUJCEEoBfxCb9UM5DKGA== X-Received: by 2002:a17:906:a019:b0:7be:e774:5aad with SMTP id p25-20020a170906a01900b007bee7745aadmr29604430ejy.426.1670490420034; Thu, 08 Dec 2022 01:07:00 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::a4bf]) by smtp.gmail.com with ESMTPSA id p10-20020a170906838a00b007c0dacbe00bsm5830746ejx.115.2022.12.08.01.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 01:06:59 -0800 (PST) In-Reply-To: (Stefan Kangas's message of "Wed, 7 Dec 2022 16:19:30 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250254 Archived-At: On Wed, 7 Dec 2022 at 16:19, Stefan Kangas wrote: > Augusto Stoffel writes: > >> From 2247f006845000032fedc3dda9a073b14043a270 Mon Sep 17 00:00:00 2001 >> From: Augusto Stoffel >> Date: Wed, 7 Dec 2022 18:44:07 +0100 >> Subject: [PATCH] Add 'grep-heading-mode' >> >> New minor mode to subdivide grep output into sections, as in the >> '--heading' option of certain grep-like programs. >> >> * lisp/progmodes/grep.el (grep-heading-regexp): New user option. >> (grep-heading): New face. >> (grep--heading-format, grep--current-heading, grep--heading-filter): >> Filter function for grep processes and supporting variables. >> (grep-heading-mode): New minor mode. > > How about making this into a defcustom instead of a minor mode? > > I'm thinking that something like > > (setopt grep-use-headings t) > > is a slightly simpler interface to use than > > (add-hook 'grep-mode-hook 'grep-heading-mode) > > I also think the former plays a bit better with customize. This is at the same time less customizable in the sense that something like (add-hook 'grep-mode-hook (lambda () (when condition) (setq grep-use-headings t))) will not work (I think), while conditionally activating a minor mode certainly works. But I'm open to both approaches.