From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#60872: 29.0.60; emacsql broken after Jan 12 change Date: Tue, 17 Jan 2023 14:10:13 +0100 Message-ID: <87ilh5cnnu.fsf@gmail.com> References: <874jspwyrr.fsf@gmail.com> <87mt6hcwcq.fsf@gmail.com> <83y1q12utx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60872@debbugs.gnu.org, Jonas Bernoulli , emacs18@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 17 14:11:43 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHlkc-0008Fj-CT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Jan 2023 14:11:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHlkG-0008Nu-Rq; Tue, 17 Jan 2023 08:11:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHljz-0008Gi-NK for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 08:11:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHljy-0006h0-S3 for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 08:11:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHljy-00056d-Ae for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 08:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jan 2023 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60872 X-GNU-PR-Package: emacs Original-Received: via spool by 60872-submit@debbugs.gnu.org id=B60872.167396102419574 (code B ref 60872); Tue, 17 Jan 2023 13:11:02 +0000 Original-Received: (at 60872) by debbugs.gnu.org; 17 Jan 2023 13:10:24 +0000 Original-Received: from localhost ([127.0.0.1]:36094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHljM-00055e-Et for submit@debbugs.gnu.org; Tue, 17 Jan 2023 08:10:24 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:43775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHljJ-00055K-Sd for 60872@debbugs.gnu.org; Tue, 17 Jan 2023 08:10:22 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id r30so6097110wrr.10 for <60872@debbugs.gnu.org>; Tue, 17 Jan 2023 05:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=x79Zg33rSSc0Dr4w7iLnaTMPGzC3/f4Dw4b403AgnNc=; b=VnJnABRdSYLIVq5AcAUWMktsPJsIh9ZrAeLc0xLdbrENA4sdHauQdSIYTkQ6U0VC5+ MzuwUB6vbSSkHOX/TB/msDJdhTAIaZ8nPYNJBpj5yidFdgJOzRpMZETNqXFYb6DQThMx wBRmP/vZ4x2cIxMS2g51cydQDn4FZz4Z2ueLcbnz9Wshnf0LHKDDM+Q8npBa/wep/5iO E5NBaU87Jprmz+VH50/VCokQIsHg9hWqr5XLlHEE7NK/PI9mvCob+Apk2Y8bo9dfLff+ 1M7D0KXIVQIrZcLS8Keq7+hXdErn7vlOn+HCDXT4AmDsmI4LxevHhhbItk+hBC1CJlzN ze7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x79Zg33rSSc0Dr4w7iLnaTMPGzC3/f4Dw4b403AgnNc=; b=tUAeK9cOzxLJ6G/yR9sqMIknQ8gT2qR8bq4ceC1DLfYpS0xNZy4yi1aPxYhFI1S9lm ymCmMjKtXK41GBi7BhaGx+gRsNB99lEuqUVAVyRT02ZiFGd8pRIU5QuWY0LU0GXI1jLp fp62ZJTNQ+DoNPmz73DLl3FLDJVXAoG66cOu5VefXR4OHN81Y6STwRo86fqfFz0ssw0S l4B8k393mPqJMXUQbqKllx/5nF+BjairN4uml/nyRnm/Q78L0/E00vvPA7TvniXFO9I0 3mlV8zClhwRg8xyKeZgSDtw6Xl7cEWjZ137X2xIVwiC3KdiS9RwJqFlITmr680fkNetB 9x/g== X-Gm-Message-State: AFqh2krWCte5J77Qonr04/kDesNI/dewe0K2UP6Gm4LFrwkBLcxCorY3 nD8eEKqdDrafh7sybJVZqW/VOy+z+MY= X-Google-Smtp-Source: AMrXdXsA40d+vEY0m5q8AwsltFaw9NtRNjqBfipUh2L8iP97F4KmQCbDypulVIWcrfz38hcd08Rnig== X-Received: by 2002:adf:f749:0:b0:2bd:eb0a:619f with SMTP id z9-20020adff749000000b002bdeb0a619fmr2421931wrp.29.1673961015351; Tue, 17 Jan 2023 05:10:15 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id r10-20020adfda4a000000b0029a06f11022sm28997626wrl.112.2023.01.17.05.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 05:10:14 -0800 (PST) In-Reply-To: <83y1q12utx.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Jan 2023 14:45:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253549 Archived-At: >>>>> On Tue, 17 Jan 2023 14:45:30 +0200, Eli Zaretskii said: >> If I use >>=20 >> (coding-system-for-read 'utf-8) >>=20 >> instead it all works fine. Eli> coding-system-for-read or coding-system-for-write? The offending Eli> commit didn't change anything about decoding, it only changed how Eli> utf-8-auto behaves on _encoding_. So I expect the problem to be w= ith Eli> coding-system-for-write. You=CA=BCre right, I=CA=BCd inverted my testing. This fails: (coding-system-for-write 'utf-8-auto) (coding-system-for-read 'utf-8) This works: (coding-system-for-write 'utf-8) (coding-system-for-read 'utf-8-auto) Eli> Anyway, it sounds like someone else thought utf-8-auto is about EOL Eli> format? Setting coding-system-for-write to utf-8-auto makes no se= nse; Eli> that coding-system's _only_ raison d'=C3=AAtre is for using in Eli> coding-system-for-read, i.e. when decoding stuff that may or may n= ot Eli> start with a BOM. Is it enough of an error for us to silently replace `utf-8-auto' with `utf-8' when it=CA=BCs specified for `coding-system-for-write'? Eli> Jonas, any idea why these coding-systems are used in Eli> emacsql-sqlite.el? The Git log of the package offers no explanati= on, Eli> and I find no references to it in Issues or PRs around the date of= the Eli> commit. Eli> If indeed there's sometimes a need to send to the process stuff th= at Eli> is encoded in UTF-8 with BOM, then instead of binding Eli> coding-system-for-write around start-process, you should set it us= ing Eli> set-process-coding-system only _after_ the process starts, because= the Eli> way the code is written now, utf-8-auto is also used to encode the Eli> command-line arguments to the sub-process, and so, for example, Eli> fullfile (which I presume is a file name?) gets the BOM prepended,= and Eli> I'm guessing the program emacsql-sqlite isn't prepared for that, a= nd Eli> exits abnormally. Either that or use `make-process' directly and pass `:coding' Robert --=20