From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#61188: 30.0.50; color-lighten-name seems not to work Date: Tue, 31 Jan 2023 21:34:24 +0100 Message-ID: <87ilgmmoj3.fsf@rub.de> References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@fastmail.co.uk> <87wn53iq99.fsf@rub.de> <83o7qe1rbi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7092"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61188@debbugs.gnu.org, gnu@bestley.co.uk To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 31 21:35:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMxLf-0001aC-Vc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Jan 2023 21:35:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMxLQ-0003yL-4D; Tue, 31 Jan 2023 15:35:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMxLL-0003xv-4b for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 15:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMxLK-0006MU-JJ for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 15:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMxLJ-0002Sf-Sk for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 15:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jan 2023 20:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61188 X-GNU-PR-Package: emacs Original-Received: via spool by 61188-submit@debbugs.gnu.org id=B61188.16751972789423 (code B ref 61188); Tue, 31 Jan 2023 20:35:01 +0000 Original-Received: (at 61188) by debbugs.gnu.org; 31 Jan 2023 20:34:38 +0000 Original-Received: from localhost ([127.0.0.1]:55125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMxKv-0002Ru-UV for submit@debbugs.gnu.org; Tue, 31 Jan 2023 15:34:38 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:50855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMxKs-0002Rc-E9 for 61188@debbugs.gnu.org; Tue, 31 Jan 2023 15:34:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1675197265; bh=YHArr5kxlFMVmciluA0EwLxpWJXOcNkGbumnx/lQXWs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=szzbzFR9R0TGqFGJgBQDbPelPi50nUdqxTIgjBl8Gr264xOifswNBCn3e/xi19+Cs 0OiZEHrQyLOn8jAepgsyM0FoeQk8lGinqVPbIdQjo7R7guIU9p9OtzmeM6Dp8D61Qk loZK4Vpj+N88GQowNHeLQclmsjT5WChOxXJEW/YQnsB8GPDbbHoLSkRvwwuXIsAHaD Xn+PLhDrx2GZ84layehQyG62vdeopnkPaiLt8n9Bhj4qjILq/+jfNSTSBz27iFtIWH CC5Bh+b3dm/+YlkJf2ZuQeYLzFTnsLXBBYjBa2hU1DfokPXA3vzHyUCqeu6c3VKWGF 1MnCOmWw2ZeVA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([89.246.36.69]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MgesG-1oiNJt0ln2-00h3Sc; Tue, 31 Jan 2023 21:34:25 +0100 In-Reply-To: <83o7qe1rbi.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 31 Jan 2023 20:39:45 +0200") X-Provags-ID: V03:K1:JHVqqL7rpBemA6uio6mNfCD0QAKhd1aqTp+nCLkE8HIcewIxyKM 73PvB8T4IzgxLYczXvGLW05TZz+v8jZrZs5FjvWFrgmsVXf85RVg5MuO5EJfRNZ5yMczRNa 0sKb2QIiTeGoc84R3jKmgPrJ2i4uGWOg35kgXbJLna3pnR9+dlGyJQ93cmX7XnPM6rZBXaJ XncCKWhEbPpq12tBWitSA== UI-OutboundReport: notjunk:1;M01:P0:j7MFSCEcgMM=;7536G9z8PgjAdPMh3IQnS+IqecP Mw636+En88P48NF8HIGeIm1s83daBZftaqVG0leJuXTetgTpuaz2kMlk8l4S0c1Lsh3sBgrFk qge3banehCY5btNaYpYriCHbqeuuz/x7xPTnyblbanjcVdwpTua3xoyxys0TTF4Vj6v+pFe8i PWuAWH9vIgl18O2eaaH6LsRMoM/StpNCPE9bqhvnfcnmx0uPvoFxnXxqllne3kBZV0ayh3pkt YlaY+cLj8VvYx2D4/1bt39d6DcnSrKQxyDEaESgFFqIyjEyXBR3aNo/bQdahMW/Lw4QgpVwAl BOIn71A33yOIwOd7xhuxp53ookNtAYpkQPisLQ1Ncq5XkypmpZMFUN2MGaxrktY1sg/R6KeCc TOvMAyKifv7trkbHDe3VRehePCqtzMmSA+mv9nyMPz2H7rnRuIuLr9uUo7C7VSw24SnadLNBo hFHR/Tg4PkNgy8TMCrkWlXpPQYqx1uLcPC5KDytvz+27qgQ4jUGd0B/gvfGkqykgDfiPD6sN8 ghAgnkzWAaYOx3UZezfY+nOAtfDU9qY1aAia1yJ637cGHUeDSkYULy11gHeaRIDsP4ogiSgwx chnH1JORab/EDXFlu82s5PwFviw+I1/+nBF0PG7pf4zeopR1VHeMVvJboK8tzzilwwWSaFPpa xIXpL07/O/ntfLPqMCeVATQgrLytakrUG3f/jbMg28XgbiqoXotOup73Wf1i5EN7OK3Xx0qQF nY1boUj6pPLp9VXRJW0QKwog2rp9R9bBfEVICmQRUgOTcMpUfKlpEnWW8AcZWQaqensC4hF+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254546 Archived-At: On Tue, 31 Jan 2023 20:39:45 +0200 Eli Zaretskii wrote: >> Cc: 61188@debbugs.gnu.org >> From: Stephen Berman >> Date: Mon, 30 Jan 2023 23:58:26 +0100 >> >> On Mon, 30 Jan 2023 21:48:20 +0000 "Mark Bestley" w= rote: >> >> > Look at the results of >> > >> > (require 'color) >> > (message "reduce by 100 =3D %s" (color-lighten-name "Black" 100)) >> > (message "reduce by 0 =3D %s" (color-lighten-name "Black" 0)) >> > >> > In emacs 28.2 they give "#ffffffffffff" and 0 as expected. >> > In emacs 30.0.50 they give 0 and 0 >> >> This difference is due to this commit: >> >> commit 656c2dd66e77a5fbeb99d358017e8327401fae05 >> Author: Lars Ingebrigtsen >> Commit: Lars Ingebrigtsen >> CommitDate: Tue Mar 22 15:28:02 2022 +0100 >> >> Fix color-lighten-hsl logic >> >> * lisp/color.el (color-lighten-hsl): Lighten by percentage, >> instead of just adding the specified number to the luminance >> element (bug#54514). >> >> The patch below restores the Emacs 28 result for the above examples >> while keeping the desired result for the example in bug#54514, but I >> have no idea if it yields undesirable results in other cases. > > If all the tests in color-tests.el pass after the change, please > install on the release branch. With that patch one test now fails: the one testing (color-lighten-name "Black" 100). This is because the tests were changed to conform to the code change made in response to bug#54514. So it seems there is disagreement about what the result of (color-lighten-name "Black" 100) should be. Steve Berman