From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thuna Newsgroups: gmane.emacs.bugs Subject: bug#59810: [PATCH] Fix rcirc-markup-text-functions applying to the whole message Date: Mon, 01 May 2023 22:32:41 +0200 Message-ID: <87ildbeqs6.fsf@gmail.com> References: <87tu2cnilo.fsf@gmail.com> <878re8qmxw.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18493"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59810@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 01 22:33:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptaCv-0004dy-T2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 May 2023 22:33:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptaCm-0001QP-Rm; Mon, 01 May 2023 16:33:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptaCk-0001PD-Mz for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 16:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptaCk-00026E-E4 for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 16:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptaCj-0005dG-Vp for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 16:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 20:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59810-submit@debbugs.gnu.org id=B59810.168297317521638 (code B ref 59810); Mon, 01 May 2023 20:33:01 +0000 Original-Received: (at 59810) by debbugs.gnu.org; 1 May 2023 20:32:55 +0000 Original-Received: from localhost ([127.0.0.1]:41144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaCd-0005cv-9r for submit@debbugs.gnu.org; Mon, 01 May 2023 16:32:55 -0400 Original-Received: from mail-ed1-f43.google.com ([209.85.208.43]:50629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptaCX-0005cg-Nb for 59810@debbugs.gnu.org; Mon, 01 May 2023 16:32:53 -0400 Original-Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-50bc5197d33so2774700a12.1 for <59810@debbugs.gnu.org>; Mon, 01 May 2023 13:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682973163; x=1685565163; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=CdpHt/eIZ50Wmeoz/LG9rAtdyjT6RiOYCuc5g4L1jVE=; b=HjVpVSHneTa00Lr/Y7EIGe9YXyGXrhU1cIXbzNMR4g/PVzmH0nJIqW7xkOBLSG/zhb 3SqzqLaboEPwZpjyYwPiKnqRbEE29o/GjqXqPGK0Qua5hfLTUIBsrZg9+nmcl4kzMBQb E0SZHdAqac3ymO+2YawRXWIHGN/2lb4ahXHR1UfPvHk/RAyBUGyZH2j7fKlja1VlxSMR 4IYXFBiX+lSJtc7HMQ4k6kQJT629HwXh/n0xNFLKxbAWvspRqHjaCLCTtvkzqzN/wosY CWB3L7Gxsm0NvHEHrKDwCM4OUDGLwfU2P5l6vJI8cvK3gavavgoSuJg1kuMcyCvfWZBg UBDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682973163; x=1685565163; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CdpHt/eIZ50Wmeoz/LG9rAtdyjT6RiOYCuc5g4L1jVE=; b=SeOXf7FfeCXB7HwQ7urS4LhfX4y5y40eM6cgoZcfAe0xpDpaiBOGZ5MpueqB9DZ5OD CgmTOHaidECKSQb3BZpwHzLGYQH05fJstcacFjFoXFcIBQ4bQZ6UOmallSMkusatzpAu i9e7QS9nhudIjUIQK4dTLwSgMz0bb9TocPsOxHJtiA5/z2BtnRfK05VxkU4y+YHOYWzT 38sat8sFjJsxPqva8c7WK2kDYIZtrx3trGXB3n3c3uSmhGZA7YVGhkTGli6Sf1YuxncX R76Ag6VXpKPFaULoCSZazD/he5k3crkn/UMttjHtRbZqKks2zpkQ0NlvT9TqRDxY2353 Y2HQ== X-Gm-Message-State: AC+VfDw8G1X6k3G2CLWX+o6/77lNvh79D0RnC6Dq39vM010K+UaeYjOM inkf9DNiiSM9iHNdjVgVq07Qcd6CXRQ= X-Google-Smtp-Source: ACHHUZ4agaaGPHgr0VNZU1Aa6mVP/0ru6EYjrSHkJ9D47Y8C0yrolIkjVm4p+tVLHX7cBs/8voFBIw== X-Received: by 2002:a05:6402:42:b0:50b:cd70:8015 with SMTP id f2-20020a056402004200b0050bcd708015mr795712edu.17.1682973163404; Mon, 01 May 2023 13:32:43 -0700 (PDT) Original-Received: from thuna (eduroam-063.unibocconi.it. [90.147.70.63]) by smtp.gmail.com with ESMTPSA id by5-20020a0564021b0500b0050bce352dc5sm272650edb.85.2023.05.01.13.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 13:32:42 -0700 (PDT) In-Reply-To: <878re8qmxw.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260893 Archived-At: > >> Since `rcirc-markup-text-functions' is meant to apply only to the text, >> the changed code, which applied it to the entirety of the message was >> bugged. The simplest example is `\me NICK' with `rcirc-color', where >> NICK is supposed to be colored but isn't because the message reads >> `[... NICK]' and the `]' is recognized as a part of the nick. > > I can not reproduce this, can you give a different example? Nothing else immediately comes to mind, unfortunately. I am able to reproduce it, however: - emacs -Q - Load rcirc-color (version 0.4.5 as of now) - M-x rcirc - /query fsbot (assuming you're in libera.chat) - Type a message so that fsbot responds and its color is registered - "/me fsbot" --- You will see that fsbot is not colored - "/me fsbot " --- You will see that fsbot is colored My emacs version is GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34) of 2023-01-09, in case that matters. >> The patch should fix the issue, although it is possible that some >> already existing functions put to `rcirc-markup-text-functions' will >> break due to them expecting the previous behavior. I still propose the >> patch is applied as the issue is a bug on those functions' end and not >> rcirc. > Why is this necessary, if the only function that would have modified the > buffer gap is `rcirc-markup-timestamp'? I do not understand what you are referring to here.