From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: question regarding my emacs package Date: Wed, 07 Jun 2023 19:48:09 +0000 Message-ID: <87ilbzkq9y.fsf@posteo.net> References: <6cG8Tc55Zz8xk6rE6mJLfDxckAINPcYqp781yltsndzqq5146yw76EZ_2CoUtQT4P2j2afSx5VRD5G1-9qzFHWAW3LxYWwmxh87lvB2MgNE=@rj95.be> <873533mfq3.fsf@posteo.net> <87y1kvkv2f.fsf@posteo.net> <2pOYRsmOk_f2sx48BICCjf9r3Z5OviLDonOFi4dhWoSpd_dAWOXFSA3jO2YeyJ5FBf-Sydd0ZTzTOsAlIg8tc_eBqM9nzq2PW4q4usn4Nuo=@rj95.be> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14535"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: ram Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 07 21:49:14 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6z9d-0003c0-KP for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Jun 2023 21:49:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6z8k-0002Pr-PK; Wed, 07 Jun 2023 15:48:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6z8h-0002PZ-Sg for emacs-devel@gnu.org; Wed, 07 Jun 2023 15:48:15 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6z8f-0004iT-LV for emacs-devel@gnu.org; Wed, 07 Jun 2023 15:48:15 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 798FB240027 for ; Wed, 7 Jun 2023 21:48:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686167290; bh=VZzOG52YCHL3S/TQx6x0R9Q4vs2Om4Kn8T5uTdpYELM=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=LOtNIP+PE6KcGcT51x63s+CIZe9VjbvglvhIagfnsDly28Ed8X5EQPx+6xEqSI9QL uozi+qggkVwpPmkvo4YdEFGGxmjhqfBoXD3+hanjmckR5zulTH8tvkjAFLTERU0JVX fyxdtkUrCLXZleSpyEHbXPiObiEkLV3OkQZkKx2xiEDdjduSHC+BB7dLNafFw/v7oF WyjI0gjv01J4/JYMS9m9ppmc1Zh4XDPRE2vKBD+S6FjtlcHwZ/HdKOTBxSMd+KaEOe gkRfujHBBk0Q5gsDtLpfQ9DF8lHYFYCFnOUMlDuZJ2ilun0cT5vIacVwz+aKEeObuy JcIr51OtMfvPA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QbyZ174H8z9rxH; Wed, 7 Jun 2023 21:48:09 +0200 (CEST) In-Reply-To: <2pOYRsmOk_f2sx48BICCjf9r3Z5OviLDonOFi4dhWoSpd_dAWOXFSA3jO2YeyJ5FBf-Sydd0ZTzTOsAlIg8tc_eBqM9nzq2PW4q4usn4Nuo=@rj95.be> (ram's message of "Wed, 07 Jun 2023 19:45:56 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306688 Archived-At: ram writes: > changing the central type from defclass to cl-defstruct has appeared > to cause bugs? That might have been a typo on my end, I did not evaluate the code and was is a hurry to send you the diff. My point is that you don't need defclass, unless I am missing something in your code (and I don't think the minimal convenience of `with-slots' warrants classes here). > i am not sure what to make of this, but find-file and > its variants do not appear to work when changing only this. the file > is not opened; it is not that the file is opened but the active buffer > isn't switched > > > > > ------- Original Message ------- > On Wednesday, June 7th, 2023 at 2:04 PM, Philip Kaludercic wrote: > > >> >> >> Philip Kaludercic philipk@posteo.net writes: >> >> > > here is the repo: https://github.com/gitrj95/breadcrumbs.el >> > >> > Here are a few suggestions: >> >> >> Oh, and can you address the issue raised by checkdoc?