From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 b54febef5d7: Fix NetBSD build with and without ncurses Date: Sun, 16 Jul 2023 18:02:44 +0800 Message-ID: <87ilak898b.fsf@yahoo.com> References: <168940883684.23439.12214259073355647832@vcs2.savannah.gnu.org> <20230715081357.2B622C06C71@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15841"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Valtteri Vuorikoski To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 16 12:03:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKybc-0003oa-KM for ged-emacs-devel@m.gmane-mx.org; Sun, 16 Jul 2023 12:03:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKyap-0004Oc-8r; Sun, 16 Jul 2023 06:03:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKyak-0004OJ-QZ for emacs-devel@gnu.org; Sun, 16 Jul 2023 06:03:02 -0400 Original-Received: from sonic315-22.consmr.mail.ne1.yahoo.com ([66.163.190.148]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKyah-00019f-05 for emacs-devel@gnu.org; Sun, 16 Jul 2023 06:03:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1689501775; bh=ykxFVH6iucx+EtQjFnCsE/IigWR8f3IKgJjamODKzXM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=XIvyehMUW3nBQPx1ec0Zwcqij3JS9RtcOgP1SgKnUtAQBJCRAN8P3a0zkujSPbMb6RdtVLCBpNJ6cBNz3MtzsArTT4E2UpP6dnwLZTxM9O6+tZzckm0IiDHX7z95x0eUoyYMojuxMbSbWZSWNxKjdEmiiaMpbDBESY67G+99DX2gB3QsvLZurrKSVNv58x+bpl99qcxnlQlCdKr8QWCm5jYgaXQjgKw4rngBB/J6s3cymTRqwwtOoOt/9G8pBlnY+DcKLeVMRG5Ti1sdS0So3EmYwa7oP9fsqpdW8gEnDWNveFzlxDHE/H1IiwDLpGViRJGl4f46N79S56AJQsYsfw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1689501775; bh=O3uq3A8P+MRE9k9W+roaLsiYoh7L+gogMDFjT5YT6Uj=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=maKEzO2iz0Kbg3b3SQwoeFND0LmrtJeYvQp4IiS2kQYMSzW5kwZiBeoydbf9zkWd5v0qSqVU0UkRsim9lOXM/ZINlA/UtgMU+y+VCVxiIHPTOu1VMSFj8ypWWSU+v8JLmKeQVpVbtb8jVArNiq3NoGlIhtS08MDQLoHWAEaueczCOKR1TGGYg34AMBfE6sDOXRIj5fuVHKVwBsUQAfz3t3J/90z8qvF1G9qa6OitVbdo4Ruq4ld7Yul+tPTPb4EsuSOPhgjATuDhyk8DDNqDLUS6LwnFLNMQjQJiw0aC0T5nwtgqq+JXlt9bzdWrj83KROtRb76l8UxbUBgaOY8CNw== X-YMail-OSG: LaSG_zMVM1nV_bcbAvQpMRsc..qzYnOpx0nivJYjR92SSU0IPqi41U4PvbNdTXw PEdpsdhcctLXH29o8ildTRLeME88sUCgtFRjSUxMoA8WXXU4qQ1LSMn2NVjetoQ86T5TFkNHo.TX lH6P.1fsLqydALrciuzW0WU71ShqASiNVdNcRf5QGE_LcXUpuuBj.SoF2zkvvy1Dc_Ou4ngxs7oQ T5i4.cqEdKZ7D8bY805F_HlZog1_ZmkP97nWdm_lZAy.Rr8EVPFSWTevosdd2fZ0FE5WRugffZ6_ u8uQLci6sA56Wk93HUWzThLe8fdp2uAo3xiPzOf_IhM4up.iZEg_Gn01SfX3agAV_Kg4gg3rZs4h B77Cs_iGa0erGS.bSPpivJwZ9aTJhCd5aK8H44QhgfnJAEqTPjX5q5bKmvmmJp4_nbtRWOOG2Pax rRPARJ21SLY5yQJ1khp.J.gVpXcovhDdTAxGLONaR4VAGeCpdaGLBYwj0q.iJ1D3xg.8kblNT9iU Kmf.yEu3G9dXIvmqsBpHlZoJ.HsVzVvTX7.Z.eoiVWmXBoYVwCRO1y9wmWYe6rNmS.ukiHnpvIi5 XrnWRqcSL0HzpRf39k8iF2K.W__Ax6pClp3paSpQETXwsClZ8CPsC49ca2Ij.MvsRPh7Rspbs6Pd 8AGK7UEEh5uJaKaXHFkfLR9LGrSMMx8b4oj1KRunponrn5Gv7UpEftTab.dMQGA4lOFJobgcxqoI jX_WHw0L.pwOwLskSsx137aPMWGkXUyjl7u5IvQL_4BZ6P_374jpRRtgPtQxL8DoR65oG5u5Ug1I ukX14vT6EEm2q_Q9Mf8igYQNf8y52tD3fB1.Xm8QGp X-Sonic-MF: X-Sonic-ID: c5d87120-3396-4a90-8758-3e91cb7b0c09 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Sun, 16 Jul 2023 10:02:55 +0000 Original-Received: by hermes--production-sg3-67fd64777-xdrjm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7d9a0c42a02540badef3d9b26a5b297a; Sun, 16 Jul 2023 10:02:48 +0000 (UTC) In-Reply-To: <20230715081357.2B622C06C71@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Sat, 15 Jul 2023 04:13:57 -0400 (EDT)") X-Mailer: WebService/1.1.21647 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.148; envelope-from=luangruo@yahoo.com; helo=sonic315-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307892 Archived-At: Eli Zaretskii writes: > branch: emacs-29 > commit b54febef5d735efdc907c5e5cd016bed74e338a8 > Author: Valtteri Vuorikoski > Commit: Eli Zaretskii > > Fix NetBSD build with and without ncurses > > * configure.ac (netbsd): Don't set TERMINFO=no unless the termcap > library is either -ltermcap or -lcurses. This prevents aborts > because on recent versions of NetBSD libtermcap is actually a > symlink to libterminfo. (Bug#64577) > > Copyright-paperwork-exempt: yes > --- > configure.ac | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 19575e80cf4..df74f8cd2f8 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -5212,7 +5212,11 @@ fail; > ;; > > netbsd) > - if test "x$LIBS_TERMCAP" != "x-lterminfo"; then > + # NetBSD versions prior to 6.0 lack native terminfo, but have a > + # tputs() built on top of termcap in these libraries. Use native > + # termcap instead in this case. NetBSD >= 6.0 has native terminfo > + # implementation in -lterminfo. > + if test "x$LIBS_TERMCAP" = "x-ltermcap" -o "x$LIBS_TERMCAP" = "x-lcurses"; then >From (autoconf)Portable Shell: The `-a', `-o', `(', and `)' operands are not present in all implementations, and have been marked obsolete by Posix 2008. This is because there are inherent ambiguities in using them. For example, `test "$1" -a "$2"' looks like a binary operator to check whether two strings are both non-empty, but if `$1' is the literal `!', then some implementations of `test'' treat it as a negation of the unary operator `-a'. Will anyone object if I change this to: AS_IF([test "x$LIBS_TERMCAP" != "x-lterminfo" \ || test "x$LIBS_TERMCAP" = "x-lcurses"], [...]) on the release branch?