From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Tropin Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] notifications: Don't expand-file-name app-icon. Date: Wed, 26 Jul 2023 10:47:44 +0400 Message-ID: <87ila7tbhr.fsf@trop.in> References: <877cqpsnct.fsf@trop.in> <83fs5dsd0g.fsf@gnu.org> <87a5vk5l0i.fsf@gmx.de> <83sf9cp32b.fsf@gnu.org> <87v8e8jdzz.fsf@trop.in> <874jls59qo.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39889"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 26 12:56:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOcC8-000ABQ-8r for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Jul 2023 12:56:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOcB7-0004Kr-R8; Wed, 26 Jul 2023 06:55:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOYLa-0002J2-8R for emacs-devel@gnu.org; Wed, 26 Jul 2023 02:50:10 -0400 Original-Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOYLU-0001qB-Jh; Wed, 26 Jul 2023 02:50:08 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 117F71BF20B; Wed, 26 Jul 2023 06:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1690354199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UFAl5NRFAKEKSdzPAxlJy8QtUSOS/jelrDnFe+Capgg=; b=E/+5EoZR9on5ndLeqwHmLgJ7lj8akQtiXaa2WTLqHGweZUy5KjPSPZZE4wIfvTkl688jjg 6jxdS8Z5agWhvw8D2mNiUR4jSaqW2/x82Ze03fCq+gynIr1/FWdapFcNsBrHxE7qfnQW0k Ij/vSWb/bIzK1Bc6e+Y9Tj5HuDhgGYqYfJ3oabZt1fXlnKwlGsrYNY0vPfyq04YdpWgclK HVhAHOms3P1KIJ5H3oxZ6vBFbK4manwvMvchbKMiVa5RfLArawnarZhB2pHBjn4GAavs3T 9HK8dwA8Fk6siDJpywxhOIb4ku0kDARh7z/zCz6G//RL2j75+oIasZEdI9SfdQ== In-Reply-To: <874jls59qo.fsf@gmx.de> X-GND-Sasl: andrew@trop.in Received-SPF: pass client-ip=2001:4b98:dc4:8::228; envelope-from=andrew@trop.in; helo=relay8-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 26 Jul 2023 06:55:35 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308114 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-07-25 16:47, Michael Albinus wrote: > Andrew Tropin writes: > > Hi Andrew, > >>>> Perhaps we extend the arguments of `notifications-notify'? :app-icon >>>> should be either a string (a file name, which is expanded), or a symbo= l, >>>> which denotes one of the Standard Action Icons of the Icon Naming Spec= ification. >>>> >>>> Your example would read in Lisp then >>>> >>>> --8<---------------cut here---------------start------------->8--- >>>> (notifications-notify :title "I am playing music" :app-icon 'multimedi= a-player) >>>> --8<---------------cut here---------------end--------------->8--- >>>> >>>> WDYT? >>> >>> SGTM, thanks. >> >> Does it make sense to introduce edge-case and differentiate between >> strings and symbols? Removing expand-file-name seems to be backward >> compatible and simple solution, but if there is some good reason for >> symbol/string solution - let me know, I will update the patch. > > The D-Bus interface doesn't support file names like > "~/src/emacs/etc/images/icons/hicolor/scalable/apps/emacs.svg". So we > must expand it. > > The notify-send command in a shell supports this, but this is another > use case. I guess that the tilde expansion is performed by the shell. Make sense, sent v2 with symbol value support to the root of the thread. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmTAwZAACgkQIgjSCVjB 3rA4hRAAh96Dp91R0epbt87S3NTE6QWeSdzS6CM6Jlw/UPce8kQLKKgTc8dw1d4S W9YcWL5yTmDVfqbs1hmJB0Cps2hxtkoBJpeTUnnJpVa8Q7Y+kg8FrhZDlqiwdVyb W5Sa5k1RCw1yIhAoODZc860bsJgyFEHiBk/aBp57pMqWP50xvg+mQpzU2XDUr41k 9MT2Oils4g5hiCYYpH0JtBHBL/tpC84VgjwkbxziktPUYB1KMKkaS9PwymvoF2vL owyTNRXtYi4CDgQMAsDL1XrSyhobEaDUZZKxEaOcjaYfRPUhBE0jB4NQFWY8JKbO En/SJU0+5CG0zVedHo/Pt6iZvgzLJ4we7MXWWsKlzKGhRWLH5e6JETcUhqwzldyc fPE9zi+hjpEBWhV/D2n6Zm+kKsB0my1JqK/1mkOvGe/VR3KcWMUzPPgD51s51UsB RigL/WPztk/ZgEbblv8EYJAVcn9J5updz8iSsnz3p4BKL5hy6VB9Lvw/TFejyxxW R8EUUrgAKoGacjDWI8+5SLGcaykaE2p68/LViIuM239wZECLiRKuafUaWvXxTG1Q HwdIpcNK/gD6BmSyEpsXYIPWFUETJ6YuDCGLAFLqyDV3HDemB2uVXPcqoGgfzaqR BOT5wrslP+GZNNTiFg4hoU7F2DvCq6boglAXsy8A9bH2l0oQVa4= =m9Qs -----END PGP SIGNATURE----- --=-=-=--