From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Sat, 02 Sep 2023 15:09:59 +0200 Message-ID: <87il8s202g.fsf@ledu-giraud.fr> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87ilaz1wol.fsf@ledu-giraud.fr> <87fs3xo13z.fsf@yahoo.com> <83zg259iwz.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14641"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Po Lu , stefankangas@gmail.com, 64440@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 15:11:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcQP6-0003dj-Dy for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 15:11:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcQOt-0007Ia-FM; Sat, 02 Sep 2023 09:10:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcQOr-0007IL-00 for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 09:10:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcQOq-0006Z0-OI for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 09:10:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcQOz-0006yT-Oc for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 09:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 13:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.169366021726744 (code B ref 64440); Sat, 02 Sep 2023 13:11:01 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 2 Sep 2023 13:10:17 +0000 Original-Received: from localhost ([127.0.0.1]:35432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcQOH-0006xH-3X for submit@debbugs.gnu.org; Sat, 02 Sep 2023 09:10:17 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:19145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcQOC-0006x0-AD for 64440@debbugs.gnu.org; Sat, 02 Sep 2023 09:10:15 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=v9MLYr6P J8Y2J5Cd2Ie2ueZ7ZRq1KxkYWepTjSig8/A=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=DmsPh2hj79eS5G2DZECvJi0Cz5OvH6 HtZjpA9EAvcqCpqWLRwCcF0RbJ9C4XfEeLG+9rjVCup624ARCPqjoHDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=v9MLYr6PJ8Y2J5Cd 2Ie2ueZ7ZRq1KxkYWepTjSig8/A=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=FSa8cXIq7gomfTl94EqADci1Jg+Y2YRAYHdYpU kOikLzslUmcPhHB+XE6lhu40UE0RIZo86MeAscV4Q/58KQk7oQcPyCMZVse1rc/dB2Tv5p qC2J+uIk+lFNKyB3lX+PMaMsAlOyXksLPNBxx2Z0AC2h0Cr66Bj7GOwqCgYD3yEzGDcdUW WyzgBdOQqgJLip+fQOqKgJZOvZ2NgZOvudRfPpVGhrDqPry5Kyq38dnz4HCMi2ebP42Hag mmw+cf/Gv7631KRc79H6nZ87yBQR22StYJ4EuWJbl99Jz1Td4iVEB/cUWVnFPHQxezdBLd ORxrAPvhwSpbYulBlq73bLKQ== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id c8b7f819 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 2 Sep 2023 15:10:01 +0200 (CEST) In-Reply-To: <83zg259iwz.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Sep 2023 09:41:00 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268995 Archived-At: Eli Zaretskii writes: >> Cc: 64440@debbugs.gnu.org, Manuel Giraud >> Date: Sat, 02 Sep 2023 08:44:16 +0800 >> From: Po Lu via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Stefan Kangas writes: >> >> >> Here is a new set of patches with two more on top of the previous ones >> >> (ie. Number 1 and 2 should be the same as before). >> >> >> >> Number 3 sets the default mouse cursor to be an arrow on the default >> >> menu bar area. Number 4 fixes a flickering I had while moving the mouse >> >> pointer *into* a menu bar entry. >> > >> > Po Lu, do you have any comments on this patch series? >> > >> > Thanks in advance. >> >> Thanks. I don't understand why adjustments to note_tab_bar_highlight or >> note_tool_bar_highlight are warranted, and I think this ought to be >> optional. >> >> ChangeLog entries are also absent from the commit messages. > > I'd appreciate a walkthrough of the patches with explanations for the > significant hunks. It's a non-trivial change, so I think the > rationale and the main ideas of the implementation should be described > and discussed. I'll try to come up with such a walkthrough. > I also have difficulty understanding comments like this one: > > /* Clear mouse face but the mouse cursor. */ > > What does it try to say? Yes sorry it should read "Clear the mouse face but not the mouse cursor" and it is a bit hacky. It was to avoid the flicker of the mouse cursor when moving *into* a menu entry. -- Manuel Giraud