From: James Thomas <jimjoe@gmx.net>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 65914@debbugs.gnu.org
Subject: bug#65914: Exclude current buffer from eww-switch-to-buffer
Date: Sat, 16 Sep 2023 06:01:53 +0530 [thread overview]
Message-ID: <87il8bargm.fsf@gmx.net> (raw)
In-Reply-To: <CADwFkm=h4fMzjHQoKcVkHt0VaH=vgeOR6MedjfgN4wkEZv_k-w@mail.gmail.com> (Stefan Kangas's message of "Fri, 15 Sep 2023 05:05:23 -0700")
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
Stefan Kangas wrote:
> Thanks, I would like to install this patch.
>
> Could you please send the patch as an attachment instead? We prefer
> that patches are created with a command like `git format-patch -1'.
>
> Please also include:
>
> - The bug number of this bug in the commit message, like so: Bug#65914
>
> - A ChangeLog entry, as described in the CONTRIBUTE file.
>
> That would make it easier for us to review and install this patch.
> Thanks in advance.
PFA:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: [PATCH] Exclude current buffer from eww-switch-to-buffer --]
[-- Type: text/x-patch, Size: 1808 bytes --]
From 229b3e5be1df7c753410e840d6ea9c36f822fefd Mon Sep 17 00:00:00 2001
From: James Thomas <jimjoe@gmx.net>
Date: Sat, 16 Sep 2023 05:50:58 +0530
Subject: [PATCH] Exclude current buffer from eww-switch-to-buffer
Exclude the current buffer from the completion list of
eww-switch-to-buffer; to avoid an extra cycling keystroke
(Bug#65914).
* lisp/net/eww.el (eww-switch-to-buffer):
---
lisp/net/eww.el | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 4ddda216afc..e43ef2bfe8b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -2062,7 +2062,8 @@ eww-switch-to-buffer
(let ((completion-extra-properties
'(:annotation-function (lambda (buf)
(with-current-buffer buf
- (format " %s" (eww-current-url)))))))
+ (format " %s" (eww-current-url))))))
+ (curbuf (current-buffer)))
(pop-to-buffer-same-window
(read-buffer "Switch to EWW buffer: "
(cl-loop for buf in (nreverse (buffer-list))
@@ -2070,9 +2071,10 @@ eww-switch-to-buffer
return buf)
t
(lambda (bufn)
- (with-current-buffer
- (if (consp bufn) (cdr bufn) (get-buffer bufn))
- (derived-mode-p 'eww-mode)))))))
+ (setq bufn (if (consp bufn) (cdr bufn) (get-buffer bufn)))
+ (and (with-current-buffer bufn
+ (derived-mode-p 'eww-mode))
+ (not (eq bufn curbuf))))))))
(defun eww-toggle-fonts ()
"Toggle whether to use monospaced or font-enabled layouts."
--
2.34.1
[-- Attachment #3: Type: text/plain, Size: 4 bytes --]
--
next prev parent reply other threads:[~2023-09-16 0:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 10:45 bug#65914: Exclude current buffer from eww-switch-to-buffer James Thomas
2023-09-15 12:05 ` Stefan Kangas
2023-09-16 0:31 ` James Thomas [this message]
2023-10-01 16:53 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il8bargm.fsf@gmx.net \
--to=jimjoe@gmx.net \
--cc=65914@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.