bug#66404: [PATCH] Use delete-all-overlays in clean-mode

bug#66404: [PATCH] Use delete-all-overlays in clean-mode

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 78 bytes --]

Tags: patch

Is there a reason to use dolist instead of delete-all-overlays?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-delete-all-overlays-in-clean-mode.patch --]
[-- Type: text/patch, Size: 902 bytes --]

From d47e0cbe9ecaeb0cd4da12ab70f03d4c138f9265 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@breatheoutbreathe.in>
Date: Sun, 8 Oct 2023 02:54:10 -0700
Subject: [PATCH] Use delete-all-overlays in clean-mode

* lisp/simple.el (clean-mode): Replace dolist
---
 lisp/simple.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index b770d9d7d33..8f2bd84d805 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -549,8 +549,7 @@ Other major modes are defined by comparison with this one."
   "A mode that removes all overlays and text properties."
   (kill-all-local-variables t)
   (let ((inhibit-read-only t))
-    (dolist (overlay (overlays-in (point-min) (point-max)))
-      (delete-overlay overlay))
+    (delete-all-overlays)
     (set-text-properties (point-min) (point-max) nil)
     (setq-local yank-excluded-properties t)))
 
-- 
2.41.0

bug#66404: [PATCH] Use delete-all-overlays in clean-mode

[Eli Zaretskii]

> Date: Sun, 08 Oct 2023 02:58:45 -0700
> From:  Joseph Turner via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Is there a reason to use dolist instead of delete-all-overlays?

Already asked.

bug#66404: [PATCH] Use delete-all-overlays in clean-mode

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sun, 08 Oct 2023 02:58:45 -0700
>> From:  Joseph Turner via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> Is there a reason to use dolist instead of delete-all-overlays?
>
> Already asked.

Oops! Sorry, please close this. (Is there a way for me to close my own issues?)

bug#66404: [PATCH] Use delete-all-overlays in clean-mode

[Eli Zaretskii]

> From: Joseph Turner <joseph@breatheoutbreathe.in>
> Cc: 66404@debbugs.gnu.org
> Date: Sun, 08 Oct 2023 03:32:40 -0700
> 
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Date: Sun, 08 Oct 2023 02:58:45 -0700
> >> From:  Joseph Turner via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >>
> >> Is there a reason to use dolist instead of delete-all-overlays?
> >
> > Already asked.
> 
> Oops! Sorry, please close this.

Done.

> (Is there a way for me to close my own issues?)

Yes, see admin/notes/bugtracker.

bug#66404: [PATCH] Use delete-all-overlays in clean-mode

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>>
>> (Is there a way for me to close my own issues?)
>
> Yes, see admin/notes/bugtracker.

Thank you!! I was not aware of this.

Stefan: Please consider mentioning admin/notes/bugtracker in your talk.

Joseph