From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 66381@debbugs.gnu.org, Daniel Jacobowitz <daniel.jacobowitz@gmail.com>
Subject: bug#66381: 29.1; Auto-revert not polling files when notifications are enabled
Date: Sun, 08 Oct 2023 10:24:32 +0200 [thread overview]
Message-ID: <87il7hfrnj.fsf@gmx.de> (raw)
In-Reply-To: <83edi6z294.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Oct 2023 22:00:39 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
Hi,
>> (if buffer-file-name
>> (and (or auto-revert-remote-files
>> (not (file-remote-p buffer-file-name)))
>> (or (not auto-revert-notify-watch-descriptor)
>> auto-revert-notify-modified-p)
>> (if auto-revert-tail-mode
>> (and (file-readable-p buffer-file-name)
>> (/= auto-revert-tail-pos
>> (setq size
>> (file-attribute-size
>> (file-attributes buffer-file-name)))))
>> (funcall (or buffer-stale-function
>> #'buffer-stale--default-function)
>> t)))
>>
>> When buffer-file-name, revert is true iff:
>>
>> 1. auto-revert-remote-files or the file is not remote
>> AND 2. there is no watch descriptor or a notification was received
>> AND 3. some details about auto-revert-tail-mode OR t
>>
>> If auto-revert-notify-watch-descriptor and not
>> auto-revert-notify-modified-p, then the file won't be reverted.
>> auto-revert-handler does get called by the polling timer, but it
>> doesn't revert.
>
> That's not what your sentence said, which I said wasn't true. You
> said something much more radical:
>
> The implementation does not poll if there's a notification registered.
>
> Moreover, the documentation says that "polling is used even if
> notifications are enabled", and that is true regardless of whether the
> file is actually reverted or not.
>
> IOW, the documentation describes the usual case, where notifications
> are enabled and the watch descriptor is valid. It says nothing at all
> about your situation.
The problem is, that in Daniel's case we get no information that file
notification has ceased to work for the re-mounted file system (no
IN_IGNORED event from inotify). auto-revert-notify-watch-descriptor
still exists, and auto-revert-notify-modified-p isn't modified any
longer. Therefore the file is not reverted even while polling.
You have a wokaround which seems to work. Another approach would be use
polling only for the given mounted file system. Adding "^/google/src" to
auto-revert-notify-exclude-dir-regexp might work.
Best regards, Michael.
next prev parent reply other threads:[~2023-10-08 8:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 17:13 bug#66381: 29.1; Auto-revert not polling files when notifications are enabled Daniel Jacobowitz
2023-10-07 6:17 ` Eli Zaretskii
2023-10-07 15:15 ` Michael Albinus
2023-10-07 16:14 ` Daniel Jacobowitz
2023-10-07 17:02 ` Michael Albinus
[not found] ` <CAN9gPaEi7yPgC4cA9fR-TtSmsVg6CoTOZ=bbZFa1gjQA_B1vGA@mail.gmail.com>
2023-10-07 17:59 ` Michael Albinus
2023-10-07 18:14 ` Daniel Jacobowitz
2023-10-07 18:28 ` Eli Zaretskii
2023-10-07 18:41 ` Daniel Jacobowitz
2023-10-07 18:48 ` Daniel Jacobowitz
2023-10-07 19:00 ` Eli Zaretskii
2023-10-08 8:24 ` Michael Albinus [this message]
2023-10-08 12:38 ` Michael Albinus
2023-10-09 18:17 ` Daniel Jacobowitz
2023-10-10 18:03 ` Michael Albinus
2023-10-13 12:05 ` Eli Zaretskii
2023-10-15 13:58 ` Michael Albinus
2023-10-16 12:38 ` Eli Zaretskii
2023-10-16 14:29 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il7hfrnj.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=66381@debbugs.gnu.org \
--cc=daniel.jacobowitz@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.