From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: ELPA submission: plz-see Date: Wed, 01 Nov 2023 09:14:01 +0000 Message-ID: <87il6lu97q.fsf@posteo.net> References: <87y1fkbmut.fsf@gmail.com> <83y1fk9vcu.fsf@gnu.org> <87bkcfw5ai.fsf@posteo.net> <87cywubl7g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31514"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Augusto Stoffel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 01 10:14:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qy7Ir-00080N-0e for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Nov 2023 10:14:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qy7Ig-0003fi-Jd; Wed, 01 Nov 2023 05:14:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qy7Ie-0003e3-Mt for emacs-devel@gnu.org; Wed, 01 Nov 2023 05:14:08 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qy7Ic-0000r5-Rg for emacs-devel@gnu.org; Wed, 01 Nov 2023 05:14:08 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1D870240104 for ; Wed, 1 Nov 2023 10:14:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1698830042; bh=3NwQnpPWiXWENaKPMsdlAj1AAvc1Wr2vraDjCr92nE0=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=OPqboPVsxrEYyh6mcEs4k1tDKYUfCymzskhofUQN85lT/caRJnPbDUOk9EWgMkkT+ vej/gcjDSUOvGJ3cj9duYxmABJ6Xg5PUwiHOYrBRKT8E9856rXouFfUrBCvIVzPaHX Lqdhjlq3RmbWVwmQ/ZIItnHc/+sz/JVuc8djRK72IzhWsqlBdnLlvr2QI0/E+ja4y+ OX2fDGADk3RqH8PBhdG3eLINK6zT/6HCk9ScsT2HJKP+zzZEqKCquIwRxNx63NDty8 DG8M4QU8B/KZu7vO1ROwn7DFHYwlt02eHPf2x02DpPMrPgCg1Vk6rDZ7fGOnwzooXR LZdpZSE21NzcQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SL1XT4SZJz9rxH; Wed, 1 Nov 2023 10:14:01 +0100 (CET) In-Reply-To: <87cywubl7g.fsf@gmail.com> (Augusto Stoffel's message of "Tue, 31 Oct 2023 21:17:39 +0100") X-Hashcash: 1:20:231101:arstoffel@gmail.com::Sb81souHiWVAw+Zf:0Hj2 X-Hashcash: 1:20:231101:eliz@gnu.org::f+7jFKPK2uJ2laXv:0O0r X-Hashcash: 1:20:231101:emacs-devel@gnu.org::cplPDD98pRa+Qb3a:2WBA Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312045 Archived-At: Augusto Stoffel writes: > Thanks for the comments! > > On Tue, 31 Oct 2023 at 08:43, Philip Kaludercic wrote: > >> +(eval-when-compile (require 'cl-lib)) >> (require 'json) > > By the way, the latter is kind of a non-essential require, would you > rather write this near line 88? > > (defcustom plz-see-content-type-alist > `(... > ("\\`application/json" . ,(lambda () > (require 'json) > (declare-function 'json-pretty-print-buffer "json.el") > (json-pretty-print-buffer) > (js-json-mode))) > ...)) I don't have a strong opinion either way. >> I agree, from what I see this is just an implementation detail. Plz is >> a peculiar enough name as it is, it shouldn't be inherited by packages >> that depend on it. Or is there any reason why the package couldn't also >> use url.el? > > The packages is really closely tied to plz's API, which by the way is a > very nice one. But is this fact exposed to the user? -- Philip Kaludercic