Re: ELPA submission: plz-see

[Philip Kaludercic <philipk@posteo.net>]

Augusto Stoffel <arstoffel@gmail.com> writes:

> Thanks for the comments!
>
> On Tue, 31 Oct 2023 at 08:43, Philip Kaludercic wrote:
>
>> +(eval-when-compile (require 'cl-lib))
>>  (require 'json)
>
> By the way, the latter is kind of a non-essential require, would you
> rather write this near line 88?
>
> (defcustom plz-see-content-type-alist
>   `(...
>     ("\\`application/json" . ,(lambda ()
>                                 (require 'json)
>                                 (declare-function 'json-pretty-print-buffer "json.el")
>                                 (json-pretty-print-buffer)
>                                 (js-json-mode)))
>   ...))

I don't have a strong opinion either way.

>> I agree, from what I see this is just an implementation detail.  Plz is
>> a peculiar enough name as it is, it shouldn't be inherited by packages
>> that depend on it.  Or is there any reason why the package couldn't also
>> use url.el?
>
> The packages is really closely tied to plz's API, which by the way is a
> very nice one.

But is this fact exposed to the user?

-- 
Philip Kaludercic