From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67794: 30.0.50; mouse-face is not respected on SVG images Date: Tue, 19 Dec 2023 14:23:27 +0100 Message-ID: <87il4utjg0.fsf@ledu-giraud.fr> References: <838r5yroyp.fsf@gnu.org> <87v8920xlb.fsf@ledu-giraud.fr> <835y12rle4.fsf@gnu.org> <87bkatgnj6.fsf@ledu-giraud.fr> <83plz9qgsb.fsf@gnu.org> <877clh868o.fsf@ledu-giraud.fr> <83jzphqeto.fsf@gnu.org> <87frzzai4h.fsf@ledu-giraud.fr> <87il4v8iim.fsf@ledu-giraud.fr> <87msu6tl80.fsf@ledu-giraud.fr> <83cyv2ibtr.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="614"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: gerd.moellmann@gmail.com, 67794@debbugs.gnu.org, alan@idiocy.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 19 14:24:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFa54-000AR6-8h for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Dec 2023 14:24:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFa4n-0000P5-Ux; Tue, 19 Dec 2023 08:24:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFa4l-0000NP-QS for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 08:23:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFa4l-0004W3-IF for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 08:23:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFa4o-0003Ri-2x for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 08:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67794 X-GNU-PR-Package: emacs Original-Received: via spool by 67794-submit@debbugs.gnu.org id=B67794.170299221713210 (code B ref 67794); Tue, 19 Dec 2023 13:24:02 +0000 Original-Received: (at 67794) by debbugs.gnu.org; 19 Dec 2023 13:23:37 +0000 Original-Received: from localhost ([127.0.0.1]:34617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFa4O-0003R0-Lz for submit@debbugs.gnu.org; Tue, 19 Dec 2023 08:23:36 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:47378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFa4L-0003Qm-C9 for 67794@debbugs.gnu.org; Tue, 19 Dec 2023 08:23:35 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=dWvBuKnj gMSB9ZpRbHXxqyGI4eS9u6RudV1KHNdF8s0=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=SXi0tHBbgb8wBKfl61SV0GVGCss+zU NXUg17SwFBOkTj11hi6zE8Bn4fIG6siDofVO8yTQBo1eQ5uku0GxtgCg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=dWvBuKnjgMSB9ZpR bHXxqyGI4eS9u6RudV1KHNdF8s0=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=mTVOfpqHZGDD2e4vxTrBGNsKXUmf8hH11T3KM4 aVqv93KMGT1GdOg+OzGJ2lktCIrc6ILJ+R3BCFhIY3iHsrAQE30o6+rzNHUSrrlJz4+Vyp 8uXeULfEdUeM1B4fhTBKFtYyQCM19dZvkXxngmWcP/No+9NS8N2v9GQi7yes/QUJ4D+SNH DgIwzMh3lbH2LZiMu5V/T77ABKNpLY87EpPZIsXkSfCUmqIlKH1R1O3YN7O0YtGEcP8q1+ ytFEM0T+gnjbuJUHrNdqjtbOEdRbqlEGdyC2HBIu+vO7NSUFKt/ZrtlEkN2LO0fyUvGIQT dQcQt/QoYvqxTlF5MPPund2w== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id cc3d01aa (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 19 Dec 2023 14:23:28 +0100 (CET) In-Reply-To: <83cyv2ibtr.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Dec 2023 15:03:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276515 Archived-At: Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: Eli Zaretskii , gerd.moellmann@gmail.com, >> 67794@debbugs.gnu.org >> Date: Tue, 19 Dec 2023 13:45:03 +0100 >> >> > I believe that we need to do some final set-up for the image under >> > X/GTK/whatever and it looks as though this is all that's needed: >> > >> > id = lookup_image (f, s->img->spec, hlinfo->mouse_face_face_id); >> > s->img = IMAGE_FROM_ID (f, id); >> > prepare_image_for_display (f, s->img); <------ >> > >> > Under X we need to send the image to the X server, and under Cairo it >> > does some other stuff. That's what prepare_image_for_display does. It >> > does nothing under NS, so the image worked fine under GNUstep. >> >> Thank you Alan! That does the trick. So here is an updated version of >> the patch that works with XRender (i'll test with cairo). > > With this change, if you move the mouse pointer on and off the image > several times, what happens to the Emacs memory footprint? > Specifically, how many times is memory allocated for the SVG image, > and if it's allocated each time, does it ever get deallocated? I didn't measure this memory footprint but AFAIU lookup_image uses the image cache so an image is allocated once (for one foreground/background combination). And I think that there is an eviction timeout in the image cache, no? -- Manuel Giraud