From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70593: 30.0.50; Dired: buffers of renamed dirs are broken Date: Thu, 09 May 2024 21:27:14 +0200 Message-ID: <87ikzmg50t.fsf@web.de> References: <87a5lguygb.fsf@web.de> <861q6syxzb.fsf@gnu.org> <87plu8xmb9.fsf@web.de> <87msozqes5.fsf@web.de> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eliz@gnu.org, drew.adams@oracle.com To: 70593@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 09 21:27:42 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s59Qc-0005iJ-8L for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 May 2024 21:27:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s59Q3-0006Yn-NM; Thu, 09 May 2024 15:27:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s59Q1-0006YN-Ek for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 15:27:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s59Q1-0008Fo-1x for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 15:27:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s59Pz-0000dg-7t for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 15:27:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2024 19:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70593 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Drew Adams via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: "70593@debbugs.gnu.org" <70593@debbugs.gnu.org>, Eli Zaretskii , Drew Adams Original-Received: via spool by submit@debbugs.gnu.org id=B.17152828132435 (code B ref -1); Thu, 09 May 2024 19:27:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 May 2024 19:26:53 +0000 Original-Received: from localhost ([127.0.0.1]:40807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s59Po-0000dD-MM for submit@debbugs.gnu.org; Thu, 09 May 2024 15:26:52 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:53124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s59Pm-0000d7-JH for submit@debbugs.gnu.org; Thu, 09 May 2024 15:26:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s59Pn-0006Xh-0c for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 15:26:51 -0400 Original-Received: from mout.web.de ([212.227.15.4]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s59Pk-00086m-6U; Thu, 09 May 2024 15:26:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1715282792; x=1715887592; i=michael_heerdegen@web.de; bh=pwxtVos+4I1dZTy8Fqkg7GM2bo7i9ogwPmnfQxICAUA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Pybf4Z85OCpEhAruGetpke+pGl+3EOqmAAj0xfxft+US+S68tTb7gTifGLoecLp0 Ow35ixv+ySyIU+xuUrCr6l00sntpbYDqUlXQCdRoTE3FvLqkIMUmPBzDkg/WXONYt vIb/pXlqHgobXQEbc8/5N67UleDDOOCoCA9uD+F2kZyNamSCwtufNnaWRLmlAlkCo wqSI5bGSoEazYMlRkfK0+7AGMbQCsLcI5YZVtRfv3MoNhQ2xkzx62eDSEuhetrSxU qmI84OQPtEmq8dV2AvJku1VhRqNwkNGNmk6AHQsJr979aHafxmE25C4v/BGHfmTcC ghnbgooitPdp29+yjw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.57.248.23]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M1rTQ-1s2xY81LNg-002McC; Thu, 09 May 2024 21:26:32 +0200 In-Reply-To: (Drew Adams via's message of "Thu, 9 May 2024 16:30:18 +0000") X-Provags-ID: V03:K1:qeClarNWhMYEOn8il/lBNnvdITQyQuZyIvUkv6dZveqQDchmhDJ P/q+Ctpo7TvCw/pXYycVHXEpJloJpYU//KI3lVB6z1tZliri3Bhg4yqw+m6laNJbP5qYv86 LrNWNpuSsd9ZeHJaexzCozN9EZYbyr47hVQ9l8WYve2IPw/38F54rxae7OxxTI92h6AbQ3P vGBBdhckhGgXprGfYgumw== UI-OutboundReport: notjunk:1;M01:P0:ixKWc+W9kCw=;zwf6rakvHjVL+QIBva9dQrKmi0p FjuL4ZJ8vpuPKty1yH/0+bTKfJkcIB5me6u3n+sdGhPe5npLFgJQmlStiwGKd7wpX+SA4ibjD gGIwcIP6+/1JBQwhqyODyYiFBYN/Ye6QyBmWeM2ZNIe+LI9M/jGFuCNdRU/P4wK3AQZoYweFN DWOwHqI00PpB/7xas7sjbI/YKMlrvi/gsovRm+LE4HRHqtcocWXO5ioYJlRGZl2yzXJZsi2md sFedkq3Zvsgn4edf9Be6SjP9uGYJG62+H/Axh7YtnVjv1DvkpHlep6G7qoTQXCH/NcKFnqHeh P6g7hVaRIOyzxMxRIOp0gxhBYjeyEKck2DzbUDF4VuEhkpAp0XiramWS1NgMTIA9dX8PC2daB MkhySVv7T+ZpRgiEz+DV3+3laK9hGCX9jSpkLTAKJ2u14SmvqkK8RroRZZCV9S7Q+jVLkfLok qpiTBGardm9XvvZ95BvqXSvneNY+nzxVktBOIWJ/Yy54thWFUXC4NAFuek4tTx8ZgjM2EOVIT LFKnoXLNOv4PGFgVhdpASH/QlmFGKFGAvTxOldnmgH2DRbeqgluf3M2ES1VI/LQyPMFjImSUp oN5tm/UkOFZw36mV5jb7qrHOzW99QnrJ5VdIokHL6yQihxPzjynGjgChIoVv8LiudZuvDawFP N94csfHYr1om7zVNAGgekZIZ+pXNHsKaNLNRUciYpgslkpwhyAtwK+JTPnk9JLU+YlLbaAxn4 RUw+kH6yBtY946ibr5LXVXEPCJGf1t8sZ3lrOmKm9fMcU8G+F8b4UOsrA/oixOHaQBXeZw8+ Received-SPF: pass client-ip=212.227.15.4; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284775 Archived-At: Drew Adams via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > `dired-directory' is a buffer-local variable. > I don't think there's any support for subdir > listings that are of arbitrary files (i.e., cons > `dired-directory'). I don't recall, but I think > that's the case - in which case it shouldn't > matter that such a list of arbitrary files is > discarded here. But it should be checked first. Not sure whether I can follow. When I call dired with a cons DIRNAME, `dired-directory' will be bound to that cons. And it is consulted for reverting. When I overwrite it with just `default-directory' and revert, the result will be a "normal" dired buffer showing this directory - the explicit listing is lost. In the scenario of the bug this surely makes a difference. My latest patch seems to work as expected. Any comment about the patch btw? Subdir insertion in cons value `dired-directory' buffers are not really supported currently it seems so I took this complication aside for now. The code does handle the subdir alists, though. Thanks for your comments so far Drew, Michael.