all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Reference to non-existent variable `header-arguments-alist'
@ 2024-06-29 13:33 Stefan Kangas
  2024-06-29 13:41 ` Ihor Radchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2024-06-29 13:33 UTC (permalink / raw)
  To: Org-mode

There is a reference to `header-arguments-alist', but I can't find any
such variable in the tree.

./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Reference to non-existent variable `header-arguments-alist'
  2024-06-29 13:33 Reference to non-existent variable `header-arguments-alist' Stefan Kangas
@ 2024-06-29 13:41 ` Ihor Radchenko
  2024-06-29 16:41   ` Stefan Kangas
  2024-06-30  9:42   ` Ihor Radchenko
  0 siblings, 2 replies; 5+ messages in thread
From: Ihor Radchenko @ 2024-06-29 13:41 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Org-mode

Stefan Kangas <stefankangas@gmail.com> writes:

> There is a reference to `header-arguments-alist', but I can't find any
> such variable in the tree.
>
> ./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for

It is not referring to a variable, but to ARGUMENTS slot in the INFO
list. INFO is expected to have the same format as the return value of
`org-babel-get-src-block-info'.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Reference to non-existent variable `header-arguments-alist'
  2024-06-29 13:41 ` Ihor Radchenko
@ 2024-06-29 16:41   ` Stefan Kangas
  2024-06-29 17:49     ` Ihor Radchenko
  2024-06-30  9:42   ` Ihor Radchenko
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2024-06-29 16:41 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Org-mode

Ihor Radchenko <yantar92@posteo.net> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> There is a reference to `header-arguments-alist', but I can't find any
>> such variable in the tree.
>>
>> ./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for
>
> It is not referring to a variable, but to ARGUMENTS slot in the INFO
> list. INFO is expected to have the same format as the return value of
> `org-babel-get-src-block-info'.

So would something like the below be appropriate?

diff --git a/lisp/org/ob-core.el b/lisp/org/ob-core.el
index 727ace84463..4b6c3b5e6bd 100644
--- a/lisp/org/ob-core.el
+++ b/lisp/org/ob-core.el
@@ -2514,8 +2514,7 @@ org-babel-insert-result
           allowed for inline source blocks.

 INFO may provide the values of these header arguments (in the
-`header-arguments-alist' see the docstring for
-`org-babel-get-src-block-info'):
+`header-arguments' alist; see `org-babel-get-src-block-info'):

 :file --- the name of the file to which output should be written.


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Reference to non-existent variable `header-arguments-alist'
  2024-06-29 16:41   ` Stefan Kangas
@ 2024-06-29 17:49     ` Ihor Radchenko
  0 siblings, 0 replies; 5+ messages in thread
From: Ihor Radchenko @ 2024-06-29 17:49 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Org-mode

Stefan Kangas <stefankangas@gmail.com> writes:

>>> ./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for
>>
>> It is not referring to a variable, but to ARGUMENTS slot in the INFO
>> list. INFO is expected to have the same format as the return value of
>> `org-babel-get-src-block-info'.
>
> So would something like the below be appropriate?
> ...
>  INFO may provide the values of these header arguments (in the
> -`header-arguments-alist' see the docstring for
> -`org-babel-get-src-block-info'):
> +`header-arguments' alist; see `org-babel-get-src-block-info'):

I do not think so.  `org-babel-get-src-block-info' is not actually
specifying that "arguments" is an alist.  And it never says "header-arguments".
Both this docstring and also `org-babel-get-src-block-info's
need to be updated.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Reference to non-existent variable `header-arguments-alist'
  2024-06-29 13:41 ` Ihor Radchenko
  2024-06-29 16:41   ` Stefan Kangas
@ 2024-06-30  9:42   ` Ihor Radchenko
  1 sibling, 0 replies; 5+ messages in thread
From: Ihor Radchenko @ 2024-06-30  9:42 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Org-mode

Ihor Radchenko <yantar92@posteo.net> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> There is a reference to `header-arguments-alist', but I can't find any
>> such variable in the tree.
>>
>> ./lisp/org/ob-core.el:2517:`header-arguments-alist' see the docstring for
>
> It is not referring to a variable, but to ARGUMENTS slot in the INFO
> list. INFO is expected to have the same format as the return value of
> `org-babel-get-src-block-info'.

Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=83fe95d2e

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-06-30  9:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-29 13:33 Reference to non-existent variable `header-arguments-alist' Stefan Kangas
2024-06-29 13:41 ` Ihor Radchenko
2024-06-29 16:41   ` Stefan Kangas
2024-06-29 17:49     ` Ihor Radchenko
2024-06-30  9:42   ` Ihor Radchenko

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.