From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UJWgMwJLmGauFAEA62LTzQ:P1 (envelope-from ) for ; Wed, 17 Jul 2024 22:51:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id UJWgMwJLmGauFAEA62LTzQ (envelope-from ) for ; Thu, 18 Jul 2024 00:51:46 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iaard8o8; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721256706; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=e+Q3WpQbDKdo+dspfvPdtfOgsjJc3TVl2ninjba5dT4=; b=o9wRjByb2ZIm3XY6S4JlFggZU+G5rYhCJ4Wbjrl6D3TyeE1JRSkBYvTaFFOf7EzzuIWImR gpNQxTvgeJiqE1/W+87JT3h6qp3+G1GEQTEFO7genP78qyLBQbVtn0J9UG+Z65APJtgeGI 2jtwx3TXQFTO5eBv26tNKVgvElVsM6dsf3WpMTXkk4LMemvI0czclbPAwtjnxADcgLIAK1 ucGBp6b4Y7Fj+bqXggpn3NF8E9BTWrrC/wtlYs/iv5yGHrTRmUFDsQih7eePrmwyAWQtyl 9gheytYNrxMyHYWc/rENuoygwEUVIBTEV+cZmyoc2ij89Xn+wzkHcQerK/Fe1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iaard8o8; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721256706; a=rsa-sha256; cv=none; b=PV9qWS8IVQ+i3WJ5Jz7iGXiGp3VzcUF7KwbP1XrcMN+TTbK77IbRrqPUnxQLjrUq/Pddim KDYXOcECeueFhmIDbwzPO+yhZYqzo6BxAf4Pz0Dk0CPbw6xJKEfOZi9I49oUD0gsXGkTIL Q7FzeAEHP30Gw6Ad9KPMi3xOCyGjgmyJ7MqL1EZzRMAB2rGKdNTJxZo8YHNCkDpM4WBvoD 0HIyEVu6YbhV2g5fvI4FSGlXabipDeJf8bsbenC9TBn5TYDRXk81gOvvE07EQ43aYWPZGG Vz5g9MTq1nbZ+rIk3XFb+2qD1wb/eNeSsDw1Oga7ZfMHOTJrcrk1VWa4Ta53nA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9E77F6ED19 for ; Thu, 18 Jul 2024 00:51:46 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sUDTv-0007pl-OJ; Wed, 17 Jul 2024 18:50:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUDTu-0007pd-DO for emacs-orgmode@gnu.org; Wed, 17 Jul 2024 18:50:42 -0400 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sUDTs-0003DR-Ut for emacs-orgmode@gnu.org; Wed, 17 Jul 2024 18:50:42 -0400 Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-805fc096a34so527439f.3 for ; Wed, 17 Jul 2024 15:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721256639; x=1721861439; darn=gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=e+Q3WpQbDKdo+dspfvPdtfOgsjJc3TVl2ninjba5dT4=; b=iaard8o8ATCQNZn02sUqvXH1DinqXXWqH5WFSSOgoA/qBRSxdiOfza1x5IniqJwYHu e3iGlQ9GwSAELyzfaPxNX4Xz53hEJZAm6d/rE5hz9B4xB6POJb3L+hM1qxCL4zDBSDd4 jdAw1VKZhG1r8ytbPzurNYafwmPEKrGJnfoo+gCybL5rYMu96Sx6Jfa+YxsZey7TKSvP nDwtlm3lNvLlSz43bZrZrScD6R7ET+db1Zjg6PuQVc3pcnWJ2nACYT95CGYjG/8BzbAV XOFkOh7c7o/kiJ7pGtPmtwDmvsGSc7321gagdabPLJ6mv7lh4CveUAiL+O8q/54Um9Sa 5VWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721256639; x=1721861439; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e+Q3WpQbDKdo+dspfvPdtfOgsjJc3TVl2ninjba5dT4=; b=j9efF3Z3fSiKB5KEA6Zs5KvBVDdbahFd2bYGZDXRfCW+k1gS2PSUCT4J+kG0TLCImj KaynmseMl406nzbT+xqW+MsODf67ovwcP5Ot93ciHoc12/rtb4467iPmkuN8yXQeo1KJ 9qVB/Qh87KwxzsjmEvQ62MN73tvn9kuqONjFkp9dyVTzpoKElXcZL13Tehkuk2UIesnk uKHCP+oFGWstfHRxyetEqYm56ke+nuXyezK2/m1wLS8iQ4BD5KzOXpZc1IaBzmYkGq0Q DDjPZQSFRxPvgmbl5uBJwi8W2nyo650y+hTSd57x47iLhJ1PJyldxl8BpK/gW0Va8Qfz 8AQA== X-Gm-Message-State: AOJu0YyRJERjYa4unHhtjL8r7Sha80nI1gf7tEMawamG1nm8zvaLxeIa QiF1SlQsOTFTXIrt9CNqWG/k+trYmkp+yQddXzgJMuO4A9kTxJeYJOjqnw== X-Google-Smtp-Source: AGHT+IENPfPPXiaMN8bm9TGP4ZTCYIQ1T8y4P1peK/mD/XJYPstGLrGbXYOZiRDr6J1lSYbnwzdsZg== X-Received: by 2002:a5e:d91a:0:b0:803:f97f:59e1 with SMTP id ca18e2360f4ac-8170d217353mr229777839f.0.1721256638602; Wed, 17 Jul 2024 15:50:38 -0700 (PDT) Received: from entropy ([2601:243:283:930::5197]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-816c35da741sm93571139f.49.2024.07.17.15.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 15:50:37 -0700 (PDT) From: Nathaniel Nicandro To: Ihor Radchenko Cc: emacs-orgmode Subject: Re: [PATCH] Highlight ANSI sequences in the whole buffer (was [PATCH] ANSI color on example blocks and fixed width elements) In-Reply-To: <87jzhy8x9y.fsf@localhost> (Ihor Radchenko's message of "Sat, 06 Jul 2024 13:28:41 +0000") References: <874jpuijpc.fsf@gmail.com> <87y1n6igvo.fsf@localhost> <878rev1q0k.fsf@gmail.com> <877cueonkj.fsf@localhost> <87zg6dez93.fsf@gmail.com> <871qjobhwa.fsf@localhost> <877ct5fzt6.fsf@gmail.com> <87a5y1mnj0.fsf@localhost> <87msvcgjgv.fsf@gmail.com> <87le9wq2dg.fsf@localhost> <8734uwhlhj.fsf@gmail.com> <875xzsjfvo.fsf@localhost> <87plvhf5gf.fsf@gmail.com> <87msqid9gi.fsf@localhost> <87bk3kuj20.fsf@localhost> <87wmm5yn1m.fsf@gmail.com> <87jzhy8x9y.fsf@localhost> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Wed, 17 Jul 2024 17:50:36 -0500 Message-ID: <87ikx3zl8j.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::d30; envelope-from=nathanielnicandro@gmail.com; helo=mail-io1-xd30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 9E77F6ED19 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -9.74 X-Spam-Score: -9.74 X-TUID: 7TpF6sSRVp+O Ihor Radchenko writes: >> Some comments about the patch, as it currently stands, follow. >> >> - I've introduced two text properties `org-ansi' and >> `org-ansi-context'. >> >> The first is placed on the regions that actually contain ANSI >> sequences and holds information about the sequence that is useful to >> keep around to detect when a sequence has been modified or deleted >> between fontification cycles, as well as information about whether >> or not a sequence should be revealed due to modifications or because >> of visibility changes. > > Let's drop the part with modifications/visibility changes. It should not > be a job for fontification function, so let's not complicate things (as > I mentioned above). I believe that 'org-ansi may no longer be needed > once we drop this. > You want me to remove the code that is responsible for keeping the sequences visible according to `org-fold-show-set-visibility` and according to whether or not the sequence is currently being edited then? What should I do instead? If I remove the code for the modification changes, then it would be difficult to edit the sequences when `org-ansi-hide-sequences` is t since they would remain invisible while editing. -- Nathaniel