From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#53941: 27.2; socks + tor dont work with https Date: Tue, 17 Sep 2024 09:29:15 +0200 Message-ID: <87ikuukab8.fsf@gmail.com> References: <87a5h2lxof.fsf@librehacker.com> <87ldzss6j5.fsf@neverwas.me> <87msk7k9ic.fsf@gmail.com> <87jzfbnj23.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37352"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Christopher Howard , 53941@debbugs.gnu.org, Stefan Kangas , larsi@gnus.org, Eli Zaretskii , gnuhacker@member.fsf.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 17 09:31:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqSg4-0009UT-1V for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Sep 2024 09:31:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqSfo-0001Rs-Ct; Tue, 17 Sep 2024 03:30:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqSfi-0001RX-0l for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2024 03:30:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqSfg-0006m3-BO for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2024 03:30:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=3htpQAxe2N3X8g/comc9XmrfzEUzA5ZujqGg/+sSNb8=; b=Kp7txYOQFSTti0VAwxYjEOMvraC7z5P6xcfmhP0v5dtEGG/Xv+sHOnb71pFBfj33fZxzVNZWZJne5Q5jV7hj91SHM/lQmhDAC6IYIhDA5SGQMuJDzUHOmmHNK4COjjIao0YkbRSAT0eSNXAehnRDvX1DTovF+eSYUvMgKnHY9h/aHiTSn0ImnftBNOMePQS7PGsjIQk0cZb8VLfaCj/OqVNdChnONmiBguX+QFIBhj+l7zc6p/ftLedz8Hhqyh/xlYZzY9NcEuRLKeagEIwGHoLJttg9HHfDsawa9ToQ1UCUV1znyUQWGVUrhYA9wDrywGSibNmrTQSFmz57NXOdgQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqSfu-0001TI-4U for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2024 03:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Sep 2024 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53941 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53941-submit@debbugs.gnu.org id=B53941.17265582405620 (code B ref 53941); Tue, 17 Sep 2024 07:31:02 +0000 Original-Received: (at 53941) by debbugs.gnu.org; 17 Sep 2024 07:30:40 +0000 Original-Received: from localhost ([127.0.0.1]:53782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqSfY-0001Sa-3Q for submit@debbugs.gnu.org; Tue, 17 Sep 2024 03:30:40 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:54291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqSfV-0001SF-K2 for 53941@debbugs.gnu.org; Tue, 17 Sep 2024 03:30:38 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-374b25263a3so2722131f8f.0 for <53941@debbugs.gnu.org>; Tue, 17 Sep 2024 00:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726558157; x=1727162957; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3htpQAxe2N3X8g/comc9XmrfzEUzA5ZujqGg/+sSNb8=; b=ZGPw7r38iHPxfV4JTQdgGhyBZ7LI4b/PHSW+f98vuQpv0vIeT7anMel7UjStKOVtbZ xEva9IlXCen1AsTq74mgDXbiE78hrCK6tjABStZcZWcEN4kGbMrwPJf4jMR3NpoFp5+S lBF2Q/CdAF3cRt8XJXYVaZ2x88qmPm2WGsGL+SmZENh1yQBkgLbCh9iDp6Wp8CXgKQiz DtUUXA/NqXIKgVe4AjcXCMsawz4VHND0zxQHWYTioH4mSZZNFPC++c2SUfU3fG9MwcfM +sHGe2wYa5cuvGC/O+P045KKJ7QArQQ/5y201BLloVFKygElB3ziHH/pGaNWizHk58OP Ozyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726558157; x=1727162957; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3htpQAxe2N3X8g/comc9XmrfzEUzA5ZujqGg/+sSNb8=; b=TXPg4HCwpHhhGXVsOUVQPSb88kmC+ZSNtbR3NkMx16hMMZ033cCutIJLevXQHzStmC yi3/gjsu9EwTMEH3lAd7AMBV1ASiOFF9a3c9qyGXgg0QiSUVyleQxPZT+AmqFkBc9KoE JW+LzDovu5lGK71jX0v0bSnRl1R0JwQ5HuuiTm6X7srsXZT4rBsmZyRkUqBQ77L/Miyl QlbSWK+KaCxBZzIhWqyS6Sy3hrQBoAvvZAJwNBrMlVVhwYPHfQ23yirKwzyIBSmlrWC4 vIjpF3GqHKBUtxfhCOO5dEKuwPkVKMQprP1lvRGq2yj2jtPacyMgRQhs2RqK26lbV/cT P6Bw== X-Forwarded-Encrypted: i=1; AJvYcCWA6umJ7WVW+IU+v5wXy+dSMJ1ueAzBq2v2z/rVSLQJiIiiqcwPVZQL4KGskSvV84rM+WaHtA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz2STgCJvE/Espu/ptKG40Ih/SSBAnyXd5ceA4OY2WgxPJWJq2D r1qI6kQxKWoUs10xjZqAYvt3/+7rnSGpkqY3+HfZDvQNw0q7oweQ X-Google-Smtp-Source: AGHT+IFl/zrvx5wd0RNUGEunSLDtiXQl8mgJRQ14i8xK1TqeYVy0gsyDJu+i3C2cL03OvKV/af+4NA== X-Received: by 2002:a5d:55cf:0:b0:374:ba3f:ad08 with SMTP id ffacd0b85a97d-378d62537d3mr7526648f8f.55.1726558156800; Tue, 17 Sep 2024 00:29:16 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb51:bbfc:8038:1395:d75a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42da2426d1asm94534255e9.42.2024.09.17.00.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2024 00:29:16 -0700 (PDT) In-Reply-To: <87jzfbnj23.fsf@neverwas.me> (J. P.'s message of "Mon, 16 Sep 2024 18:52:04 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291927 Archived-At: >>>>> On Mon, 16 Sep 2024 18:52:04 -0700, "J.P." said: JP> Robert Pluim writes: >> More information hiding by default is a good thing. (I=CA=BCm not the >> original author, I just changed it to look at the actual local >> addresses instead of hardcoding them) JP> D'oh, I see that now. The original author was one Mr. Wong. If you'd JP> like to be spared any further spam related to this bug, please say = so, JP> and I'll remove you from the Cc's. (But if not, I could certainly u= se JP> the input.) I don=CA=BCt mind. JP> + (not (and-let* (((or (and (functionp nsm-trust-local-network) JP> + (funcall nsm-trust-local-network)) JP> + nsm-trust-local-network)) JP> + (addresses (network-lookup-address-info host)) JP> + (network-interface-list (network-interface-list = t))) JP> + (catch 'off-net JP> + (dolist (ip addresses) JP> + (dolist (info network-interface-list) JP> + (when (nsm-network-same-subnet (substring (nth 1 in= fo) 0 -1) JP> + (substring (nth 3 in= fo) 0 -1) JP> + (substring ip 0 -1)) JP> + (throw 'off-net t)))))))) >>=20 >> Since you=CA=BCve inverted the test, you should probably invert the = name of >> `off-net'. JP> Ah, took that "by rote" from the old sentinel variable, but as you = say, JP> it doesn't comport with the semantics. Changed to `nsm-should-check= '. OK. I think you can push that patch to master if Eli is ok with it, regardless of what happens with the others. Robert --=20