From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73768: 'read-passwd-mode' can clobber user defined mode lines Date: Fri, 18 Oct 2024 11:23:52 +0200 Message-ID: <87iktpvk5z.fsf@gmx.de> References: <1d3172d5-3704-40c6-92af-8888b0657871@gmx.at> <87v7xxsj4l.fsf@gmx.de> <87wmicqe5a.fsf@gmx.de> <877cacvv0r.fsf@gmx.de> <49fca25a-d5aa-4f14-ae09-52923eb5ce85@gmx.at> <87zfn3w48f.fsf@gmx.de> <298302a6-c037-4297-9a70-5b48a6fbb649@gmx.at> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14356"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73768@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 18 11:24:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1jEA-0003VR-CV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Oct 2024 11:24:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1jDu-0006HM-OT; Fri, 18 Oct 2024 05:24:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1jDt-0006GY-9o for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 05:24:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1jDt-0007l9-19 for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 05:24:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=7OiHC66ykQ8BQNHUxIUlO4pVGWu7TnrqYUgWK2z/s8M=; b=BBLGDrDnrSPLFxzPBssLZyXtGedVhQ14ADwnE2ThC7AzluP13DewJQLpA0mXms2WHLhK3AUQTwgzTUuqgM1JmUsd/SZM9ftMo/U6LBiTNocYF6ka9HEZx0xlVg1eW2D9h96b/6IIQk+embAVGNKSwffqW6vigDJFEsx/Bys9E4ylb5VdTccHuQMn+XzuMrHIVfFIEPSXBWoDp1gmS5THjvJPPhQEtiUtdHZ/FDnxt7AawHNN/k+Z2IHUIFspXAMn84a52/mkmVVGHifQty5DwhXqnaFkhSntElhPH2f2K2QiU+vwV6iSfLiAMkGzigwCYEM598OZxYMCtNqoAApHjA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1jEF-00050f-3G for bug-gnu-emacs@gnu.org; Fri, 18 Oct 2024 05:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Oct 2024 09:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73768 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 73768@debbugs.gnu.org Original-Received: via spool by 73768-submit@debbugs.gnu.org id=B73768.172924346619168 (code B ref 73768); Fri, 18 Oct 2024 09:25:03 +0000 Original-Received: (at 73768) by debbugs.gnu.org; 18 Oct 2024 09:24:26 +0000 Original-Received: from localhost ([127.0.0.1]:37076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1jDd-0004z6-TP for submit@debbugs.gnu.org; Fri, 18 Oct 2024 05:24:26 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:53533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1jDc-0004yq-7b for 73768@debbugs.gnu.org; Fri, 18 Oct 2024 05:24:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1729243433; x=1729848233; i=michael.albinus@gmx.de; bh=7OiHC66ykQ8BQNHUxIUlO4pVGWu7TnrqYUgWK2z/s8M=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=tLKVLJkgIWUfJor1ZTjc5rkUajzcB5+jWDdkZmDeYkjaxL5MtcKzzXjeG4WXXH+p WObI4xxUr2L7yvA44Ngh9nX3yntOE77m5wrqo6AJBm3YddU9hw8dF7QtZdogkXHp+ ooL1XgVxIsdVNrq3qgnAXTOaKEFUUAXsn9gvQ2hBeC4lHA5amtpA+zjwoi/JgRr2D keb+4ZEmsvzLbGmNWsioN++Ene4hrdpFKRJuih+J0k2az9suEO3VLdwvsvzH7uitD 2d1KArNFbm+iDkAL9KToh81RpNRQNq4LajeHZjyDD19juFWzyuCMj8Bm/JLRZ3rPy 713aaAjhmPxjRIXHyQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MirjS-1tXmmL2smi-00oxJX; Fri, 18 Oct 2024 11:23:53 +0200 In-Reply-To: <298302a6-c037-4297-9a70-5b48a6fbb649@gmx.at> (martin rudalics's message of "Thu, 17 Oct 2024 20:09:33 +0200") X-Provags-ID: V03:K1:blxbiDPwqAXPcoE5sv8xYKWBF6HmBXZqrmm3djtsIxCTg/dwSyo 0l6icddozCCf95fdFOcM9MP5BsOs3J4HfgMksl4OY6HFeA6rpPCjPQpQJDavxgjsLeGbC/i 14fSwctggaDuqwtI0Unu7JXUdxJuiVysnSuNX+yIEtXMONzc/OyQ8nxccqGSdvwkcOfHZZ1 zNFFjhS9Y9dbllytLCimg== UI-OutboundReport: notjunk:1;M01:P0:QWxnjt0swjE=;zztnpuS5Fjd6IfoSctkxbPUlux0 kiRO/08LyTFW//2cTEJlAa54W5jmutRoXBbXyLRwb3NbHqVb3HBUHT1sxTeTm4MTZ1rzdSW40 SDxoU1UrPP3hfb79lHaLYXKzfs6tAWXwT8y1WTM+tApuH5PIt/QWEB62yRBlFLl7bvMRZdmV9 mkCUsuBsNA/yCyGrDOMUYd0OBuowPFHfEIgi4+xuyTEQBASqVwuvlLmX+HOjdl2X0OZTITPsB MX6/Fe6D2s9uAbWwg9/SxOsjL/fgulahABc8lCIXGd/HHcHUKGRG+i9ZS3TyVyZITpIx43YUB FtVDHcR6p8mpIQ7PraCBMoNvNIoDL/oYNGaOAFJ2ISSJOOvBi+T4sZSHpWbhPa3KuU4g3kg99 0pdk3bdDnytXl+PWcOPUYmqo+YG8pAlB6W3CF5daJmBHprbgiGaLCPrfY8mNbPMxNOzMSwQAF 4FS5/BkM9Gp11ZVv6uDKwkrw72KR4LTmtCXJdD/5N2Z7VAs7Zw/iMTpgqDJDZM+s2RJX2qZrj Is9vXUdhu+2rC70Ui5E48oRVHk9HDL+wN58wopJ0hbL/LgthLQQLhyZNnYXQ6I5FqZ3Ke+rPh KIK0eByxWDPfxEdXVt+65BPs1oFe2LmY0LQCGeAlcjKpCwgebqMm/UK05ZAXnGgk2hpWexVa3 jDx4tuizhGTxZmhGKNduCXTN3hmjS0Lq9bhiLjlKvejzX9jLtM1vWkY0ftUkDQ1MJY6AQcze8 pEnkCKe9YqeemhkGjOOjTCkLivy9rqtvKWEmQWhovIB0PPflHALNjfFmvMtenHSlErfUtRF7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293775 Archived-At: martin rudalics writes: >> I haven't seen any application in the wild which offers cascaded >> password input. What would be the use case for this? My feeling is, that >> this is a misuse. We might not forbid it, but we might show a warning. > > Then why does 'read-passwd' deliberately offer it via > > (let ((enable-recursive-minibuffers t) > > If it's a misuse, it should rather bind it to nil. This is not offered for cascaded password input. It is enabled for recursive use of the minibuffer for any purpose. For example, while typing the password, you need to check somehing else via 'M-:'. This is possible now. > Another mystery: After > > commit de88ed8646383301f20f8340e13d43e5918310fa > Author: Lars Ingebrigtsen > Date: Sun Oct 13 05:15:18 2019 +0200 > > Hide passwords more in `read-password' > > * lisp/subr.el (read-password--hide-password): Factor out (bug#17127). > (read-passwd): Use it in post-command-hook instead of > after-change-functions to ensure that we hide the password no > matter what inserts text. > > entering 'read-passwd' does > > (add-hook 'post-command-hook #'read-passwd--hide-password nil t)) > > while exiting still does > > ;; Not sure why but it seems that there might be cases where the > ;; minibuffer is not always properly reset later on, so undo > ;; whatever we've done here (bug#11392). > (remove-hook 'after-change-functions > #'read-passwd--hide-password 'local) > > If that fix of Bug#11392 (or Bug#11397) were really needed, then we > should remove read-password--hide-password from 'post-command-hook' now. > But there were no bug reports in the last four years so probably that > bug was fixed by other means. In either case the current 'remove-hook' > is a noop now. Hmm, yes. While adding read-passwd-mode, I didn't check all settings in read-passwd. Likely these settings are superfluous now. I will check in master once the other patch has arrived it. > martin Best regards, Michael.