From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#64055: Implementation of modifying VC change comments for Git Date: Sun, 27 Oct 2024 10:25:21 +0800 Message-ID: <87iktenuy6.fsf@melete.silentflame.com> References: <874j59wym3.fsf@melete.silentflame.com> <868qukl73k.fsf@gnu.org> <87bjzfuzaq.fsf@melete.silentflame.com> <87a5err20n.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37386"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Morgan.J.Smith@outlook.com, Eli Zaretskii , 64055@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 27 03:26:52 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t4szS-0009Xp-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Oct 2024 03:26:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t4szC-0007Rq-JP; Sat, 26 Oct 2024 22:26:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4sz7-0007RX-NC for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2024 22:26:30 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t4sz7-0004TX-Ek for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2024 22:26:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=3w5s+i/souyzYieBg2qwav4deSCak4d5v3palhjyfQw=; b=WxcWljnBwQMAKT6jirohGNqkaXT7c2H2uSQhVZCIGVq1m0ABr63tdx3gCoBCWWVNdhNMjiW5Z1bnOs82ggFRrRy1I9l07OhDf9wav737KahC2LFzoW6AVJG0y9hStOBNTFM/1VkLz4iNUtxVjZM1yohiySaXWrj/UAY6gqo4FjAmt2NS1u0GLBmhd7hqxVq/XOjMvz/vWtaoqBogjm7geTLIXfu2re0nYoGH3NxN6OJwwSprGH1XaJ8AP0FBGBFT9h9EpPqpAuC7oqjZseIdurmyV7qHK1rUK3SnYnXeUEQ4oTtQdD/8OrO+ERGea+rK1kiFx3gAogV4WWpd+qOM4g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t4sze-0000PE-Bu for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2024 22:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Oct 2024 02:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.17299959761503 (code B ref 64055); Sun, 27 Oct 2024 02:27:02 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 27 Oct 2024 02:26:16 +0000 Original-Received: from localhost ([127.0.0.1]:43376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4sys-0000OA-QV for submit@debbugs.gnu.org; Sat, 26 Oct 2024 22:26:15 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:49282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t4syl-0000NW-EV for 64055@debbugs.gnu.org; Sat, 26 Oct 2024 22:26:12 -0400 DKIM-Signature: a=rsa-sha256; b=C7gCs2dqVy1pjgJ0IN1SmPkSAP1HNa0hCGePwIT8ZZES4ax6HByF8dPcJjDGaMTi536m7cMhlCXnBuRhURhCPptwa870JvW8PFvnoeEXLIb4E4+56/KemGtvFsdXsqUPuzUtHoBd5tWDoqAve06KW0HAfSh5cdbcGRHYtX+XOht34knmXmVAsaAOV/K2ylhtmsvEy+xevbes+dtW3wfVqS4WliSPEZDDpFAdaK450m6Np43WJ491KoVP37j2Jg9+zG+bBXYXAthrA3pPPaoBsZH/Hy4ej6/T9RUeOWdEc61DcFlh00nTiLzORerAePtPLNhsuqwo9O/lQLNurHiRjg==; s=purelymail2; d=spwhitton.name; v=1; bh=+fFWySiUCDK/I/Opa1TAYL3wMvLqNi1akmElai2l08U=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=CuBGctpaj4e0mUSRcvLjY7H3ithzfHKD8+TSQZ85bVALO2bsLPNKpPDAzBF4YR5a9T7kZXwAklZ5ZFQJG8+gDaloj7pzwPiXSMvUhbxhNIg1yUGZERTuh7E39XSfDGiBiIHtlIbkBNWrJ/bgZ9rcdayFok+LLuxN3m/MEuQZQft8B9aoGbYBR+ynKgrTsXC8kqzDQ6ZW/cBdjUGn699IR/+jYP5cWUwovg3WfQ2XWh/6ED2gyll/0eE2vhPT85mqfjN4lDS1cB5dT11ydlSWLxBQX9WPeg8hNwdbmNarKJoyohORF4lL05+ymz88H6G6z86saWyKv6u6PmTLOMXFpg==; s=purelymail2; d=purelymail.com; v=1; bh=+fFWySiUCDK/I/Opa1TAYL3wMvLqNi1akmElai2l08U=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 64055@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1200514287; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 27 Oct 2024 02:25:23 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 35E8C7EE248; Sun, 27 Oct 2024 10:25:21 +0800 (CST) In-Reply-To: (Dmitry Gutov's message of "Sun, 27 Oct 2024 03:05:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294302 Archived-At: Hello, On Sun 27 Oct 2024 at 03:05am +02, Dmitry Gutov wrote: > On 26/10/2024 06:12, Sean Whitton wrote: >>> Maybe we can rephrase it like this: >>> >>> Some VCS commands can change your copy of published change history >>> without warning. In VC we try to detect before that happens, and stop. >>> You can customize this variable to permit rewriting history >>> even though Emacs thinks it is dangerous. >>> >>> So far, this applies only to using 'e' from Log View mode for Git. >> Whether or not there is a strict mismatch, I like your new text more. >> Please install it. >> >>> BTW, there is another existing command which can end up changing >>> published history: 'vc-git-log-edit-toggle-amend'. I wonder what will >>> be our plan for it. Maybe we just add the same check there. >> Thanks for reminding me about this. Yes, I think it should be fine to >> just add (vc-git--assert-allowed-rewrite "HEAD") or similar. Would you >> like to do it along with your NEWS change? I guess, then, dropping the >> "So far ..." sentence. > > Great! Pushed in 2030b8c7f24. Thanks. > Speaking of the description in NEWS, completion just reminded me that > we also have vc-hg-log-edit-toggle-amend, maybe we could also do > something about it. Yes, would be good to. > I also got to thinking about the older VCSes supporting > 'modify-change-comment'. OT1H it also modifies "published history" in those > instances. OT2H it does that in a way that won't lead to later conflict, > because none of those systems are distributed. So I suppose we don't need to > worry about them. Yes, I think that's right. -- Sean Whitton