[PATCH worg] .dir-locals.el: Disable byte-compilation.

[PATCH worg] .dir-locals.el: Disable byte-compilation.

[Suhail Singh]

---
 .dir-locals.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.dir-locals.el b/.dir-locals.el
index 962c17f2..9f7310ed 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -1,3 +1,6 @@
+;;; Directory Local Variables            -*- no-byte-compile: t -*-
+;;; For more information see (info "(emacs) Directory Variables")
+
 ((nil
   (indent-tabs-mode . t)
   (tab-width . 8)

Re: [PATCH worg] .dir-locals.el: Disable byte-compilation.

[Max Nikulin]

On 04/12/2024 04:43, Suhail Singh wrote:
> +++ b/.dir-locals.el
> @@ -1,3 +1,6 @@
> +;;; Directory Local Variables            -*- no-byte-compile: t -*-

Sorry, I do not follow Emacs development close enough. Does it mean that 
it becomes more aggressive and tries to compile files that do not really 
affect performance?

I recall intentions to implement some exceptions for `lexical-bindning', 
so I would expect that .dir-locals.el files are not compiled by default. 
I mean the following thread:

<https://yhetil.org/emacs-devel/50E29988-D354-4D10-990F-31828DBE6411@gmail.com/>
emacs-devel. missing lexical-binding cookie warning when loading .el 
files. Fri, 3 May 2024 19:28:02 +0200

Re: [PATCH worg] .dir-locals.el: Disable byte-compilation.

[Suhail Singh]

Hello Max,

Please note that I am not subscribed to the mailing list.  As such,
please ensure that you include my email in the addresses if you'd like a
timely response (or, in some cases, a response at all).

Max Nikulin <manikulin@gmail.com> writes:

> On 04/12/2024 04:43, Suhail Singh wrote:
>> +++ b/.dir-locals.el
>> @@ -1,3 +1,6 @@
>> +;;; Directory Local Variables            -*- no-byte-compile: t -*-
>
> Sorry, I do not follow Emacs development close enough. Does it mean that it
> becomes more aggressive and tries to compile files that do not really affect
> performance?

Since 2022-10-05, when adding directory-local-variables, the
no-byte-compile cookie gets set.  I believe this change was introduced
in response to bug #58486.

-- 
Suhail

Re: [PATCH worg] .dir-locals.el: Disable byte-compilation.

[Max Nikulin]

On 10/12/2024 21:50, Suhail Singh wrote:
> 
> Since 2022-10-05, when adding directory-local-variables, the
> no-byte-compile cookie gets set.  I believe this change was introduced
> in response to bug #58486.

Thanks for educating me.

I found that the changelog entry
> Add no-byte-compile to the ".dir-locals.el" auto-insert template
is more clear than the commit message
> * lisp/files-x.el (modify-dir-local-variable): Add a 'no-byte-compile'
> file local variable when generating a .dir-locals.el file.

At first I did not realize that the new lines match the template. I 
would expect setting `no-byte-compile' to nil for `lisp-data-mode' (or 
for .dir-locals.el files) by default instead of adding the cookie to 
every file.

Re: [PATCH worg] .dir-locals.el: Disable byte-compilation.

[Suhail Singh]

Max Nikulin <manikulin@gmail.com> writes:

> Thanks for educating me.

You're welcome :)

> I would expect setting `no-byte-compile' to nil for `lisp-data-mode'
> (or for .dir-locals.el files) by default instead of adding the cookie
> to every file.

Or, to start using .dir-locals.eld as the default.  IIUC, this is what
Stefan M and Stefan K had suggested.  It's unclear if that was
implemented for newer versions of Emacs.

-- 
Suhail

Re: [PATCH worg] .dir-locals.el: Disable byte-compilation.

[Ihor Radchenko]

"Suhail Singh" <suhailsingh247@gmail.com> writes:

> ---
>  .dir-locals.el | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.dir-locals.el b/.dir-locals.el
> index 962c17f2..9f7310ed 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,3 +1,6 @@
> +;;; Directory Local Variables            -*- no-byte-compile: t -*-
> +;;; For more information see (info "(emacs) Directory Variables")

Thanks!
Applied.
https://git.sr.ht/~bzg/worg/commit/650cce9a

I modified the commit message removing "." after the commit title and
adding the explanation you gave to Max.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>