From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Add completion to compilation-read-command Date: Tue, 24 Dec 2024 12:53:03 +0000 Message-ID: <87ikr9b5u8.fsf@posteo.net> References: <87ttatb9g0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18761"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Spyros Roum Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 24 13:53:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQ4Q0-0004mK-B6 for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Dec 2024 13:53:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ4PS-00030o-Tb; Tue, 24 Dec 2024 07:53:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ4PP-00030N-58 for emacs-devel@gnu.org; Tue, 24 Dec 2024 07:53:12 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ4PM-0000uo-C0 for emacs-devel@gnu.org; Tue, 24 Dec 2024 07:53:10 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 140D3240027 for ; Tue, 24 Dec 2024 13:53:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735044785; bh=GKXj/G5Yziz33R0EMJldcJNuaaTBJMger1C1ikusaMI=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=jRAjPWP9voFlajnBUa+DEO8CBQWQgFcWHfirMP9fkDpE+yUV87LlVoYEiuHsx6Ht+ gOFzBl86ioyx0qUAeqlzP2MdOOevQVVZkQsjbMNQqFuiZQ4QyNXt4bG4HuHfyUjW5K gHsUPjJndW1oLEODUeYgkBLEj+5uVxtx2YtG4CXZhCP/m8oD93Dk0Y/R6QX5UuOToS dFR2SpCSxCnDjOFLf6HeFLpVUBK4/uJayp6u3IFLH7S7OW5VrqNTBzsgeNOLF1eDMD CrQ6PEEGJoD50OeJIqszrvLvjl9a5VGe3jVMbzzpXsvgfQakiOH9UflDErlPIEyq42 txLmtuvdoeI9A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHZYr3F76z6txd; Tue, 24 Dec 2024 13:53:04 +0100 (CET) In-Reply-To: (Spyros Roum's message of "Tue, 24 Dec 2024 11:57:15 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326999 Archived-At: Spyros Roum writes: > Philip Kaludercic wrote: >> Spyros Roum writes: >> >>> Hello all, >>> >>> Recently, I started using `M-x compile` more but as I was used to my >>> shell suggesting past commands as I type (and tools like atuin) >> In case anyone else hasn't heard of this, it describes itself as >> >> Atuin replaces your existing shell history with a SQLite database, and >> records additional context for your commands. Additionally, it >> provides optional and fully encrypted synchronisation of your history >> between machines, via an Atuin server. >> >> (https://github.com/atuinsh/atuin) > > Thanks for adding the description, I should have done that myself. No worries. >>> , I was >>> missing auto-complete a lot. >>> I managed to add this functionality by writing a simple function based >>> on compilation-read-command that uses completing-read instead of >>> read-shell-command. >> Do you know about the `bash-completion' package? It enhances >> `read-shell-command' completion with completion data provided by bash. >> It is very easy to set up, >> >> (use-package bash-completion :ensure t >> :init (bash-completion-setup)) >> >> should do it. > > I was not aware of this, but it doesn't seem to do what I'm looking for. > For once, I am not using bash, but even ignoring that it doesn't seem > to have the effect I'm looking for. > > I'm trying to get the compile prompt to suggest completion based on > past commands I've run. My bad. In that case, why not use C-r to search `compile-history'? > >>> Then I used advice-add to overwrite the >>> original=C2=A0compilation-read-command with mine. >>> >>> So far this works well, and as far as I can tell there is no good >>> reason not to make compile auto-completing, it already has a history >>> that you can navigate anyway. >>> >>> With that said, this is the first time I write here and the first time >>> I'm trying to contribute to emacs, so I'm not sure what the best way >>> to go from here would be. >>> I think some decisions would need to be taken, for once I am not sure >>> if it's acceptable to change the default and make it completing or if >>> there should be an option for it. >> I am not sure if you meant to attach any code, but that would probably >> be the best place to start. >> >>> Looking forward to your feedback, thanks > > You are right I should have posted code, so here is what I have: > > =C2=A0 (defun compilation-read-command-with-autocomplete (command) > =C2=A0=C2=A0=C2=A0 "Use `completing-read` to add autocomplete powers to c= ompilation read" > =C2=A0=C2=A0=C2=A0 (completing-read "Compile command: " compile-history > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 nil nil command > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (if (equal (car compile-history) command) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 '(compile-history . 1) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'compile-history))) > > =C2=A0 (advice-add > =C2=A0=C2=A0=C2=A0 #'compilation-read-command > =C2=A0=C2=A0=C2=A0 :override #'compilation-read-command-with-autocomplete) If this were added to Emacs, we probably wouldn't use advice. I think the best strategy for you would be to prepare a patch against compile.el and add a user option that allows prompting the user with completing-read. What do you think?